[GitHub] spark pull request #22686: [SPARK-25700][SQL] Partially revert append mode s...

2018-10-11 Thread HyukjinKwon
Github user HyukjinKwon closed the pull request at:

https://github.com/apache/spark/pull/22686


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #22686: [SPARK-25700][SQL] Partially revert append mode s...

2018-10-11 Thread HyukjinKwon
GitHub user HyukjinKwon reopened a pull request:

https://github.com/apache/spark/pull/22686

[SPARK-25700][SQL] Partially revert append mode support in Data Source V2

## What changes were proposed in this pull request?

This PR partially revert 
https://github.com/apache/spark/commit/5fef6e3513d6023a837c427d183006d153c7102b 

It happened to create a readsupport in write path, which ended up with 
reading schema from readsupport at write path.

See also https://github.com/apache/spark/pull/22009#discussion_r223982672

## How was this patch tested?

Manually facing an issue.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HyukjinKwon/spark append-revert

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/22686.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22686


commit 227920a23caf3b9a556a35df2d01c37dcddf244b
Author: hyukjinkwon 
Date:   2018-10-10T08:57:53Z

Partially revert append mode support in Datasource V2




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #22686: [SPARK-25700][SQL] Partially revert append mode s...

2018-10-10 Thread HyukjinKwon
Github user HyukjinKwon closed the pull request at:

https://github.com/apache/spark/pull/22686


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] spark pull request #22686: [SPARK-25700][SQL] Partially revert append mode s...

2018-10-10 Thread HyukjinKwon
GitHub user HyukjinKwon opened a pull request:

https://github.com/apache/spark/pull/22686

[SPARK-25700][SQL] Partially revert append mode support in Data Source V2

## What changes were proposed in this pull request?

This PR partially revert 
https://github.com/apache/spark/commit/5fef6e3513d6023a837c427d183006d153c7102b 

It happened to create a readsupport in write path, which ended up with 
reading schema from readsupport at write path.

See also https://github.com/apache/spark/pull/22009#discussion_r223982672

## How was this patch tested?

Manually facing an issue.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/HyukjinKwon/spark append-revert

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/22686.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #22686


commit 54e59d53c0d91288536644819d8ead80e13475ea
Author: hyukjinkwon 
Date:   2018-10-10T08:57:53Z

Partially revert append mode support in Datasource V2




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org