[GitHub] spark pull request #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comm...

2018-11-15 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/spark/pull/23044


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comm...

2018-11-15 Thread viirya 
Github user viirya commented on a diff in the pull request:

https://github.com/apache/spark/pull/23044#discussion_r233827093
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
 ---
@@ -76,8 +76,6 @@ object GenerateOrdering extends 
CodeGenerator[Seq[SortOrder], Ordering[InternalR
   row: String,
   ordering: Seq[SortOrder]): Seq[ExprCode] = {
 ctx.INPUT_ROW = row
-// to use INPUT_ROW we must make sure currentVars is null
-ctx.currentVars = null
--- End diff --

I think so.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comm...

2018-11-15 Thread cloud-fan 
Github user cloud-fan commented on a diff in the pull request:

https://github.com/apache/spark/pull/23044#discussion_r233819066
  
--- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
 ---
@@ -76,8 +76,6 @@ object GenerateOrdering extends 
CodeGenerator[Seq[SortOrder], Ordering[InternalR
   row: String,
   ordering: Seq[SortOrder]): Seq[ExprCode] = {
 ctx.INPUT_ROW = row
-// to use INPUT_ROW we must make sure currentVars is null
-ctx.currentVars = null
--- End diff --

I think the conclusion was to keep it?


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23044: [SPARK-26073][SQL][FOLLOW-UP] remove invalid comm...

2018-11-15 Thread heary-cao 
GitHub user heary-cao opened a pull request:

https://github.com/apache/spark/pull/23044

[SPARK-26073][SQL][FOLLOW-UP] remove invalid comment as we don't use it 
anymore

## What changes were proposed in this pull request?

remove invalid comment as we don't use it anymore
More details: #22976 (comment)

## How was this patch tested?

N/A

Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/heary-cao/spark followUpOrdering

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/23044.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #23044


commit 786cd4d3e4c06033203618129de080a8e7d72530
Author: caoxuewen 
Date:   2018-11-15T11:00:39Z

remove invalid comment as we don't use it anymore




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org