[GitHub] spark pull request #23172: [SPARK-25957][followup] Build python docker image...

2018-12-03 Thread vanzin 
Github user vanzin closed the pull request at:

https://github.com/apache/spark/pull/23172


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23172: [SPARK-25957][followup] Build python docker image...

2018-11-28 Thread vanzin 
Github user vanzin commented on a diff in the pull request:

https://github.com/apache/spark/pull/23172#discussion_r237276972
  
--- Diff: project/SparkBuild.scala ---
@@ -494,7 +494,12 @@ object KubernetesIntegrationTests {
 dockerBuild := {
   if (shouldBuildImage) {
 val dockerTool = s"$sparkHome/bin/docker-image-tool.sh"
-val cmd = Seq(dockerTool, "-m", "-t", imageTag.value, "build")
+val bindingsDir = 
s"$sparkHome/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings"
+val cmd = Seq(dockerTool, "-m",
+  "-t", imageTag.value,
+  "-p", s"$bindingsDir/python/Dockerfile",
--- End diff --

Not yet (ITs for R are not run). But shouldn't hurt either.


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23172: [SPARK-25957][followup] Build python docker image...

2018-11-28 Thread ramaddepally 
Github user ramaddepally commented on a diff in the pull request:

https://github.com/apache/spark/pull/23172#discussion_r237272661
  
--- Diff: project/SparkBuild.scala ---
@@ -494,7 +494,12 @@ object KubernetesIntegrationTests {
 dockerBuild := {
   if (shouldBuildImage) {
 val dockerTool = s"$sparkHome/bin/docker-image-tool.sh"
-val cmd = Seq(dockerTool, "-m", "-t", imageTag.value, "build")
+val bindingsDir = 
s"$sparkHome/resource-managers/kubernetes/docker/src/main/dockerfiles/spark/bindings"
+val cmd = Seq(dockerTool, "-m",
+  "-t", imageTag.value,
+  "-p", s"$bindingsDir/python/Dockerfile",
--- End diff --

Don't we need to build SparkR image here? 


---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #23172: [SPARK-25957][followup] Build python docker image...

2018-11-28 Thread vanzin 
GitHub user vanzin opened a pull request:

https://github.com/apache/spark/pull/23172

[SPARK-25957][followup] Build python docker image in sbt build too.

docker-image-tool.sh requires explicit argument to create the python
image now; do that from the sbt integration tests target too.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vanzin/spark SPARK-25957.followup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/spark/pull/23172.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #23172


commit cac4e92cbf07f5ccf27fdd98f28dcc6e47f03e95
Author: Marcelo Vanzin 
Date:   2018-11-28T19:23:32Z

[SPARK-25957][followup] Build python docker image in sbt build too.

docker-image-tool.sh requires explicit argument to create the python
image now; do that from the sbt integration tests target too.




---

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org