[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/9518 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r124883764
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.io.IOException
+import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.SortedMap
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+import scala.util.{Failure, Success, Try}
+
+import com.codahale.metrics._
+import org.apache.hadoop.net.NetUtils
+
+import org.apache.spark.internal.Logging
+
+/**
+ * @see https://github.com/etsy/statsd/blob/master/docs/metric_types.md";>
+ *StatsD metric types
+ */
+private[spark] object StatsdMetricType {
+ val COUNTER = "c"
+ val GAUGE = "g"
+ val TIMER = "ms"
+ val Set = "s"
+}
+
+private[spark] class StatsdReporter(
+registry: MetricRegistry,
+host: String = "127.0.0.1",
+port: Int = 8125,
+prefix: String = "",
+filter: MetricFilter = MetricFilter.ALL,
+rateUnit: TimeUnit = TimeUnit.SECONDS,
+durationUnit: TimeUnit = TimeUnit.MILLISECONDS)
+ extends ScheduledReporter(registry, "statsd-reporter", filter, rateUnit,
durationUnit)
+ with Logging {
+
+ import StatsdMetricType._
+
+ private val address = new InetSocketAddress(host, port)
+ private val whitespace = "[\\s]+".r
+
+ override def report(
+ gauges: SortedMap[String, Gauge[_]],
+ counters: SortedMap[String, Counter],
+ histograms: SortedMap[String, Histogram],
+ meters: SortedMap[String, Meter],
+ timers: SortedMap[String, Timer]): Unit =
+Try(new DatagramSocket) match {
+ case Failure(ioe: IOException) => logWarning("StatsD datagram socket
construction failed",
+NetUtils.wrapException(host, port, NetUtils.getHostname(), 0, ioe))
+ case Failure(e) => logWarning("StatsD datagram socket construction
failed", e)
+ case Success(s) =>
+implicit val socket = s
+val localAddress =
Try(socket.getLocalAddress).map(_.getHostAddress).getOrElse(null)
+val localPort = socket.getLocalPort
+Try {
+ gauges.entrySet.asScala.foreach(e => reportGauge(e.getKey,
e.getValue))
+ counters.entrySet.asScala.foreach(e => reportCounter(e.getKey,
e.getValue))
+ histograms.entrySet.asScala.foreach(e =>
reportHistogram(e.getKey, e.getValue))
+ meters.entrySet.asScala.foreach(e => reportMetered(e.getKey,
e.getValue))
+ timers.entrySet.asScala.foreach(e => reportTimer(e.getKey,
e.getValue))
+} recover {
+ case ioe: IOException =>
+logDebug(s"Unable to send packets to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug(s"Unable to send packets to StatsD
at '$host:$port'", e)
+}
+Try(socket.close()) recover {
+ case ioe: IOException =>
+logDebug("Error when close socket to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug("Error when close socket to
StatsD", e)
+}
+}
+
+ private def reportGauge(name: String, gauge: Gauge[_])(implicit socket:
DatagramSocket) =
+formatAny(gauge.getValue).foreach(v => send(fullName(name), v, GAUGE))
+
+ private def reportCounter(name: String, counter: Counter)(implicit
socket: DatagramSocket) =
+send(fullName(name), format(counter.getCount), COUNTER)
+
+ private def reportHistogram(name: String, histogram: Histogram)
+ (im
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r124883621
--- Diff:
core/src/test/scala/org/apache/spark/metrics/sink/StatsdSinkSuite.scala ---
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.net.{DatagramPacket, DatagramSocket}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.Properties
+import java.util.concurrent.TimeUnit._
+
+import com.codahale.metrics._
+
+import org.apache.spark.{SecurityManager, SparkConf, SparkFunSuite}
+import org.apache.spark.metrics.sink.StatsdSink._
+
+class StatsdSinkSuite extends SparkFunSuite {
+ val securityMgr = new SecurityManager(new SparkConf(false))
+ val defaultProps = Map(
+STATSD_KEY_PREFIX -> "spark",
+STATSD_KEY_PERIOD -> "1",
+STATSD_KEY_UNIT -> "seconds",
+STATSD_KEY_HOST -> "127.0.0.1"
+ )
+ val socketTimeout = 3 // milliseconds
+ val socketBufferSize = 8192
+
+ def withSocketAndSink(testCode: (DatagramSocket, StatsdSink) => Any) {
--- End diff --
Will change the method to private and return type. However if can't change
the test class to private since ScalaTest auto-scanner will skip the test class
if it's private. Besides none of the TestSuite classes in core library is
scoped as private (except the base test class).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r124882926
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.io.IOException
+import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.SortedMap
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+import scala.util.{Failure, Success, Try}
+
+import com.codahale.metrics._
+import org.apache.hadoop.net.NetUtils
+
+import org.apache.spark.internal.Logging
+
+/**
+ * @see https://github.com/etsy/statsd/blob/master/docs/metric_types.md";>
+ *StatsD metric types
+ */
+private[spark] object StatsdMetricType {
+ val COUNTER = "c"
+ val GAUGE = "g"
+ val TIMER = "ms"
+ val Set = "s"
+}
+
+private[spark] class StatsdReporter(
+registry: MetricRegistry,
+host: String = "127.0.0.1",
+port: Int = 8125,
+prefix: String = "",
+filter: MetricFilter = MetricFilter.ALL,
+rateUnit: TimeUnit = TimeUnit.SECONDS,
+durationUnit: TimeUnit = TimeUnit.MILLISECONDS)
+ extends ScheduledReporter(registry, "statsd-reporter", filter, rateUnit,
durationUnit)
+ with Logging {
+
+ import StatsdMetricType._
+
+ private val address = new InetSocketAddress(host, port)
+ private val whitespace = "[\\s]+".r
+
+ override def report(
+ gauges: SortedMap[String, Gauge[_]],
+ counters: SortedMap[String, Counter],
+ histograms: SortedMap[String, Histogram],
+ meters: SortedMap[String, Meter],
+ timers: SortedMap[String, Timer]): Unit =
+Try(new DatagramSocket) match {
+ case Failure(ioe: IOException) => logWarning("StatsD datagram socket
construction failed",
+NetUtils.wrapException(host, port, NetUtils.getHostname(), 0, ioe))
+ case Failure(e) => logWarning("StatsD datagram socket construction
failed", e)
+ case Success(s) =>
+implicit val socket = s
+val localAddress =
Try(socket.getLocalAddress).map(_.getHostAddress).getOrElse(null)
+val localPort = socket.getLocalPort
+Try {
+ gauges.entrySet.asScala.foreach(e => reportGauge(e.getKey,
e.getValue))
+ counters.entrySet.asScala.foreach(e => reportCounter(e.getKey,
e.getValue))
+ histograms.entrySet.asScala.foreach(e =>
reportHistogram(e.getKey, e.getValue))
+ meters.entrySet.asScala.foreach(e => reportMetered(e.getKey,
e.getValue))
+ timers.entrySet.asScala.foreach(e => reportTimer(e.getKey,
e.getValue))
+} recover {
+ case ioe: IOException =>
+logDebug(s"Unable to send packets to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug(s"Unable to send packets to StatsD
at '$host:$port'", e)
+}
+Try(socket.close()) recover {
+ case ioe: IOException =>
+logDebug("Error when close socket to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug("Error when close socket to
StatsD", e)
+}
+}
+
+ private def reportGauge(name: String, gauge: Gauge[_])(implicit socket:
DatagramSocket) =
--- End diff --
Will add return type to all repot*() methods.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastru
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r124689398
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.io.IOException
+import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.SortedMap
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+import scala.util.{Failure, Success, Try}
+
+import com.codahale.metrics._
+import org.apache.hadoop.net.NetUtils
+
+import org.apache.spark.internal.Logging
+
+/**
+ * @see https://github.com/etsy/statsd/blob/master/docs/metric_types.md";>
+ *StatsD metric types
+ */
+private[spark] object StatsdMetricType {
+ val COUNTER = "c"
+ val GAUGE = "g"
+ val TIMER = "ms"
+ val Set = "s"
+}
+
+private[spark] class StatsdReporter(
+registry: MetricRegistry,
+host: String = "127.0.0.1",
+port: Int = 8125,
+prefix: String = "",
+filter: MetricFilter = MetricFilter.ALL,
+rateUnit: TimeUnit = TimeUnit.SECONDS,
+durationUnit: TimeUnit = TimeUnit.MILLISECONDS)
+ extends ScheduledReporter(registry, "statsd-reporter", filter, rateUnit,
durationUnit)
+ with Logging {
+
+ import StatsdMetricType._
+
+ private val address = new InetSocketAddress(host, port)
+ private val whitespace = "[\\s]+".r
+
+ override def report(
+ gauges: SortedMap[String, Gauge[_]],
+ counters: SortedMap[String, Counter],
+ histograms: SortedMap[String, Histogram],
+ meters: SortedMap[String, Meter],
+ timers: SortedMap[String, Timer]): Unit =
+Try(new DatagramSocket) match {
+ case Failure(ioe: IOException) => logWarning("StatsD datagram socket
construction failed",
+NetUtils.wrapException(host, port, NetUtils.getHostname(), 0, ioe))
+ case Failure(e) => logWarning("StatsD datagram socket construction
failed", e)
+ case Success(s) =>
+implicit val socket = s
+val localAddress =
Try(socket.getLocalAddress).map(_.getHostAddress).getOrElse(null)
+val localPort = socket.getLocalPort
+Try {
+ gauges.entrySet.asScala.foreach(e => reportGauge(e.getKey,
e.getValue))
+ counters.entrySet.asScala.foreach(e => reportCounter(e.getKey,
e.getValue))
+ histograms.entrySet.asScala.foreach(e =>
reportHistogram(e.getKey, e.getValue))
+ meters.entrySet.asScala.foreach(e => reportMetered(e.getKey,
e.getValue))
+ timers.entrySet.asScala.foreach(e => reportTimer(e.getKey,
e.getValue))
+} recover {
+ case ioe: IOException =>
+logDebug(s"Unable to send packets to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug(s"Unable to send packets to StatsD
at '$host:$port'", e)
+}
+Try(socket.close()) recover {
+ case ioe: IOException =>
+logDebug("Error when close socket to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug("Error when close socket to
StatsD", e)
+}
+}
+
+ private def reportGauge(name: String, gauge: Gauge[_])(implicit socket:
DatagramSocket) =
--- End diff --
Can you please add return type to the method here and below?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastr
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r124699178
--- Diff:
core/src/test/scala/org/apache/spark/metrics/sink/StatsdSinkSuite.scala ---
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.net.{DatagramPacket, DatagramSocket}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.Properties
+import java.util.concurrent.TimeUnit._
+
+import com.codahale.metrics._
+
+import org.apache.spark.{SecurityManager, SparkConf, SparkFunSuite}
+import org.apache.spark.metrics.sink.StatsdSink._
+
+class StatsdSinkSuite extends SparkFunSuite {
+ val securityMgr = new SecurityManager(new SparkConf(false))
+ val defaultProps = Map(
+STATSD_KEY_PREFIX -> "spark",
+STATSD_KEY_PERIOD -> "1",
+STATSD_KEY_UNIT -> "seconds",
+STATSD_KEY_HOST -> "127.0.0.1"
+ )
+ val socketTimeout = 3 // milliseconds
+ val socketBufferSize = 8192
+
+ def withSocketAndSink(testCode: (DatagramSocket, StatsdSink) => Any) {
--- End diff --
Can we change the scope to `private` for the method and above class
members, looks like it is not necessary to expose.
Also please add the return type to this method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r124689716
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,167 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.io.IOException
+import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.SortedMap
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+import scala.util.{Failure, Success, Try}
+
+import com.codahale.metrics._
+import org.apache.hadoop.net.NetUtils
+
+import org.apache.spark.internal.Logging
+
+/**
+ * @see https://github.com/etsy/statsd/blob/master/docs/metric_types.md";>
+ *StatsD metric types
+ */
+private[spark] object StatsdMetricType {
+ val COUNTER = "c"
+ val GAUGE = "g"
+ val TIMER = "ms"
+ val Set = "s"
+}
+
+private[spark] class StatsdReporter(
+registry: MetricRegistry,
+host: String = "127.0.0.1",
+port: Int = 8125,
+prefix: String = "",
+filter: MetricFilter = MetricFilter.ALL,
+rateUnit: TimeUnit = TimeUnit.SECONDS,
+durationUnit: TimeUnit = TimeUnit.MILLISECONDS)
+ extends ScheduledReporter(registry, "statsd-reporter", filter, rateUnit,
durationUnit)
+ with Logging {
+
+ import StatsdMetricType._
+
+ private val address = new InetSocketAddress(host, port)
+ private val whitespace = "[\\s]+".r
+
+ override def report(
+ gauges: SortedMap[String, Gauge[_]],
+ counters: SortedMap[String, Counter],
+ histograms: SortedMap[String, Histogram],
+ meters: SortedMap[String, Meter],
+ timers: SortedMap[String, Timer]): Unit =
+Try(new DatagramSocket) match {
+ case Failure(ioe: IOException) => logWarning("StatsD datagram socket
construction failed",
+NetUtils.wrapException(host, port, NetUtils.getHostname(), 0, ioe))
+ case Failure(e) => logWarning("StatsD datagram socket construction
failed", e)
+ case Success(s) =>
+implicit val socket = s
+val localAddress =
Try(socket.getLocalAddress).map(_.getHostAddress).getOrElse(null)
+val localPort = socket.getLocalPort
+Try {
+ gauges.entrySet.asScala.foreach(e => reportGauge(e.getKey,
e.getValue))
+ counters.entrySet.asScala.foreach(e => reportCounter(e.getKey,
e.getValue))
+ histograms.entrySet.asScala.foreach(e =>
reportHistogram(e.getKey, e.getValue))
+ meters.entrySet.asScala.foreach(e => reportMetered(e.getKey,
e.getValue))
+ timers.entrySet.asScala.foreach(e => reportTimer(e.getKey,
e.getValue))
+} recover {
+ case ioe: IOException =>
+logDebug(s"Unable to send packets to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug(s"Unable to send packets to StatsD
at '$host:$port'", e)
+}
+Try(socket.close()) recover {
+ case ioe: IOException =>
+logDebug("Error when close socket to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug("Error when close socket to
StatsD", e)
+}
+}
+
+ private def reportGauge(name: String, gauge: Gauge[_])(implicit socket:
DatagramSocket) =
+formatAny(gauge.getValue).foreach(v => send(fullName(name), v, GAUGE))
+
+ private def reportCounter(name: String, counter: Counter)(implicit
socket: DatagramSocket) =
+send(fullName(name), format(counter.getCount), COUNTER)
+
+ private def reportHistogram(name: String, histogram: Histogram)
+
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123857033
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.io.IOException
+import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.SortedMap
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+import scala.util.{Failure, Success, Try}
+
+import com.codahale.metrics._
+import org.apache.hadoop.net.NetUtils
+
+import org.apache.spark.Logging
+
+/**
+ * @see https://github.com/etsy/statsd/blob/master/docs/metric_types.md";>
+ *StatsD metric types
+ */
+private[spark] sealed trait StatsdMetricType {
+ val COUNTER = "c"
+ val GAUGE = "g"
+ val TIMER = "ms"
+ val Set = "s"
+}
+
+private[spark] class StatsdReporter(
+registry: MetricRegistry,
+host: String = "127.0.0.1",
+port: Int = 8125,
+prefix: String = "",
+filter: MetricFilter = MetricFilter.ALL,
+rateUnit: TimeUnit = TimeUnit.SECONDS,
+durationUnit: TimeUnit = TimeUnit.MILLISECONDS)
+ extends ScheduledReporter(registry, "statsd-reporter", filter, rateUnit,
durationUnit)
+ with StatsdMetricType with Logging {
+
+ private val address = new InetSocketAddress(host, port)
+ private val whitespace = "[\\s]+".r
+
+ override def report(
+ gauges: SortedMap[String, Gauge[_]],
+ counters: SortedMap[String, Counter],
+ histograms: SortedMap[String, Histogram],
+ meters: SortedMap[String, Meter],
+ timers: SortedMap[String, Timer]): Unit =
+Try(new DatagramSocket) match {
+ case Failure(ioe: IOException) => logWarning("StatsD datagram socket
construction failed",
+NetUtils.wrapException(host, port, "0.0.0.0", 0, ioe))
+ case Failure(e) => logWarning("StatsD datagram socket construction
failed", e)
+ case Success(s) =>
+implicit val socket = s
+val localAddress =
Try(socket.getLocalAddress).map(_.getHostAddress).getOrElse(null)
+val localPort = socket.getLocalPort
+Try {
+ gauges.entrySet.asScala.foreach(e => reportGauge(e.getKey,
e.getValue))
+ counters.entrySet.asScala.foreach(e => reportCounter(e.getKey,
e.getValue))
+ histograms.entrySet.asScala.foreach(e =>
reportHistogram(e.getKey, e.getValue))
+ meters.entrySet.asScala.foreach(e => reportMetered(e.getKey,
e.getValue))
+ timers.entrySet.asScala.foreach(e => reportTimer(e.getKey,
e.getValue))
+} recover {
+ case ioe: IOException =>
+logDebug(s"Unable to send packets to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug(s"Unable to send packets to StatsD
at '$host:$port'", e)
+}
+Try(socket.close()) recover {
+ case ioe: IOException =>
+logDebug("Error when close socket to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug("Error when close socket to
StatsD", e)
+}
+}
+
+ private def reportGauge(name: String, gauge: Gauge[_])(implicit socket:
DatagramSocket) =
+formatAny(gauge.getValue).foreach(v => send(fullName(name), v, GAUGE))
+
+ private def reportCounter(name: String, counter: Counter)(implicit
socket: DatagramSocket) =
+send(fullName(name), format(counter.getCount), COUNTER)
+
+ private def reportHistogram(name: String, histogram: Histogram)
+ (implicit soc
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123856611
--- Diff:
core/src/test/scala/org/apache/spark/metrics/sink/StatsdSinkSuite.scala ---
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.net.{DatagramPacket, DatagramSocket}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.Properties
+import java.util.concurrent.TimeUnit._
+
+import com.codahale.metrics._
+
+import org.apache.spark.{SecurityManager, SparkConf, SparkFunSuite}
+import org.apache.spark.metrics.sink.StatsdSink._
+
+class StatsdSinkSuite extends SparkFunSuite {
+ val securityMgr = new SecurityManager(new SparkConf(false))
+ val defaultProps = Map(
+STATSD_KEY_PREFIX -> "spark",
+STATSD_KEY_PERIOD -> "1",
+STATSD_KEY_UNIT -> "seconds",
+STATSD_KEY_HOST -> "127.0.0.1"
+ )
+ val socketTimeout = 3000 // milliseconds
+ val socketBufferSize = 1024
+
+ def makeFixture(): (DatagramSocket, StatsdSink) = {
+val socket = new DatagramSocket
+socket.setReceiveBufferSize(socketBufferSize)
+socket.setSoTimeout(socketTimeout)
+val props = new Properties
+defaultProps.foreach(e => props.put(e._1, e._2))
+props.put(STATSD_KEY_PORT, socket.getLocalPort.toString)
+val registry = new MetricRegistry
+val sink = new StatsdSink(props, registry, securityMgr)
+(socket, sink)
+ }
+
+ test("metrics StatsD sink with Counter") {
+val (socket, sink) = makeFixture()
+try {
+ val counter = new Counter
+ counter.inc(12)
+ sink.registry.register("counter", counter)
+ sink.report()
+
+ val p = new DatagramPacket(new Array[Byte](socketBufferSize),
socketBufferSize)
+ socket.receive(p)
+
+ val result = new String(p.getData, 0, p.getLength, UTF_8)
+ assert(result === "spark.counter:12|c", "Counter metric received
should match data sent")
+} finally socket.close()
--- End diff --
See above response.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123856570
--- Diff:
core/src/test/scala/org/apache/spark/metrics/sink/StatsdSinkSuite.scala ---
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.net.{DatagramPacket, DatagramSocket}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.Properties
+import java.util.concurrent.TimeUnit._
+
+import com.codahale.metrics._
+
+import org.apache.spark.{SecurityManager, SparkConf, SparkFunSuite}
+import org.apache.spark.metrics.sink.StatsdSink._
+
+class StatsdSinkSuite extends SparkFunSuite {
+ val securityMgr = new SecurityManager(new SparkConf(false))
+ val defaultProps = Map(
+STATSD_KEY_PREFIX -> "spark",
+STATSD_KEY_PERIOD -> "1",
+STATSD_KEY_UNIT -> "seconds",
+STATSD_KEY_HOST -> "127.0.0.1"
+ )
+ val socketTimeout = 3000 // milliseconds
+ val socketBufferSize = 1024
+
+ def makeFixture(): (DatagramSocket, StatsdSink) = {
--- End diff --
Since I'd like the fixtures (socket and sink) to be different for each test
to avoid concurrency issues, before/after doesn't look like a fit. I can
instead leverage [load fixture
methods](http://www.scalatest.org/user_guide/sharing_fixtures#loanFixtureMethods)
to reduce the duplicated calls to `makeFixture` and `socket.close()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123657729
--- Diff:
core/src/test/scala/org/apache/spark/metrics/sink/StatsdSinkSuite.scala ---
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.net.{DatagramPacket, DatagramSocket}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.Properties
+import java.util.concurrent.TimeUnit._
+
+import com.codahale.metrics._
+
+import org.apache.spark.{SecurityManager, SparkConf, SparkFunSuite}
+import org.apache.spark.metrics.sink.StatsdSink._
+
+class StatsdSinkSuite extends SparkFunSuite {
+ val securityMgr = new SecurityManager(new SparkConf(false))
+ val defaultProps = Map(
+STATSD_KEY_PREFIX -> "spark",
+STATSD_KEY_PERIOD -> "1",
+STATSD_KEY_UNIT -> "seconds",
+STATSD_KEY_HOST -> "127.0.0.1"
+ )
+ val socketTimeout = 3000 // milliseconds
+ val socketBufferSize = 1024
+
+ def makeFixture(): (DatagramSocket, StatsdSink) = {
+val socket = new DatagramSocket
+socket.setReceiveBufferSize(socketBufferSize)
+socket.setSoTimeout(socketTimeout)
+val props = new Properties
+defaultProps.foreach(e => props.put(e._1, e._2))
+props.put(STATSD_KEY_PORT, socket.getLocalPort.toString)
+val registry = new MetricRegistry
+val sink = new StatsdSink(props, registry, securityMgr)
+(socket, sink)
+ }
+
+ test("metrics StatsD sink with Counter") {
+val (socket, sink) = makeFixture()
+try {
+ val counter = new Counter
+ counter.inc(12)
+ sink.registry.register("counter", counter)
+ sink.report()
+
+ val p = new DatagramPacket(new Array[Byte](socketBufferSize),
socketBufferSize)
+ socket.receive(p)
+
+ val result = new String(p.getData, 0, p.getLength, UTF_8)
+ assert(result === "spark.counter:12|c", "Counter metric received
should match data sent")
+} finally socket.close()
--- End diff --
And this could move to `after()`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123657675
--- Diff:
core/src/test/scala/org/apache/spark/metrics/sink/StatsdSinkSuite.scala ---
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.net.{DatagramPacket, DatagramSocket}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.Properties
+import java.util.concurrent.TimeUnit._
+
+import com.codahale.metrics._
+
+import org.apache.spark.{SecurityManager, SparkConf, SparkFunSuite}
+import org.apache.spark.metrics.sink.StatsdSink._
+
+class StatsdSinkSuite extends SparkFunSuite {
+ val securityMgr = new SecurityManager(new SparkConf(false))
+ val defaultProps = Map(
+STATSD_KEY_PREFIX -> "spark",
+STATSD_KEY_PERIOD -> "1",
+STATSD_KEY_UNIT -> "seconds",
+STATSD_KEY_HOST -> "127.0.0.1"
+ )
+ val socketTimeout = 3000 // milliseconds
+ val socketBufferSize = 1024
+
+ def makeFixture(): (DatagramSocket, StatsdSink) = {
--- End diff --
I think we could move this to `org.scalatest.BeforeAndAfter.before`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123656934
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.io.IOException
+import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.SortedMap
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+import scala.util.{Failure, Success, Try}
+
+import com.codahale.metrics._
+import org.apache.hadoop.net.NetUtils
+
+import org.apache.spark.Logging
+
+/**
+ * @see https://github.com/etsy/statsd/blob/master/docs/metric_types.md";>
+ *StatsD metric types
+ */
+private[spark] sealed trait StatsdMetricType {
+ val COUNTER = "c"
+ val GAUGE = "g"
+ val TIMER = "ms"
+ val Set = "s"
+}
+
+private[spark] class StatsdReporter(
+registry: MetricRegistry,
+host: String = "127.0.0.1",
+port: Int = 8125,
+prefix: String = "",
+filter: MetricFilter = MetricFilter.ALL,
+rateUnit: TimeUnit = TimeUnit.SECONDS,
+durationUnit: TimeUnit = TimeUnit.MILLISECONDS)
+ extends ScheduledReporter(registry, "statsd-reporter", filter, rateUnit,
durationUnit)
+ with StatsdMetricType with Logging {
+
+ private val address = new InetSocketAddress(host, port)
+ private val whitespace = "[\\s]+".r
+
+ override def report(
+ gauges: SortedMap[String, Gauge[_]],
+ counters: SortedMap[String, Counter],
+ histograms: SortedMap[String, Histogram],
+ meters: SortedMap[String, Meter],
+ timers: SortedMap[String, Timer]): Unit =
+Try(new DatagramSocket) match {
+ case Failure(ioe: IOException) => logWarning("StatsD datagram socket
construction failed",
+NetUtils.wrapException(host, port, "0.0.0.0", 0, ioe))
+ case Failure(e) => logWarning("StatsD datagram socket construction
failed", e)
+ case Success(s) =>
+implicit val socket = s
+val localAddress =
Try(socket.getLocalAddress).map(_.getHostAddress).getOrElse(null)
+val localPort = socket.getLocalPort
+Try {
+ gauges.entrySet.asScala.foreach(e => reportGauge(e.getKey,
e.getValue))
+ counters.entrySet.asScala.foreach(e => reportCounter(e.getKey,
e.getValue))
+ histograms.entrySet.asScala.foreach(e =>
reportHistogram(e.getKey, e.getValue))
+ meters.entrySet.asScala.foreach(e => reportMetered(e.getKey,
e.getValue))
+ timers.entrySet.asScala.foreach(e => reportTimer(e.getKey,
e.getValue))
+} recover {
+ case ioe: IOException =>
+logDebug(s"Unable to send packets to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug(s"Unable to send packets to StatsD
at '$host:$port'", e)
+}
+Try(socket.close()) recover {
+ case ioe: IOException =>
+logDebug("Error when close socket to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug("Error when close socket to
StatsD", e)
+}
+}
+
+ private def reportGauge(name: String, gauge: Gauge[_])(implicit socket:
DatagramSocket) =
+formatAny(gauge.getValue).foreach(v => send(fullName(name), v, GAUGE))
+
+ private def reportCounter(name: String, counter: Counter)(implicit
socket: DatagramSocket) =
+send(fullName(name), format(counter.getCount), COUNTER)
+
+ private def reportHistogram(name: String, histogram: Histogram)
+ (implicit
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123628448
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.io.IOException
+import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.SortedMap
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+import scala.util.{Failure, Success, Try}
+
+import com.codahale.metrics._
+import org.apache.hadoop.net.NetUtils
+
+import org.apache.spark.Logging
+
+/**
+ * @see https://github.com/etsy/statsd/blob/master/docs/metric_types.md";>
+ *StatsD metric types
+ */
+private[spark] sealed trait StatsdMetricType {
--- End diff --
Will change to `object`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123628327
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.io.IOException
+import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.SortedMap
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+import scala.util.{Failure, Success, Try}
+
+import com.codahale.metrics._
+import org.apache.hadoop.net.NetUtils
+
+import org.apache.spark.Logging
+
+/**
+ * @see https://github.com/etsy/statsd/blob/master/docs/metric_types.md";>
+ *StatsD metric types
+ */
+private[spark] sealed trait StatsdMetricType {
+ val COUNTER = "c"
+ val GAUGE = "g"
+ val TIMER = "ms"
+ val Set = "s"
+}
+
+private[spark] class StatsdReporter(
+registry: MetricRegistry,
+host: String = "127.0.0.1",
+port: Int = 8125,
+prefix: String = "",
+filter: MetricFilter = MetricFilter.ALL,
+rateUnit: TimeUnit = TimeUnit.SECONDS,
+durationUnit: TimeUnit = TimeUnit.MILLISECONDS)
+ extends ScheduledReporter(registry, "statsd-reporter", filter, rateUnit,
durationUnit)
+ with StatsdMetricType with Logging {
+
+ private val address = new InetSocketAddress(host, port)
+ private val whitespace = "[\\s]+".r
+
+ override def report(
+ gauges: SortedMap[String, Gauge[_]],
+ counters: SortedMap[String, Counter],
+ histograms: SortedMap[String, Histogram],
+ meters: SortedMap[String, Meter],
+ timers: SortedMap[String, Timer]): Unit =
+Try(new DatagramSocket) match {
+ case Failure(ioe: IOException) => logWarning("StatsD datagram socket
construction failed",
+NetUtils.wrapException(host, port, "0.0.0.0", 0, ioe))
+ case Failure(e) => logWarning("StatsD datagram socket construction
failed", e)
+ case Success(s) =>
+implicit val socket = s
+val localAddress =
Try(socket.getLocalAddress).map(_.getHostAddress).getOrElse(null)
+val localPort = socket.getLocalPort
+Try {
+ gauges.entrySet.asScala.foreach(e => reportGauge(e.getKey,
e.getValue))
+ counters.entrySet.asScala.foreach(e => reportCounter(e.getKey,
e.getValue))
+ histograms.entrySet.asScala.foreach(e =>
reportHistogram(e.getKey, e.getValue))
+ meters.entrySet.asScala.foreach(e => reportMetered(e.getKey,
e.getValue))
+ timers.entrySet.asScala.foreach(e => reportTimer(e.getKey,
e.getValue))
+} recover {
+ case ioe: IOException =>
+logDebug(s"Unable to send packets to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug(s"Unable to send packets to StatsD
at '$host:$port'", e)
+}
+Try(socket.close()) recover {
+ case ioe: IOException =>
+logDebug("Error when close socket to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug("Error when close socket to
StatsD", e)
+}
+}
+
+ private def reportGauge(name: String, gauge: Gauge[_])(implicit socket:
DatagramSocket) =
+formatAny(gauge.getValue).foreach(v => send(fullName(name), v, GAUGE))
+
+ private def reportCounter(name: String, counter: Counter)(implicit
socket: DatagramSocket) =
+send(fullName(name), format(counter.getCount), COUNTER)
+
+ private def reportHistogram(name: String, histogram: Histogram)
+ (implicit soc
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123628385
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.io.IOException
+import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.SortedMap
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+import scala.util.{Failure, Success, Try}
+
+import com.codahale.metrics._
+import org.apache.hadoop.net.NetUtils
+
+import org.apache.spark.Logging
+
+/**
+ * @see https://github.com/etsy/statsd/blob/master/docs/metric_types.md";>
+ *StatsD metric types
+ */
+private[spark] sealed trait StatsdMetricType {
+ val COUNTER = "c"
+ val GAUGE = "g"
+ val TIMER = "ms"
+ val Set = "s"
+}
+
+private[spark] class StatsdReporter(
+registry: MetricRegistry,
+host: String = "127.0.0.1",
+port: Int = 8125,
+prefix: String = "",
+filter: MetricFilter = MetricFilter.ALL,
+rateUnit: TimeUnit = TimeUnit.SECONDS,
+durationUnit: TimeUnit = TimeUnit.MILLISECONDS)
+ extends ScheduledReporter(registry, "statsd-reporter", filter, rateUnit,
durationUnit)
+ with StatsdMetricType with Logging {
+
+ private val address = new InetSocketAddress(host, port)
+ private val whitespace = "[\\s]+".r
+
+ override def report(
+ gauges: SortedMap[String, Gauge[_]],
+ counters: SortedMap[String, Counter],
+ histograms: SortedMap[String, Histogram],
+ meters: SortedMap[String, Meter],
+ timers: SortedMap[String, Timer]): Unit =
+Try(new DatagramSocket) match {
+ case Failure(ioe: IOException) => logWarning("StatsD datagram socket
construction failed",
+NetUtils.wrapException(host, port, "0.0.0.0", 0, ioe))
+ case Failure(e) => logWarning("StatsD datagram socket construction
failed", e)
+ case Success(s) =>
+implicit val socket = s
+val localAddress =
Try(socket.getLocalAddress).map(_.getHostAddress).getOrElse(null)
+val localPort = socket.getLocalPort
+Try {
+ gauges.entrySet.asScala.foreach(e => reportGauge(e.getKey,
e.getValue))
+ counters.entrySet.asScala.foreach(e => reportCounter(e.getKey,
e.getValue))
+ histograms.entrySet.asScala.foreach(e =>
reportHistogram(e.getKey, e.getValue))
+ meters.entrySet.asScala.foreach(e => reportMetered(e.getKey,
e.getValue))
+ timers.entrySet.asScala.foreach(e => reportTimer(e.getKey,
e.getValue))
+} recover {
+ case ioe: IOException =>
+logDebug(s"Unable to send packets to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug(s"Unable to send packets to StatsD
at '$host:$port'", e)
+}
+Try(socket.close()) recover {
+ case ioe: IOException =>
+logDebug("Error when close socket to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug("Error when close socket to
StatsD", e)
+}
+}
+
+ private def reportGauge(name: String, gauge: Gauge[_])(implicit socket:
DatagramSocket) =
+formatAny(gauge.getValue).foreach(v => send(fullName(name), v, GAUGE))
+
+ private def reportCounter(name: String, counter: Counter)(implicit
socket: DatagramSocket) =
+send(fullName(name), format(counter.getCount), COUNTER)
+
+ private def reportHistogram(name: String, histogram: Histogram)
+ (implicit soc
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user xflin commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123627980
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.io.IOException
+import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.SortedMap
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+import scala.util.{Failure, Success, Try}
+
+import com.codahale.metrics._
+import org.apache.hadoop.net.NetUtils
+
+import org.apache.spark.Logging
+
+/**
+ * @see https://github.com/etsy/statsd/blob/master/docs/metric_types.md";>
+ *StatsD metric types
+ */
+private[spark] sealed trait StatsdMetricType {
+ val COUNTER = "c"
+ val GAUGE = "g"
+ val TIMER = "ms"
+ val Set = "s"
+}
+
+private[spark] class StatsdReporter(
+registry: MetricRegistry,
+host: String = "127.0.0.1",
+port: Int = 8125,
+prefix: String = "",
+filter: MetricFilter = MetricFilter.ALL,
+rateUnit: TimeUnit = TimeUnit.SECONDS,
+durationUnit: TimeUnit = TimeUnit.MILLISECONDS)
+ extends ScheduledReporter(registry, "statsd-reporter", filter, rateUnit,
durationUnit)
+ with StatsdMetricType with Logging {
+
+ private val address = new InetSocketAddress(host, port)
+ private val whitespace = "[\\s]+".r
+
+ override def report(
+ gauges: SortedMap[String, Gauge[_]],
+ counters: SortedMap[String, Counter],
+ histograms: SortedMap[String, Histogram],
+ meters: SortedMap[String, Meter],
+ timers: SortedMap[String, Timer]): Unit =
+Try(new DatagramSocket) match {
+ case Failure(ioe: IOException) => logWarning("StatsD datagram socket
construction failed",
+NetUtils.wrapException(host, port, "0.0.0.0", 0, ioe))
--- End diff --
Here the`host` value usually comes from configuration file. Further, a
remote host could be a valid value too. I think it's preferable to honestly
report the exact value is being used in the exception.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123483576
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.io.IOException
+import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.SortedMap
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+import scala.util.{Failure, Success, Try}
+
+import com.codahale.metrics._
+import org.apache.hadoop.net.NetUtils
+
+import org.apache.spark.Logging
+
+/**
+ * @see https://github.com/etsy/statsd/blob/master/docs/metric_types.md";>
+ *StatsD metric types
+ */
+private[spark] sealed trait StatsdMetricType {
+ val COUNTER = "c"
+ val GAUGE = "g"
+ val TIMER = "ms"
+ val Set = "s"
+}
+
+private[spark] class StatsdReporter(
+registry: MetricRegistry,
+host: String = "127.0.0.1",
+port: Int = 8125,
+prefix: String = "",
+filter: MetricFilter = MetricFilter.ALL,
+rateUnit: TimeUnit = TimeUnit.SECONDS,
+durationUnit: TimeUnit = TimeUnit.MILLISECONDS)
+ extends ScheduledReporter(registry, "statsd-reporter", filter, rateUnit,
durationUnit)
+ with StatsdMetricType with Logging {
+
+ private val address = new InetSocketAddress(host, port)
+ private val whitespace = "[\\s]+".r
+
+ override def report(
+ gauges: SortedMap[String, Gauge[_]],
+ counters: SortedMap[String, Counter],
+ histograms: SortedMap[String, Histogram],
+ meters: SortedMap[String, Meter],
+ timers: SortedMap[String, Timer]): Unit =
+Try(new DatagramSocket) match {
+ case Failure(ioe: IOException) => logWarning("StatsD datagram socket
construction failed",
+NetUtils.wrapException(host, port, "0.0.0.0", 0, ioe))
--- End diff --
Preferable to use {{NetUtils.getLocalHostname()}} for the source address,
you'll appreciate it on large cluster diagnostics.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123420182
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.io.IOException
+import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.SortedMap
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+import scala.util.{Failure, Success, Try}
+
+import com.codahale.metrics._
+import org.apache.hadoop.net.NetUtils
+
+import org.apache.spark.Logging
+
+/**
+ * @see https://github.com/etsy/statsd/blob/master/docs/metric_types.md";>
+ *StatsD metric types
+ */
+private[spark] sealed trait StatsdMetricType {
--- End diff --
This trait looks only used for defining some values, may be we could use
`object StatsdReporter` instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123425292
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.io.IOException
+import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.SortedMap
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+import scala.util.{Failure, Success, Try}
+
+import com.codahale.metrics._
+import org.apache.hadoop.net.NetUtils
+
+import org.apache.spark.Logging
+
+/**
+ * @see https://github.com/etsy/statsd/blob/master/docs/metric_types.md";>
+ *StatsD metric types
+ */
+private[spark] sealed trait StatsdMetricType {
+ val COUNTER = "c"
+ val GAUGE = "g"
+ val TIMER = "ms"
+ val Set = "s"
+}
+
+private[spark] class StatsdReporter(
+registry: MetricRegistry,
+host: String = "127.0.0.1",
+port: Int = 8125,
+prefix: String = "",
+filter: MetricFilter = MetricFilter.ALL,
+rateUnit: TimeUnit = TimeUnit.SECONDS,
+durationUnit: TimeUnit = TimeUnit.MILLISECONDS)
+ extends ScheduledReporter(registry, "statsd-reporter", filter, rateUnit,
durationUnit)
+ with StatsdMetricType with Logging {
+
+ private val address = new InetSocketAddress(host, port)
+ private val whitespace = "[\\s]+".r
+
+ override def report(
+ gauges: SortedMap[String, Gauge[_]],
+ counters: SortedMap[String, Counter],
+ histograms: SortedMap[String, Histogram],
+ meters: SortedMap[String, Meter],
+ timers: SortedMap[String, Timer]): Unit =
+Try(new DatagramSocket) match {
+ case Failure(ioe: IOException) => logWarning("StatsD datagram socket
construction failed",
+NetUtils.wrapException(host, port, "0.0.0.0", 0, ioe))
+ case Failure(e) => logWarning("StatsD datagram socket construction
failed", e)
+ case Success(s) =>
+implicit val socket = s
+val localAddress =
Try(socket.getLocalAddress).map(_.getHostAddress).getOrElse(null)
+val localPort = socket.getLocalPort
+Try {
+ gauges.entrySet.asScala.foreach(e => reportGauge(e.getKey,
e.getValue))
+ counters.entrySet.asScala.foreach(e => reportCounter(e.getKey,
e.getValue))
+ histograms.entrySet.asScala.foreach(e =>
reportHistogram(e.getKey, e.getValue))
+ meters.entrySet.asScala.foreach(e => reportMetered(e.getKey,
e.getValue))
+ timers.entrySet.asScala.foreach(e => reportTimer(e.getKey,
e.getValue))
+} recover {
+ case ioe: IOException =>
+logDebug(s"Unable to send packets to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug(s"Unable to send packets to StatsD
at '$host:$port'", e)
+}
+Try(socket.close()) recover {
+ case ioe: IOException =>
+logDebug("Error when close socket to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug("Error when close socket to
StatsD", e)
+}
+}
+
+ private def reportGauge(name: String, gauge: Gauge[_])(implicit socket:
DatagramSocket) =
+formatAny(gauge.getValue).foreach(v => send(fullName(name), v, GAUGE))
+
+ private def reportCounter(name: String, counter: Counter)(implicit
socket: DatagramSocket) =
+send(fullName(name), format(counter.getCount), COUNTER)
+
+ private def reportHistogram(name: String, histogram: Histogram)
+ (implicit
[GitHub] spark pull request #9518: [SPARK-11574][Core] Add metrics StatsD sink
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/9518#discussion_r123424723
--- Diff:
core/src/main/scala/org/apache/spark/metrics/sink/StatsdReporter.scala ---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.metrics.sink
+
+import java.io.IOException
+import java.net.{DatagramPacket, DatagramSocket, InetSocketAddress}
+import java.nio.charset.StandardCharsets.UTF_8
+import java.util.SortedMap
+import java.util.concurrent.TimeUnit
+
+import scala.collection.JavaConverters._
+import scala.util.{Failure, Success, Try}
+
+import com.codahale.metrics._
+import org.apache.hadoop.net.NetUtils
+
+import org.apache.spark.Logging
+
+/**
+ * @see https://github.com/etsy/statsd/blob/master/docs/metric_types.md";>
+ *StatsD metric types
+ */
+private[spark] sealed trait StatsdMetricType {
+ val COUNTER = "c"
+ val GAUGE = "g"
+ val TIMER = "ms"
+ val Set = "s"
+}
+
+private[spark] class StatsdReporter(
+registry: MetricRegistry,
+host: String = "127.0.0.1",
+port: Int = 8125,
+prefix: String = "",
+filter: MetricFilter = MetricFilter.ALL,
+rateUnit: TimeUnit = TimeUnit.SECONDS,
+durationUnit: TimeUnit = TimeUnit.MILLISECONDS)
+ extends ScheduledReporter(registry, "statsd-reporter", filter, rateUnit,
durationUnit)
+ with StatsdMetricType with Logging {
+
+ private val address = new InetSocketAddress(host, port)
+ private val whitespace = "[\\s]+".r
+
+ override def report(
+ gauges: SortedMap[String, Gauge[_]],
+ counters: SortedMap[String, Counter],
+ histograms: SortedMap[String, Histogram],
+ meters: SortedMap[String, Meter],
+ timers: SortedMap[String, Timer]): Unit =
+Try(new DatagramSocket) match {
+ case Failure(ioe: IOException) => logWarning("StatsD datagram socket
construction failed",
+NetUtils.wrapException(host, port, "0.0.0.0", 0, ioe))
+ case Failure(e) => logWarning("StatsD datagram socket construction
failed", e)
+ case Success(s) =>
+implicit val socket = s
+val localAddress =
Try(socket.getLocalAddress).map(_.getHostAddress).getOrElse(null)
+val localPort = socket.getLocalPort
+Try {
+ gauges.entrySet.asScala.foreach(e => reportGauge(e.getKey,
e.getValue))
+ counters.entrySet.asScala.foreach(e => reportCounter(e.getKey,
e.getValue))
+ histograms.entrySet.asScala.foreach(e =>
reportHistogram(e.getKey, e.getValue))
+ meters.entrySet.asScala.foreach(e => reportMetered(e.getKey,
e.getValue))
+ timers.entrySet.asScala.foreach(e => reportTimer(e.getKey,
e.getValue))
+} recover {
+ case ioe: IOException =>
+logDebug(s"Unable to send packets to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug(s"Unable to send packets to StatsD
at '$host:$port'", e)
+}
+Try(socket.close()) recover {
+ case ioe: IOException =>
+logDebug("Error when close socket to StatsD",
NetUtils.wrapException(
+ address.getHostString, address.getPort, localAddress,
localPort, ioe))
+ case e: Throwable => logDebug("Error when close socket to
StatsD", e)
+}
+}
+
+ private def reportGauge(name: String, gauge: Gauge[_])(implicit socket:
DatagramSocket) =
+formatAny(gauge.getValue).foreach(v => send(fullName(name), v, GAUGE))
+
+ private def reportCounter(name: String, counter: Counter)(implicit
socket: DatagramSocket) =
+send(fullName(name), format(counter.getCount), COUNTER)
+
+ private def reportHistogram(name: String, histogram: Histogram)
+ (implicit
