[GitHub] srowen commented on issue #23567: [MINOR][BUILD] ensure call to translate_component has correct number of arguments
srowen commented on issue #23567: [MINOR][BUILD] ensure call to translate_component has correct number of arguments URL: https://github.com/apache/spark/pull/23567#issuecomment-455236842 I think we can't enable it as we don't have admin access but can check on the code status periodically This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] srowen commented on issue #23567: [MINOR][BUILD] ensure call to translate_component has correct number of arguments
srowen commented on issue #23567: [MINOR][BUILD] ensure call to translate_component has correct number of arguments URL: https://github.com/apache/spark/pull/23567#issuecomment-455182949 @ipwright as an example, in https://lgtm.com/projects/g/apache/spark/snapshot/eabef9f5294181257dc2d5bc39e77652101f48ac/files/python/pyspark/mllib/clustering.py?sort=name&dir=ASC&mode=heatmap#xfc95d54cf2a4e9cd:1 , `DenseVector` is reported as unused but is referenced in the doctest. Maybe there is something more subtle going on here but it seems like the import is needed This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] srowen commented on issue #23567: [MINOR][BUILD] ensure call to translate_component has correct number of arguments
srowen commented on issue #23567: [MINOR][BUILD] ensure call to translate_component has correct number of arguments URL: https://github.com/apache/spark/pull/23567#issuecomment-455144196 Thanks @ipwright , I opened https://github.com/apache/spark/pull/23571 to fix many of the rest of the small issues, and https://github.com/apache/spark/pull/23570 to fix a bug. I'm a fan of static analysis just because it occasionally catches real bugs. The only minor issue I find is that the 'unused import' detection doesn't account for doctest usages. The Java code was already pretty OK as IntelliJ inspection had turned up most of the problems, but I don't think we'd made a comprehensive effort on Python. Oege mentioned that Scala analysis might come eventually, which would obviously be really good too, but is a lot harder. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] srowen commented on issue #23567: [MINOR][BUILD] ensure call to translate_component has correct number of arguments
srowen commented on issue #23567: [MINOR][BUILD] ensure call to translate_component has correct number of arguments URL: https://github.com/apache/spark/pull/23567#issuecomment-455025006 Merged to master This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] srowen commented on issue #23567: [MINOR][BUILD] ensure call to translate_component has correct number of arguments
srowen commented on issue #23567: [MINOR][BUILD] ensure call to translate_component has correct number of arguments URL: https://github.com/apache/spark/pull/23567#issuecomment-454978178 @ipwright BTW I love Semmle / LGTM and have had a look through the warnings... I can open a PR to fix a lot of the simple ones. It uncovered at least one non-trivial bug: Pyspark vector classes don't actually implement unary negation correctly. It throws an error. Fixing that ... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
