[GitHub] srowen commented on issue #23580: [SPARK-26660]Add warning logs when broadcasting large task binary

2019-01-27 Thread GitBox
srowen commented on issue #23580: [SPARK-26660]Add warning logs when 
broadcasting large task binary
URL: https://github.com/apache/spark/pull/23580#issuecomment-458000380
 
 
   Oh, shoot, there's a bug here: `if (taskBinaryBytes.length * 1000 > 
TaskSetManager.TASK_SIZE_TO_WARN_KB)`
   The `* 1000` should be on the other size. I read right past that. I'll make 
a follow up. That should eliminate a lot of the warnings!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[GitHub] srowen commented on issue #23580: [SPARK-26660]Add warning logs when broadcasting large task binary

2019-01-23 Thread GitBox
srowen commented on issue #23580: [SPARK-26660]Add warning logs when 
broadcasting large task binary
URL: https://github.com/apache/spark/pull/23580#issuecomment-456830119
 
 
   Merged to master


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org