Re: [PR] [MINOR][CORE] Remove an outdated TODO from UnsafeHashedRelation [spark]
LuciferYang commented on code in PR #46736: URL: https://github.com/apache/spark/pull/46736#discussion_r1613125740 ## sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala: ## @@ -396,8 +396,6 @@ private[joins] class UnsafeHashedRelation( val nKeys = readLong() val nValues = readLong() // This is used in Broadcast, shared by multiple tasks, so we use on-heap memory -// TODO(josh): This needs to be revisited before we merge this patch; making this change now -// so that tests compile: Review Comment: It seems that this was a reminder for the author to revisit this part of the code before merging, but it was forgotten to be deleted when the code was merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[PR] [MINOR][CORE] Remove an outdated TODO from UnsafeHashedRelation [spark]
LuciferYang opened a new pull request, #46736: URL: https://github.com/apache/spark/pull/46736 ### What changes were proposed in this pull request? This pr remove an outdated TODO from `UnsafeHashedRelation`: ``` // TODO(josh): This needs to be revisited before we merge this patch; making this change now // so that tests compile: ``` ### Why are the changes needed? Remove an outdated TODO ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
