Re: [PR] [SPARK-48113][CONNECT] Allow Plugins to integrate with Spark Connect [spark]
nchammas commented on PR #46364: URL: https://github.com/apache/spark/pull/46364#issuecomment-2116496398 Looks like the docs I am looking for are in #45340. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48113][CONNECT] Allow Plugins to integrate with Spark Connect [spark]
nchammas commented on PR #46364: URL: https://github.com/apache/spark/pull/46364#issuecomment-2106321926 What's a Spark Connect Plugin? And where can we read some documentation about how to create one? I see there is [this blog post][1] describing how to extend Spark Connect, but I assume we have (or should have) our own documentation about this, no? [1]: https://semyonsinchenko.github.io/ssinchenko/post/extending-spark-connect/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48113][CONNECT] Allow Plugins to integrate with Spark Connect [spark]
HyukjinKwon closed pull request #46364: [SPARK-48113][CONNECT] Allow Plugins to integrate with Spark Connect URL: https://github.com/apache/spark/pull/46364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48113][CONNECT] Allow Plugins to integrate with Spark Connect [spark]
HyukjinKwon commented on PR #46364: URL: https://github.com/apache/spark/pull/46364#issuecomment-2097782732 Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48113][CONNECT] Allow Plugins to integrate with Spark Connect [spark]
dongjoon-hyun commented on PR #46364: URL: https://github.com/apache/spark/pull/46364#issuecomment-2093265227 Could you re-trigger CIs, @tomvanbussel ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48113][CONNECT] Allow Plugins to integrate with Spark Connect [spark]
HyukjinKwon commented on code in PR #46364: URL: https://github.com/apache/spark/pull/46364#discussion_r1589059935 ## connector/connect/server/src/test/scala/org/apache/spark/sql/connect/plugin/SparkConnectPluginRegistrySuite.scala: ## @@ -20,8 +20,8 @@ package org.apache.spark.sql.connect.plugin import java.util.Optional import com.google.protobuf Review Comment: ```suggestion import com.google.protobuf ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[PR] [SPARK-48113][CONNECT] Allow Plugins to integrate with Spark Connect [spark]
tomvanbussel opened a new pull request, #46364: URL: https://github.com/apache/spark/pull/46364 ### What changes were proposed in this pull request? This PR enables Spark Connect plugins to process `Relation`s and `Expression`s using `SparkConnectPlanner` on the server side and to create `DataFrame`s using `Relation`s on the client side. This has been difficult due to the shading of the protobuf libraries, which meant that Java classes generated for the plugin's Protobuf message usage different base classes than the Java classes for Spark's protobuf messages. This was previously worked around by adding methods that accept a byte array (containing a serialized protobuf message) instead of a protobuf message. Unfortunately, this was not scalable as a lot of methods (such as `DataTypeProtoConverter.toCatalystType`) did not have this alternative. Luckily, we can avoid having to do this as the generated Java classes are not shaded and can still be used from plugins. Instead, plugins should serialize their own version of the generated Java classes for Spark Connect's protobuf messages and then parse them using Spark's (using the `Co nnectProtoUtils` added in this PR). ### Why are the changes needed? Enable the development of Spark Connect plugins. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests ### Was this patch authored or co-authored using generative AI tooling? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
