Re: [PR] [SPARK-48239][INFRA][FOLLOWUP] install the missing `jq` library [spark]

2024-05-24 Thread via GitHub


cloud-fan closed pull request #46743: [SPARK-48239][INFRA][FOLLOWUP] install 
the missing `jq` library
URL: https://github.com/apache/spark/pull/46743


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-48239][INFRA][FOLLOWUP] install the missing `jq` library [spark]

2024-05-24 Thread via GitHub


cloud-fan commented on PR #46743:
URL: https://github.com/apache/spark/pull/46743#issuecomment-2130735901

   thanks for review, merging to master!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-48239][INFRA][FOLLOWUP] install the missing `jq` library [spark]

2024-05-24 Thread via GitHub


cloud-fan commented on PR #46743:
URL: https://github.com/apache/spark/pull/46743#issuecomment-2130727208

   cc @HyukjinKwon @dongjoon-hyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-48239][INFRA][FOLLOWUP] install the missing `jq` library [spark]

2024-05-24 Thread via GitHub


cloud-fan commented on code in PR #46743:
URL: https://github.com/apache/spark/pull/46743#discussion_r1614307758


##
dev/create-release/release-util.sh:
##
@@ -128,6 +128,9 @@ function get_release_info {
 RC_COUNT=1
   fi
 
+  if [ "$GIT_BRANCH" = "master" ]; then
+RELEASE_VERSION="$RELEASE_VERSION-preview1"

Review Comment:
   This is unrelated change, but gives better prompt for preview releases



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



[PR] [SPARK-48239][INFRA][FOLLOWUP] install the missing `jq` library [spark]

2024-05-24 Thread via GitHub


cloud-fan opened a new pull request, #46743:
URL: https://github.com/apache/spark/pull/46743

   
   
   ### What changes were proposed in this pull request?
   
   This is a followup of https://github.com/apache/spark/pull/46534 . We missed 
the `jq` library which is needed to create git tags.
   
   ### Why are the changes needed?
   
   fix bug
   
   ### Does this PR introduce _any_ user-facing change?
   
   no
   
   ### How was this patch tested?
   
   manual
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   no


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org