Re: [PR] [SPARK-48312][SQL] Improve Alias.removeNonInheritableMetadata performance [spark]
cloud-fan closed pull request #46622: [SPARK-48312][SQL] Improve Alias.removeNonInheritableMetadata performance URL: https://github.com/apache/spark/pull/46622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48312][SQL] Improve Alias.removeNonInheritableMetadata performance [spark]
cloud-fan commented on PR #46622: URL: https://github.com/apache/spark/pull/46622#issuecomment-2117503274 thanks, merging to master! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-48312][SQL] Improve Alias.removeNonInheritableMetadata performance [spark]
cloud-fan commented on code in PR #46622: URL: https://github.com/apache/spark/pull/46622#discussion_r1604351546 ## sql/api/src/main/scala/org/apache/spark/sql/types/Metadata.scala: ## @@ -49,6 +49,9 @@ sealed class Metadata private[types] (private[types] val map: Map[String, Any]) /** Tests whether this Metadata contains a binding for a key. */ def contains(key: String): Boolean = map.contains(key) + /** Tests whether this Metadata is empty. */ + def isEmpty: Boolean = map.isEmpty Review Comment: +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
