Re: [PR] [SPARK-47693][TESTS][FOLLOWUP] Reduce CollationBenchmarks time [spark]
dongjoon-hyun commented on PR #46283: URL: https://github.com/apache/spark/pull/46283#issuecomment-2083140547 Merged to master for Apache Spark 4.0.0. Please let us know if we need to increase the iteration back for some reason, @nikolamand-db -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47693][TESTS][FOLLOWUP] Reduce CollationBenchmarks time [spark]
dongjoon-hyun closed pull request #46283: [SPARK-47693][TESTS][FOLLOWUP] Reduce CollationBenchmarks time URL: https://github.com/apache/spark/pull/46283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47693][TESTS][FOLLOWUP] Reduce CollationBenchmarks time [spark]
dongjoon-hyun commented on PR #46283: URL: https://github.com/apache/spark/pull/46283#issuecomment-2083137896 I manually verify the compilation and run. ``` $ build/sbt "sql/Test/runMain org.apache.spark.sql.execution.benchmark.CollationBenchmark" ... [info] running (fork) org.apache.spark.sql.execution.benchmark.CollationBenchmark [error] WARNING: Using incubator modules: jdk.incubator.vector [info] Running benchmark: collation unit benchmarks - equalsFunction [info] Running case: UTF8_BINARY_LCASE [info] Stopped after 2 iterations, 2540 ms [info] Running case: UNICODE [info] Stopped after 2 iterations, 3297 ms [info] Running case: UTF8_BINARY [info] Stopped after 2 iterations, 3162 ms [info] Running case: UNICODE_CI ... ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
Re: [PR] [SPARK-47693][TESTS][FOLLOWUP] Reduce CollationBenchmarks time [spark]
dongjoon-hyun commented on PR #46283: URL: https://github.com/apache/spark/pull/46283#issuecomment-2083129773 Since this is a simple reduction of iteration, let me merge this first to unblock @yaooqinn 's ANSI full benchmark. - #46266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org