Re: [PR] [SPARK-48016][SQL][3.5] Fix a bug in try_divide function when with decimals [spark]

2024-05-01 Thread via GitHub


dongjoon-hyun commented on PR #46323:
URL: https://github.com/apache/spark/pull/46323#issuecomment-2089200222

   Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-48016][SQL][3.5] Fix a bug in try_divide function when with decimals [spark]

2024-05-01 Thread via GitHub


dongjoon-hyun closed pull request #46323: [SPARK-48016][SQL][3.5] Fix a bug in 
try_divide function when with decimals
URL: https://github.com/apache/spark/pull/46323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-48016][SQL][3.5] Fix a bug in try_divide function when with decimals [spark]

2024-05-01 Thread via GitHub


gengliangwang commented on PR #46323:
URL: https://github.com/apache/spark/pull/46323#issuecomment-2089172224

   CI passed. Merging to branch-3.5


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-48016][SQL][3.5] Fix a bug in try_divide function when with decimals [spark]

2024-05-01 Thread via GitHub


dongjoon-hyun commented on PR #46323:
URL: https://github.com/apache/spark/pull/46323#issuecomment-2088974804

   Let's make it sure that all tests pass on this PR builder.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org



Re: [PR] [SPARK-48016][SQL][3.5] Fix a bug in try_divide function when with decimals [spark]

2024-05-01 Thread via GitHub


gengliangwang commented on PR #46323:
URL: https://github.com/apache/spark/pull/46323#issuecomment-2088905069

   @dongjoon-hyun Thanks for pointing out the mistaken changes! It is now 
reverted in 
https://github.com/apache/spark/pull/46323/commits/0a43e3ab982dcb21bfaf9594db0233a354f12869


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org