[Citadel Development] (no subject)

[davew]

Wed Jan 23 2008 23:33:40 EST from IGnatius T [EMAIL PROTECTED] davew: there's a problem with the new code that purges users during shutdown.  Ithink it has something to do with the fact that the thread doing the shutdown ismissing some thread-specific variables, and therefore the MYTID macro segfaults:Hmm, yes, I can see this now.Why didn't I spot that before.The problem is that we are purging the sessions which calls logout which calls purge_user but the session isn't logged in and it has no TSD anymore so purge_user fails and we get SEGFLT.I'll get on to this this afternoon.

[Citadel Development] (no subject)

[IO ERROR]

Hey, did somebody forget to check something in? I can't find any file 
containing definitions for these:  
   
 user_ops.c: In function bsession_startupb:  
 user_ops.c:546: error: bVIEW_MAILBOXb undeclared (first use in this 
function)  
 user_ops.c:546: error: (Each undeclared identifier is reported only once  
 user_ops.c:546: error: for each function it appears in.)  
 user_ops.c: In function bcreate_userb:  
 user_ops.c:891: warning: unused variable bpwdbufferb  
 user_ops.c:958: error: bVIEW_MAILBOXb undeclared (first use in this 
function)  
 user_ops.c:961: error: bVIEW_BBSb undeclared (first use in this function) 
 
 make: *** [user_ops.o] Error 1  
  

[Citadel Development] (no subject)

[IGnatius T Foobar]

That's definitely the case, and we should make sure that we fail during 
configure time in that case.  
  

[Citadel Development] Citadel commit log: revision 5982

[davew]

r5982 | davew | 2008-01-26 13:57:31 -0500 (Sat, 26 Jan 2008) | 3 lines
Changed paths:
   M /trunk/citadel/user_ops.c

Fix the segault on server shutdown that crept in when we decided to
purge users at logout.

[Citadel Development] (no subject)

[IO ERROR]

 Stating the obvious, but you did do make install didn't you?   
   
 Doh! Sometimes you do have to state the obvious. NOW it works.  
  

[Citadel Development] Citadel commit log: revision 5983

[dothebart]

r5983 | dothebart | 2008-01-26 18:57:07 -0500 (Sat, 26 Jan 2008) | 2 lines
Changed paths:
   M /trunk/citadel/debian/citadel.init
   M /trunk/citadel/setup.c

* restart by doing 'sendcommand down 1' which will make citserver restart 
internaly.

[Citadel Development] Citadel commit log: revision 5985

[dothebart]

r5985 | dothebart | 2008-01-26 19:31:44 -0500 (Sat, 26 Jan 2008) | 2 lines
Changed paths:
   M /trunk/citadel/setup.c

* we didn't calculate our directories in a proper sequence. fixed hereby.