[Citadel Development] Re: [SCM] citadel.org branch, master, updated. 826932b012c26b5ef97a5bbf45acf10fca6acc60
> Nov 9 2010 9:08pm from IGnatius T Foobar @uncnsrd >Subject: Re: [SCM] citadel.org branch, master, updated. >826932b012c26b5ef97a5bbf45acf10fca6acc60 > >so far? imaptest and thunderbird. > > Until you've also tested Outlook, Pine, whatever Apple is using these >days, and a mobile client or two ... assume that your patch broke them >all. Seriously. > IMAP is that fragile. > > Amen to that... And, it looks like we are broken with Evolution 2.30.3 right now on copy and move operations (both SSL and non-SSL). Need to look at the code to figure out what's going on...
[Citadel Development] Re: [SCM] citadel.org branch, master, updated. 826932b012c26b5ef97a5bbf45acf10fca6acc60
So Nov 07 2010 15:53:26 EST von IGnatius T Foobar @ Uncensored Betreff: Re: [SCM] citadel.org branch, master, updated. 826932b012c26b5ef97a5bbf45acf10fca6acc60
When I see the words "rewrite IMAP module" I get very very scared. How many different clients were tested to make sure nothing broke?
so far? imaptest and thunderbird.
Imaptest: me has a question here. it groans over imap_fetch.c:
/* * Fetch RFC822-formatted messages. * * 'whichfmt' should be set to one of: * "RFC822" entire message * "RFC822.HEADER" headers only (with trailing blank line) * "RFC822.SIZE" size of translated message * "RFC822.TEXT" body only (without leading blank line) */void imap_fetch_rfc822(long msgnum, const char *whichfmt) {
if (IMAP->cached_rfc822 == NULL) {...
if (!need_body) cprintf("\r\n"); /* extra trailing newline */
if thats here (commented it out for testing, success then) imaptest complains about that it doesn't find the closing ')' from that reply. TSS in irc://##imap gave me the hint that this linebreak mustn't be there.
since I didn't find a usefull commit message for that line, IG, do you remember a specific reason why its there anyways?
in general, that rewrite wasn't intended to change syntax in by any means; its there because of evolutions imap implementation can't stand us sending the greeting in several tcp packages (cut where i've added the linebreaks):
CAPABILITY IMAP4REV1 NAMESPACE ID AUTH=PLAIN AUTH=LOGIN UIDPLUS
ACL
STARTTLS
METADATA
citadel blablabla
which now come in one chunk like that:
CAPABILITY IMAP4REV1 NAMESPACE ID AUTH=PLAIN AUTH=LOGIN UIDPLUS ACL STARTTLS METADATA citadel blablabla
which is achieved by replacing cprintf by calls writing to outbound buffers which is then sent to the client in one piece at the end.
There are several tiny exceptions from it, where the code chatters with the client without the dispatcher loop (hope I found all of them)
Next i've replaced all "%s BAD lorem ipsum\r\n" , Params[0].Key by a function implicitely prepending Params[0].Key' ' and appending '\r\n' So we don't need a printf here in most places (which is good because of it saves us lots of strlens ;-)
the other part of the rewrite is to replace the rumpelstilskin handler lookup by a hashtable filled a start time.
[Citadel Development] [SCM] citadel.org branch, master, updated. 1df716eddbca297ce382f34b26fc70816643f9d9
Push to the project "citadel.org ": The branch, master has been updated via 1df716eddbca297ce382f34b26fc70816643f9d9 (commit) via 5c7d64b6f129255600d8520ea015b830ea3c52ad (commit) via 2d9b56096eb417b5e8a4fe8d1bc2c5238d624fb7 (commit) via 4bb64db3e29d073e63577e6927e8fb7144911db7 (commit) from 826932b012c26b5ef97a5bbf45acf10fca6acc60 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=1df716eddbca297ce382f34b26fc70816643f9d9 commit 1df716eddbca297ce382f34b26fc70816643f9d9 Author: Wilfried Goesgens Date: Mon Nov 8 21:44:29 2010 +0100 fix some incompletely transformed reply strings; thanks gcov & imaptest http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=5c7d64b6f129255600d8520ea015b830ea3c52ad commit 5c7d64b6f129255600d8520ea015b830ea3c52ad Author: Wilfried Goesgens Date: Mon Nov 8 21:43:19 2010 +0100 more gcov files to ignore... http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=2d9b56096eb417b5e8a4fe8d1bc2c5238d624fb7 commit 2d9b56096eb417b5e8a4fe8d1bc2c5238d624fb7 Author: Wilfried Goesgens Date: Mon Nov 8 21:40:53 2010 +0100 add a way to configure code coverage http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=4bb64db3e29d073e63577e6927e8fb7144911db7 commit 4bb64db3e29d073e63577e6927e8fb7144911db7 Author: Wilfried Goesgens Date: Mon Nov 8 21:38:31 2010 +0100 Ignore data files left behind by gcov --- Summary of changes: citadel/.gitignore|2 ++ citadel/debian/rules |7 ++- citadel/modules/imap/imap_misc.c |4 ++-- citadel/modules/imap/imap_tools.h | 10 +- citadel/modules/imap/serv_imap.c |6 +++--- 5 files changed, 14 insertions(+), 15 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. e7334f03a7fd028ed90f74cb71db8b9b32c04371
Push to the project "citadel.org ": The branch, master has been updated via e7334f03a7fd028ed90f74cb71db8b9b32c04371 (commit) from 1df716eddbca297ce382f34b26fc70816643f9d9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=e7334f03a7fd028ed90f74cb71db8b9b32c04371 commit e7334f03a7fd028ed90f74cb71db8b9b32c04371 Author: root Date: Mon Nov 8 23:31:13 2010 +0100 add script to generate gcov/lcov output. --- Summary of changes: citadel/scripts/dolcov.sh | 24 1 files changed, 24 insertions(+), 0 deletions(-) create mode 100755 citadel/scripts/dolcov.sh hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. adb5baf6bdb58fe0f426f4b2b64294527d589d70
Push to the project "citadel.org ": The branch, master has been updated via adb5baf6bdb58fe0f426f4b2b64294527d589d70 (commit) from 78deb8707b5bbd917bb2c6ac816a40a75df33410 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=adb5baf6bdb58fe0f426f4b2b64294527d589d70 commit adb5baf6bdb58fe0f426f4b2b64294527d589d70 Author: Art Cancro Date: Wed Nov 10 00:04:45 2010 -0500 msgbuttons are now back to being ordinary links. They're smaller this way, and they also don't misbehave under Internet Exploder. --- Summary of changes: webcit/static/styles/webcit.css | 17 +++-- webcit/static/t/view_message.html |7 ++- 2 files changed, 9 insertions(+), 15 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] Re: [SCM] citadel.org branch, master, updated. 826932b012c26b5ef97a5bbf45acf10fca6acc60
>so far? imaptest and thunderbird. Until you've also tested Outlook, Pine, whatever Apple is using these days, and a mobile client or two ... assume that your patch broke them all. Seriously. IMAP is that fragile.
[Citadel Development] [SCM] citadel.org branch, master, updated. 90a90f347bea035bbed1b3d13e40b7a23765af11
Push to the project "citadel.org ": The branch, master has been updated via 90a90f347bea035bbed1b3d13e40b7a23765af11 (commit) from adb5baf6bdb58fe0f426f4b2b64294527d589d70 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=90a90f347bea035bbed1b3d13e40b7a23765af11 commit 90a90f347bea035bbed1b3d13e40b7a23765af11 Author: Wilfried Goesgens Date: Wed Nov 10 20:22:16 2010 +0100 fix buffer overrun while converting charsets * DecodeSegment() didn't check whether one of the temporary buffers would be able to bear the transcoding results --- Summary of changes: libcitadel/lib/stringbuf.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 78deb8707b5bbd917bb2c6ac816a40a75df33410
Push to the project "citadel.org ": The branch, master has been updated via 78deb8707b5bbd917bb2c6ac816a40a75df33410 (commit) from abc90f03433db7a011dd09c0a7e5323606965be4 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=78deb8707b5bbd917bb2c6ac816a40a75df33410 commit 78deb8707b5bbd917bb2c6ac816a40a75df33410 Author: Wilfried Goesgens Date: Tue Nov 9 22:59:46 2010 +0100 Update translations to Launchpad R13 --- Summary of changes: citadel/po/citadel-setup/fr.po | 58 ++-- webcit/po/webcit/nl.po | 146 +--- 2 files changed, 98 insertions(+), 106 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] Re: [SCM] citadel.org branch, master, updated. abc90f03433db7a011dd09c0a7e5323606965be4
Mo Nov 08 2010 19:28:46 EST von "dothebart" Betreff: [SCM] citadel.org branch, master, updated. abc90f03433db7a011dd09c0a7e5323606965be4 Push to the project "citadel.org ": The branch, master has been updated via abc90f03433db7a011dd09c0a7e5323606965be4 (commit) from e7334f03a7fd028ed90f74cb71db8b9b32c04371 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=abc90f03433db7a011dd09c0a7e5323606965be4 commit abc90f03433db7a011dd09c0a7e5323606965be4 Author: Wilfried Goesgens Date: Tue Nov 9 01:29:50 2010 +0100 check whether the sorting algorithm specified via BSTRs is intended for us before using its groupchange detector. --- how could this dodge our radar that long???
[Citadel Development] Re: [SCM] citadel.org branch, master, updated. 826932b012c26b5ef97a5bbf45acf10fca6acc60
When I see the words "rewrite IMAP module" I get very very scared. How many different clients were tested to make sure nothing broke?
[Citadel Development] [SCM] citadel.org branch, stable-78x, updated. 4de6cf41701eed5321139e0a7959477da290c169
Push to the project "citadel.org ": The branch, stable-78x has been updated via 4de6cf41701eed5321139e0a7959477da290c169 (commit) from 799d59665f42e95572f1870813203ccf3ec53273 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=4de6cf41701eed5321139e0a7959477da290c169 commit 4de6cf41701eed5321139e0a7959477da290c169 Author: Wilfried Goesgens Date: Wed Nov 10 20:22:16 2010 +0100 fix buffer overrun while converting charsets * DecodeSegment() didn't check whether one of the temporary buffers would be able to bear the transcoding results --- Summary of changes: libcitadel/lib/stringbuf.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. abc90f03433db7a011dd09c0a7e5323606965be4
Push to the project "citadel.org ": The branch, master has been updated via abc90f03433db7a011dd09c0a7e5323606965be4 (commit) from e7334f03a7fd028ed90f74cb71db8b9b32c04371 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=abc90f03433db7a011dd09c0a7e5323606965be4 commit abc90f03433db7a011dd09c0a7e5323606965be4 Author: Wilfried Goesgens Date: Tue Nov 9 01:29:50 2010 +0100 check whether the sorting algorithm specified via BSTRs is intended for us before using its groupchange detector. --- Summary of changes: webcit/subst.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] Re:
We'll do what we always do -- deploy it first to Uncensored and see how it is received by the user community. It wouldn't be the first time we had a UI design rejected. I was really proud of the dynamic BBS view but nobody liked it.
[Citadel Development] [SCM] citadel.org branch, master, updated. 9148bf110ec104dd6035c8f511d4c88afb276278
Push to the project "citadel.org ": The branch, master has been updated via 9148bf110ec104dd6035c8f511d4c88afb276278 (commit) from 79deb44467aad2192fa07a7491d1c19daf89a255 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=9148bf110ec104dd6035c8f511d4c88afb276278 commit 9148bf110ec104dd6035c8f511d4c88afb276278 Author: Wilfried Goesgens Date: Sat Nov 6 12:18:23 2010 +0100 Nonblocking sockets need to select while writing we changed the SMTP outbound connections to be nonblocking so we could abort on not reacting SMTP-Servers. thus we need to select before writing, else the connection will fail. --- Summary of changes: citadel/clientsocket.c | 34 -- 1 files changed, 32 insertions(+), 2 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, stable-78x, updated. 799d59665f42e95572f1870813203ccf3ec53273
Push to the project "citadel.org ": The branch, stable-78x has been updated via 799d59665f42e95572f1870813203ccf3ec53273 (commit) via e8c44fc2fdc87e34de88764ae62b1eeb0d7a1731 (commit) from fa19b57c6995999bc11bf7b502ba7cef8a46e02f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=799d59665f42e95572f1870813203ccf3ec53273 commit 799d59665f42e95572f1870813203ccf3ec53273 Author: Wilfried Goesgens Date: Thu Nov 4 20:28:27 2010 +0100 fix crash in SSL BLOB-Reading - when diciding whether the read buffer contains more than the blob reader wants we had a wrong equation. http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=e8c44fc2fdc87e34de88764ae62b1eeb0d7a1731 commit e8c44fc2fdc87e34de88764ae62b1eeb0d7a1731 Author: Wilfried Goesgens Date: Fri Nov 5 00:12:50 2010 +0100 if we tell the client we're in error state, return. if SNET would fail to open the temporary file, it would tell the client 'error' and continue to read -> hang we now abort after reporting the error. --- Summary of changes: citadel/modules/crypto/serv_crypto.c |2 +- citadel/modules/network/serv_network.c |1 + 2 files changed, 2 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. a1b7d9e895e73401161427363611b0160f51225f
Push to the project "citadel.org ": The branch, master has been updated via a1b7d9e895e73401161427363611b0160f51225f (commit) from 9148bf110ec104dd6035c8f511d4c88afb276278 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=a1b7d9e895e73401161427363611b0160f51225f commit a1b7d9e895e73401161427363611b0160f51225f Author: Wilfried Goesgens Date: Sat Nov 6 13:51:41 2010 +0100 have flexible timouts while reading lines in our client mode connections since some mailserver take a little longer to finish reading mails we need to wait after we send our '.\r\n'; its 90 seconds now, all other parts will wait 5s, quit will wait 1 second. --- Summary of changes: citadel/clientsocket.c | 29 + citadel/clientsocket.h |4 ++-- citadel/modules/smtp/serv_smtp.c | 20 +++- citadel/msgbase.c|2 +- 4 files changed, 35 insertions(+), 20 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 826932b012c26b5ef97a5bbf45acf10fca6acc60
Push to the project "citadel.org ": The branch, master has been updated via 826932b012c26b5ef97a5bbf45acf10fca6acc60 (commit) from a1b7d9e895e73401161427363611b0160f51225f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=826932b012c26b5ef97a5bbf45acf10fca6acc60 commit 826932b012c26b5ef97a5bbf45acf10fca6acc60 Author: Wilfried Goesgens Date: Sun Nov 7 21:29:18 2010 +0100 Rewrite IMAP-Module to buffer its output - move defines from imap_tools.h into serv_imap.h - switch includes in sequence - we now have IMAP->Reply, which we write into, until IUnbuffer sends it to the client - IReply & IReplyPrintf do now send 'Params[0].Key BAD xx\r\n' to the client; this makes the code more compact. - IA* append stuff to the outbuffer that we want to send. - replace rumpelstilskin handler lookup by hashlist and central register calls. - replace if's in the sequence separating the handlers by their required pre-conditions by flags on the register call. this should - (hopefully) fix some troubles with evolutions imap, which wouldn't like to read enough chunks until the line ends - speed up stuff like header fetching in huge lists, since we reduce the number of context switches here. --- Summary of changes: citadel/modules/imap/imap_acl.c | 95 +++-- citadel/modules/imap/imap_fetch.c| 344 +--- citadel/modules/imap/imap_list.c | 25 +- citadel/modules/imap/imap_metadata.c | 121 +++--- citadel/modules/imap/imap_misc.c | 94 +++-- citadel/modules/imap/imap_search.c | 104 +++--- citadel/modules/imap/imap_store.c| 33 +- citadel/modules/imap/imap_tools.c| 205 +++--- citadel/modules/imap/imap_tools.h| 53 ++- citadel/modules/imap/serv_imap.c | 762 -- citadel/modules/imap/serv_imap.h | 51 +++ 11 files changed, 1036 insertions(+), 851 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] Re:
yep, the current version is definitely much better. It removes all needs to go to older messages most of the time by simply displaying them. we're all curious how your thread view will look like ;-)
[Citadel Development] Re: [SCM] citadel.org branch, master, updated. 79deb44467aad2192fa07a7491d1c19daf89a255
*gna* try to fix one thing, struggle over another bunch.
Do Nov 04 2010 19:16:50 EDT von "dothebart" Betreff: [SCM] citadel.org branch, master, updated. 79deb44467aad2192fa07a7491d1c19daf89a255
Push to the project "citadel.org ": The branch, master has been updated via 79deb44467aad2192fa07a7491d1c19daf89a255 (commit) via 307c9e794f9c4f8dcfc91d97b12516f1d97ce96b (commit) via 773109ae28be6e2e5243601b5166464136bd0299 (commit) from 63943567e9d16742afac41fa1c3e51d971776792 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=79deb44467aad2192fa07a7491d1c19daf89a255 commit 79deb44467aad2192fa07a7491d1c19daf89a255 Author: Wilfried Goesgens Date: Fri Nov 5 00:17:09 2010 +0100 handle errors during netedit: - put server errors into the ImportantMessage - use StrBuf - use GetServerStatus http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=307c9e794f9c4f8dcfc91d97b12516f1d97ce96b commit 307c9e794f9c4f8dcfc91d97b12516f1d97ce96b Author: Wilfried Goesgens Date: Fri Nov 5 00:14:38 2010 +0100 New macro for putting a Citserver reply into important message: SRV_STATUS_MSG Use it like that: StrBuf_ServGetln(Line); if (GetServerStatus(Line, NULL) != 1) { AppendImportantMessage(SRV_STATUS_MSG(Line)); http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=773109ae28be6e2e5243601b5166464136bd0299 commit 773109ae28be6e2e5243601b5166464136bd0299 Author: Wilfried Goesgens Date: Fri Nov 5 00:12:50 2010 +0100 if we tell the client we're in error state, return. if SNET would fail to open the temporary file, it would tell the client 'error' and continue to read -> hang we now abort after reporting the error. --- Summary of changes: citadel/modules/network/serv_network.c |1 + webcit/roomops.c | 43 +++- webcit/webcit.h|2 +- 3 files changed, 33 insertions(+), 13 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] Re: Patch to begin ip address/session ID logging
Hi -
This patch should be closer in line w/ the below suggestions. Let me know if
this looks good/additional suggestions.
I'm only addressing the command loop in this one; will hit the other
applicable modules down the road.
- Stu
> Sat Sep 18 2010 02:48:05 PM EDT from scianos @ Uncensored Subject: Re:
>Patch to begin ip address/session ID logging
>
>
>
>Most definitely! I'll make the modifications and resubmit for feedback.
>
>- Stu
>> Sat Sep 18 2010 07:08:16 AM EDT from dothebart @ Uncensored Subject:
>>Re: Patch to begin ip address/session ID logging
>>
>>
>>
>>Stu,
>>
>>I basically like the idea of your patch. Could you please modify it a
>>little bit?
>>
>>in modules/smtp/srv_smtp.c:smtp_data(void) we have a detection of the
>>userid sending the mail; we should have this in the local case of your macro
>>too.
>>
>>and for your macro 'CTDLUSERIP', please try to use the IsEmptyStr() macro
>>here...
>>
>>for the userID thing, probably the printf with the %ld could be done
>>somewhere near the place the IP is fetched from the socket properties to a
>>static string on CC, so %s in the printf string works out; smtp_data should
>>use that string too.
>>
>>TIA,
>>
>>dothebart
>>
>>
>>> Sa Sep 18 2010 04:11:40 EDT von scianos @ Uncensored Betreff: Patch
>>>to begin ip address/session ID logging
>>>
>>>
>>>
>>>Hi -
>>>
>>>I've been looking at enabling the ability for Citadel to log the session
>>>ID, hostname, and user for commands being executed, et al. This will help
>>>sysadmins integrate IP blocking for dictionary attacks against the database
>>>as well as being able to associate commands being logged (for those of us
>>>that do so) with a particular session and IP. This may be particularly
>>>helpful for those of us that publish the Citadel server port onto the
>>>internet.
>>>
>>>A diff against trunk is attached. Looking for feedback - does this look
>>>like a good path or is there a better way to go about it (better to get
>>>feedback before going all out!). Hopefully this could be considered for
>>>inclusion down the road if it's deemed helpful.
>>>
>>>- Stu
>>>
>>>
>>>
>>>
>>
>>
>>
>>
>>
>>
>>
>
>
>
>
>
>
>
diff --git a/citadel/citserver.c b/citadel/citserver.c
index 859c25f..1df9585 100644
--- a/citadel/citserver.c
+++ b/citadel/citserver.c
@@ -1032,10 +1032,10 @@ void do_command_loop(void) {
/* Log the server command, but don't show passwords... */
if ( (strncasecmp(cmdbuf, "PASS", 4)) && (strncasecmp(cmdbuf, "SETP", 4)) ) {
- CtdlLogPrintf(CTDL_INFO, "%s\n", cmdbuf);
+ CtdlLogPrintf(CTDL_INFO, "CtdlCommand [%s] [%s] %s\n", CTDLUSERIP, CC->curr_user, cmdbuf);
}
else {
- CtdlLogPrintf(CTDL_INFO, "\n");
+ CtdlLogPrintf(CTDL_INFO, "CtdlCommand [%s] [%s] \n", CTDLUSERIP, CC->curr_user);
}
buffer_output();
diff --git a/citadel/citserver.h b/citadel/citserver.h
index 02815f5..437f4b2 100644
--- a/citadel/citserver.h
+++ b/citadel/citserver.h
@@ -29,6 +29,8 @@ struct UserProcList {
char user[64];
};
+#define CTDLUSERIP (IsEmptyStr(CC->cs_addr) ? "localsocket" : CC->cs_addr)
+
void cit_backtrace(void);
void cit_panic_backtrace(int SigNum);
void master_startup (void);
[Citadel Development] [SCM] citadel.org branch, master, updated. 051de36a755e6db52ae0adc9f9257c438072c50c
Push to the project "citadel.org ": The branch, master has been updated via 051de36a755e6db52ae0adc9f9257c438072c50c (commit) from 9d4b5d1bf7a6e7101099871c5d293722f0225fc6 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=051de36a755e6db52ae0adc9f9257c438072c50c commit 051de36a755e6db52ae0adc9f9257c438072c50c Author: Wilfried Goesgens Date: Mon Nov 1 23:24:54 2010 +0100 fix compilation - Makefile had a wrong include - msgfmt would abort on missing linebreaks --- Summary of changes: citadel/po/citadel-setup/Makefile.in |2 +- citadel/po/citadel-setup/de.po | 12 ++-- citadel/po/citadel-setup/es.po |6 +++--- citadel/po/citadel-setup/fi.po |4 ++-- citadel/po/citadel-setup/fr.po | 22 +++--- 5 files changed, 23 insertions(+), 23 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 9d4b5d1bf7a6e7101099871c5d293722f0225fc6
Push to the project "citadel.org ": The branch, master has been updated via 9d4b5d1bf7a6e7101099871c5d293722f0225fc6 (commit) from c9cf7593dbd2aade23bec479ab7299f50bb67298 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=9d4b5d1bf7a6e7101099871c5d293722f0225fc6 commit 9d4b5d1bf7a6e7101099871c5d293722f0225fc6 Author: Art Cancro Date: Mon Nov 1 14:19:14 2010 -0400 Cosmetic cleanup of previous two commits --- Summary of changes: webcit/roomviews.c | 65 +++ 1 files changed, 34 insertions(+), 31 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 79deb44467aad2192fa07a7491d1c19daf89a255
Push to the project "citadel.org ": The branch, master has been updated
via 79deb44467aad2192fa07a7491d1c19daf89a255 (commit)
via 307c9e794f9c4f8dcfc91d97b12516f1d97ce96b (commit)
via 773109ae28be6e2e5243601b5166464136bd0299 (commit)
from 63943567e9d16742afac41fa1c3e51d971776792 (commit)
Those revisions listed above that are new to this repository have not appeared
on any other notification email; so we list those revisions in full, below.
- Log -
http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=79deb44467aad2192fa07a7491d1c19daf89a255
commit 79deb44467aad2192fa07a7491d1c19daf89a255
Author: Wilfried Goesgens
Date: Fri Nov 5 00:17:09 2010 +0100
handle errors during netedit:
- put server errors into the ImportantMessage
- use StrBuf
- use GetServerStatus
http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=307c9e794f9c4f8dcfc91d97b12516f1d97ce96b
commit 307c9e794f9c4f8dcfc91d97b12516f1d97ce96b
Author: Wilfried Goesgens
Date: Fri Nov 5 00:14:38 2010 +0100
New macro for putting a Citserver reply into important message:
SRV_STATUS_MSG
Use it like that:
StrBuf_ServGetln(Line);
if (GetServerStatus(Line, NULL) != 1) {
AppendImportantMessage(SRV_STATUS_MSG(Line));
http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=773109ae28be6e2e5243601b5166464136bd0299
commit 773109ae28be6e2e5243601b5166464136bd0299
Author: Wilfried Goesgens
Date: Fri Nov 5 00:12:50 2010 +0100
if we tell the client we're in error state, return.
if SNET would fail to open the temporary file, it would tell the client
'error' and continue to read -> hang
we now abort after reporting the error.
---
Summary of changes:
citadel/modules/network/serv_network.c |1 +
webcit/roomops.c | 43 +++-
webcit/webcit.h|2 +-
3 files changed, 33 insertions(+), 13 deletions(-)
hooks/post-receive
--
citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 078029a2391e9b9ff400ce1a5f7140c51858966d
Push to the project "citadel.org ": The branch, master has been updated via 078029a2391e9b9ff400ce1a5f7140c51858966d (commit) from 051de36a755e6db52ae0adc9f9257c438072c50c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=078029a2391e9b9ff400ce1a5f7140c51858966d commit 078029a2391e9b9ff400ce1a5f7140c51858966d Author: Wilfried Goesgens Date: Mon Nov 1 23:38:07 2010 +0100 Do a more precise match to find out our UID --- Summary of changes: citadel/debian/citadel-server.postinst |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] (no subject)
It's still there. I moved it up into the nav bar.
[Citadel Development] Re:
oh, thanks; didn't search for it over there... if I didn't, will others too? is that going to be the primary 'issue' people have with webcit 7.90 and float citadel support then?
[Citadel Development] Re:
Nope. Uncensored will be running the new WebCit too, so if they can't find the save button then they can't post messages complaining about it. :)
[Citadel Development] [SCM] citadel.org branch, master, updated. 41edee5726a67dcd43c948ffed3b4651c1791041
Push to the project "citadel.org ": The branch, master has been updated via 41edee5726a67dcd43c948ffed3b4651c1791041 (commit) from 078029a2391e9b9ff400ce1a5f7140c51858966d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=41edee5726a67dcd43c948ffed3b4651c1791041 commit 41edee5726a67dcd43c948ffed3b4651c1791041 Author: Wilfried Goesgens Date: Tue Nov 2 00:03:41 2010 +0100 Ups, its el_GR not el_EL --- Summary of changes: webcit/gettext.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 84a2bfa29146319899d779c026bcf928abdfe712
Push to the project "citadel.org ": The branch, master has been updated via 84a2bfa29146319899d779c026bcf928abdfe712 (commit) from 219f1d0a086a48e12cd07f9f0c0c6cdf978dfe34 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=84a2bfa29146319899d779c026bcf928abdfe712 commit 84a2bfa29146319899d779c026bcf928abdfe712 Author: Wilfried Goesgens Date: Mon Nov 1 11:48:23 2010 +0100 Blanks. --- Summary of changes: citadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. ec4814cf844f6f070da547fe585ce2f96e806731
Push to the project "citadel.org ": The branch, master has been updated
via ec4814cf844f6f070da547fe585ce2f96e806731 (commit)
from 41edee5726a67dcd43c948ffed3b4651c1791041 (commit)
Those revisions listed above that are new to this repository have not appeared
on any other notification email; so we list those revisions in full, below.
- Log -
http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=ec4814cf844f6f070da547fe585ce2f96e806731
commit ec4814cf844f6f070da547fe585ce2f96e806731
Author: Wilfried Goesgens
Date: Wed Nov 3 21:47:55 2010 +0100
move old tokenizer over to the managesieve server; its only used there.
- remove old_imap_tokenizer from imap_tools.h
- move old_imap_tokenizer to modules/managesieve/serv_managesieve.c
- move imap_tools.h to modules/imap; since its not needed globaly anymore.
---
Summary of changes:
citadel/modules/imap/imap_tools.c | 59 ---
citadel/{ => modules/imap}/imap_tools.h|1 -
citadel/modules/managesieve/serv_managesieve.c | 61 +++-
3 files changed, 60 insertions(+), 61 deletions(-)
rename citadel/{ => modules/imap}/imap_tools.h (97%)
hooks/post-receive
--
citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. a4645d3aa4e647b442aee5c7f0ab50f501ba9790
Push to the project "citadel.org ": The branch, master has been updated via a4645d3aa4e647b442aee5c7f0ab50f501ba9790 (commit) from ec4814cf844f6f070da547fe585ce2f96e806731 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=a4645d3aa4e647b442aee5c7f0ab50f501ba9790 commit a4645d3aa4e647b442aee5c7f0ab50f501ba9790 Author: Wilfried Goesgens Date: Thu Nov 4 20:28:27 2010 +0100 fix crash in SSL BLOB-Reading - when diciding whether the read buffer contains more than the blob reader wants we had a wrong equation. --- Summary of changes: citadel/modules/crypto/serv_crypto.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 63943567e9d16742afac41fa1c3e51d971776792
Push to the project "citadel.org ": The branch, master has been updated via 63943567e9d16742afac41fa1c3e51d971776792 (commit) from a4645d3aa4e647b442aee5c7f0ab50f501ba9790 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=63943567e9d16742afac41fa1c3e51d971776792 commit 63943567e9d16742afac41fa1c3e51d971776792 Author: Wilfried Goesgens Date: Thu Nov 4 22:33:33 2010 +0100 don't fetch a RSS before the network frequency is elapsed currently the RSS-Thread is run over and over; we shouldn't stress our partrers to much, so we let the network poll frequency elaps before we try to poll the rss feed again. --- Summary of changes: citadel/modules/rssclient/serv_rssclient.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] Re: [SCM] citadel.org branch, master, updated. 84a2bfa29146319899d779c026bcf928abdfe712
ah. chackalacka. thats the way I wanted it to be. git config hooks.showrev "t=%s; printf 'http://code.citadel.org/cgitcgi/git.citadel.org/commit/?id=%%s' \$t; echo; git log \$t^..\$t; echo;" Mo Nov 01 2010 06:53:37 EDT von "dothebart" Betreff: [SCM] citadel.org branch, master, updated. 84a2bfa29146319899d779c026bcf928abdfe712 Push to the project "citadel.org ": The branch, master has been updated via 84a2bfa29146319899d779c026bcf928abdfe712 (commit) from 219f1d0a086a48e12cd07f9f0c0c6cdf978dfe34 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=84a2bfa29146319899d779c026bcf928abdfe712 commit 84a2bfa29146319899d779c026bcf928abdfe712 Author: Wilfried Goesgens Date: Mon Nov 1 11:48:23 2010 +0100 Blanks. --- Summary of changes: citadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] Re:
Di Okt 26 2010 18:48:29 EDT von IGnatius T Foobar @ Uncensored the tiny icon (14x14) is just the tower, the other two are the full logo scaled plus put into a matching square (as demanded by launchpad)I hope they're ok that way? Is it possible to fit at least the letter "C" into the tiny logo[Do? I would really prefer not to have the tower sitting by itself. You know ... brand dilution. hm, its 14 pixels , most probably not on the base line, but I may try. btw, a non-squared logo is one of the reasons why I didn't manage to let manufacture t-shirt-pins...
[Citadel Development] [SCM] citadel.org branch, master, updated. b9cdd103cc0e3a6dcb63f71e2026aa2fae4532f5
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "citadel.org ". The branch, master has been updated via b9cdd103cc0e3a6dcb63f71e2026aa2fae4532f5 (commit) from de3c9914925e8b047aa847bfdb2c3ab103aeeca9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit b9cdd103cc0e3a6dcb63f71e2026aa2fae4532f5 Author: Wilfried Goesgens Date: Wed Oct 27 00:13:49 2010 +0200 * blaahaaank --- Summary of changes: libcitadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] Re: [SCM] citadel.org branch, master, updated. 225dd04dbe1f36c04a8d62a32db6111d99d6ac70
better. no artificial line breaks. let the viewer handle linebreaks where appropriate. in other news: anouncing http://code.citadel.org/ our cgit installation. CIA anounced shorter URLs will point there, and match the right commit Mi Okt 27 2010 14:58:03 EDT von "ajc" Betreff: [SCM] citadel.org branch, master, updated. 225dd04dbe1f36c04a8d62a32db6111d99d6ac70 Push to the project "citadel.org ": The branch, master has been updated via 225dd04dbe1f36c04a8d62a32db6111d99d6ac70 (commit) from 1ff5766f84fac1d651d3fcb18cb500555f1ad302 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 225dd04dbe1f36c04a8d62a32db6111d99d6ac70 Author: Art Cancro Date: Wed Oct 27 14:53:46 2010 -0400 Added a little bit of clever _javascript_ to make the TinyMCE window occupy the full height of the browser window. --- Summary of changes: webcit/static/t/edit_message.html | 11 +-- webcit/static/t/richedit.html |4 +++- 2 files changed, 8 insertions(+), 7 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 20768166427ffb485877072bcafb1366e49aa1ed
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "citadel.org ". The branch, master has been updated via 20768166427ffb485877072bcafb1366e49aa1ed (commit) from 88652431d1a813753d2a9cacdbf8585f6b8f7dcd (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 20768166427ffb485877072bcafb1366e49aa1ed Author: Wilfried Goesgens Date: Wed Oct 27 00:43:08 2010 +0200 * blank. --- Summary of changes: libcitadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 225856d6c301bcb70d70fb4768107ea56fae6d75
Push to the project "citadel.org ": The branch, master has been updated via 225856d6c301bcb70d70fb4768107ea56fae6d75 (commit) from 225dd04dbe1f36c04a8d62a32db6111d99d6ac70 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 225856d6c301bcb70d70fb4768107ea56fae6d75 Author: Art Cancro Date: Wed Oct 27 15:03:06 2010 -0400 Moved the TinyMCE toolbar to the top of the editor window. --- Summary of changes: webcit/static/t/richedit.html |1 + 1 files changed, 1 insertions(+), 0 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 3e1cfd139f6e6fcabc3f8ef4e904d2d98193c76b
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "citadel.org ". The branch, master has been updated via 3e1cfd139f6e6fcabc3f8ef4e904d2d98193c76b (commit) from 20768166427ffb485877072bcafb1366e49aa1ed (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 3e1cfd139f6e6fcabc3f8ef4e904d2d98193c76b Author: Wilfried Goesgens Date: Wed Oct 27 00:47:20 2010 +0200 * blanx --- Summary of changes: libcitadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] Re: [SCM] citadel.org branch, master, updated. 015ce67f6ed15cd794e878058938bef6fcc69095
hmz, damn. full commit diff gone, link to cgit right, but no commit texts... *grml* Mo Nov 01 2010 05:44:11 EDT von "dothebart" Betreff: [SCM] citadel.org branch, master, updated. 015ce67f6ed15cd794e878058938bef6fcc69095 Push to the project "citadel.org ": The branch, master has been updated via 015ce67f6ed15cd794e878058938bef6fcc69095 (commit) from e5704e28c3be6d94b9e8f498ce66012f237fcf14 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=015ce67f6ed15cd794e878058938bef6fcc69095 --- Summary of changes: webcit/po/webcit/el.po | 31 +++ 1 files changed, 19 insertions(+), 12 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 219f1d0a086a48e12cd07f9f0c0c6cdf978dfe34
Push to the project "citadel.org ": The branch, master has been updated via 219f1d0a086a48e12cd07f9f0c0c6cdf978dfe34 (commit) from 61dfd0a5dafae371941f65149a2ec2f573ae20a7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=219f1d0a086a48e12cd07f9f0c0c6cdf978dfe34 --- Summary of changes: citadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 015ce67f6ed15cd794e878058938bef6fcc69095
Push to the project "citadel.org ": The branch, master has been updated via 015ce67f6ed15cd794e878058938bef6fcc69095 (commit) from e5704e28c3be6d94b9e8f498ce66012f237fcf14 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=015ce67f6ed15cd794e878058938bef6fcc69095 --- Summary of changes: webcit/po/webcit/el.po | 31 +++ 1 files changed, 19 insertions(+), 12 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. d5453f033f5328096c02836c6ad7dac3f2fdf6ec
Push to the project "citadel.org ": The branch, master has been updated via d5453f033f5328096c02836c6ad7dac3f2fdf6ec (commit) from 84a2bfa29146319899d779c026bcf928abdfe712 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=d5453f033f5328096c02836c6ad7dac3f2fdf6ec commit d5453f033f5328096c02836c6ad7dac3f2fdf6ec Author: Art Cancro Date: Mon Nov 1 13:23:03 2010 -0400 viewdefs is now boolean --- Summary of changes: webcit/blogview_renderer.c |3 ++- webcit/roomviews.c | 40 +++- 2 files changed, 21 insertions(+), 22 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. e30b88c12c6f3b062e1e46faa9b15ede1b899412
Push to the project "citadel.org ": The branch, master has been updated
via e30b88c12c6f3b062e1e46faa9b15ede1b899412 (commit)
from 225856d6c301bcb70d70fb4768107ea56fae6d75 (commit)
Those revisions listed above that are new to this repository have not appeared
on any other notification email; so we list those revisions in full, below.
- Log -
commit e30b88c12c6f3b062e1e46faa9b15ede1b899412
Author: Wilfried Goesgens
Date: Sat Oct 30 15:19:56 2010 +0200
Translation update to Launchpad #6
- add Greek
- add Svenska
- sort locale list
---
Summary of changes:
webcit/gettext.c | 11 ++--
webcit/po/webcit/de.po | 20 +++---
webcit/po/webcit/{en_GB.po => el.po} | 107 +-
webcit/po/webcit/{en_GB.po => sv.po} | 50 +++-
4 files changed, 92 insertions(+), 96 deletions(-)
copy webcit/po/webcit/{en_GB.po => el.po} (93%)
copy webcit/po/webcit/{en_GB.po => sv.po} (98%)
hooks/post-receive
--
citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. c9cf7593dbd2aade23bec479ab7299f50bb67298
Push to the project "citadel.org ": The branch, master has been updated via c9cf7593dbd2aade23bec479ab7299f50bb67298 (commit) from d5453f033f5328096c02836c6ad7dac3f2fdf6ec (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=c9cf7593dbd2aade23bec479ab7299f50bb67298 commit c9cf7593dbd2aade23bec479ab7299f50bb67298 Author: Art Cancro Date: Mon Nov 1 14:10:07 2010 -0400 Fixed the viewdefs code to handle the fact that enum 9 is now drafts and 10 is blogs. This fixes the select-o-matic thing. --- Summary of changes: webcit/roomviews.c | 45 ++--- 1 files changed, 26 insertions(+), 19 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. e155c0ab03b1dd135e594d991804df0f32b54a36
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "citadel.org ". The branch, master has been updated via e155c0ab03b1dd135e594d991804df0f32b54a36 (commit) via 039ec53b27084aa044f13a9888960d8542b27f9e (commit) via 6d35986867be48bfec571558f29dcca57bd172ab (commit) via f50501010c1315dd44972c9fdec634c8d8e96928 (commit) via b0e75f49b52705fd73ec9318c3748e5b42a0f147 (commit) via b5fe2c675ce450e62a6a9debe0147c11bb548030 (commit) via 0293bdf3780431dfcb548a25226f526bb735ac1f (commit) via 9552ae32b2ac66d4dbed6024edf2fa96325dc10e (commit) from 83b5cb2d05ca2efee0525315d5d0191b78b00b57 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit e155c0ab03b1dd135e594d991804df0f32b54a36 Author: Art Cancro Date: Tue Oct 26 18:51:36 2010 -0400 Don't output a space between imap namespaces (patch suggested by samjam to fix javamail errors) commit 039ec53b27084aa044f13a9888960d8542b27f9e Merge: 6d35986 83b5cb2 Author: Art Cancro Date: Tue Oct 26 18:50:55 2010 -0400 Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel commit 6d35986867be48bfec571558f29dcca57bd172ab Merge: f505010 cdafcac Author: Art Cancro Date: Tue Oct 26 17:40:48 2010 -0400 Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel commit f50501010c1315dd44972c9fdec634c8d8e96928 Merge: b0e75f4 6473900 Author: Art Cancro Date: Tue Oct 26 00:20:30 2010 -0400 Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel commit b0e75f49b52705fd73ec9318c3748e5b42a0f147 Author: Art Cancro Date: Tue Oct 26 00:17:37 2010 -0400 Numerous style changes to the 'edit message' dialog. The save, cancel, and address book buttons now occupy the navbar instead of a bunch of controls that shouldn't have been there anyway. I also fixed a javascript bug that was making the addressbook popup silently fail in the background if we were in a room that didn't require message recipients. The attachment dialog now sits above the message body pane, but this will soon get migrated into the navbar as well (maybe another popup). Finally, the background of the message entry div now more or less occupies the entire space available to it; this still needs more tuning in order to make the editor occupy the correct amount of space in the pane. commit b5fe2c675ce450e62a6a9debe0147c11bb548030 Merge: 0293bdf 0eca431 Author: Art Cancro Date: Mon Oct 25 15:47:33 2010 -0400 Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel commit 0293bdf3780431dfcb548a25226f526bb735ac1f Merge: 9552ae3 4749c0d Author: Art Cancro Date: Mon Oct 25 12:57:47 2010 -0400 Merge branch 'master' of ssh://git.citadel.org/appl/gitroot/citadel commit 9552ae32b2ac66d4dbed6024edf2fa96325dc10e Author: Art Cancro Date: Mon Oct 25 12:57:05 2010 -0400 The enter-message dialog is now contained by a div called '.entmsg' instead of '.message' ... duplicated the existing styles for now. --- Summary of changes: citadel/modules/imap/serv_imap.c |2 +- webcit/messages.c |4 +- webcit/static/styles/login.css|1 - webcit/static/styles/webcit.css | 47 + webcit/static/t/edit_message.html | 101 - webcit/static/t/login.html|6 +- 6 files changed, 95 insertions(+), 66 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 225dd04dbe1f36c04a8d62a32db6111d99d6ac70
Push to the project "citadel.org ": The branch, master has been updated via 225dd04dbe1f36c04a8d62a32db6111d99d6ac70 (commit) from 1ff5766f84fac1d651d3fcb18cb500555f1ad302 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 225dd04dbe1f36c04a8d62a32db6111d99d6ac70 Author: Art Cancro Date: Wed Oct 27 14:53:46 2010 -0400 Added a little bit of clever JavaScript to make the TinyMCE window occupy the full height of the browser window. --- Summary of changes: webcit/static/t/edit_message.html | 11 +-- webcit/static/t/richedit.html |4 +++- 2 files changed, 8 insertions(+), 7 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] Re: [SCM] citadel.org branch, master, updated. 20768166427ffb485877072bcafb1366e49aa1ed
Nice commit logs :)
[Citadel Development] Commit log to refs/heads/master
Files: a347d141fd25064f6ecacf7e28dcbd7e6f2b295c libcitadel/lib/html_to_ascii.c libcitadel/lib/libcitadel.h branches config description git-daemon-export-ok HEAD hooks info objects packed-refs refs make it const, not written anyways
[Citadel Development] [SCM] citadel.org branch, master, updated. b5ba428aeaa552fa2d23f0c76766cb302a28bc74
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "citadel.org ". The branch, master has been updated via b5ba428aeaa552fa2d23f0c76766cb302a28bc74 (commit) from cdafcac1fde3f5917a950730f3fd4e093a4a8f13 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit b5ba428aeaa552fa2d23f0c76766cb302a28bc74 Author: Wilfried Goesgens Date: Tue Oct 26 23:25:26 2010 +0200 * oh noes, thas blank wasn't that nice after all. --- Summary of changes: libcitadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 9d7d9f2126a5eb5ede7a89b2f659f2746df75757
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "citadel.org ". The branch, master has been updated via 9d7d9f2126a5eb5ede7a89b2f659f2746df75757 (commit) from b9cdd103cc0e3a6dcb63f71e2026aa2fae4532f5 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 9d7d9f2126a5eb5ede7a89b2f659f2746df75757 Author: Wilfried Goesgens Date: Wed Oct 27 00:29:07 2010 +0200 * blanks??? --- Summary of changes: libcitadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. d14c2c6ff9764e1a0bfa6aa231b57f9e14eaaefe
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "citadel.org ". The branch, master has been updated via d14c2c6ff9764e1a0bfa6aa231b57f9e14eaaefe (commit) from 9d7d9f2126a5eb5ede7a89b2f659f2746df75757 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit d14c2c6ff9764e1a0bfa6aa231b57f9e14eaaefe Author: Wilfried Goesgens Date: Wed Oct 27 00:30:57 2010 +0200 * Blanks! --- Summary of changes: libcitadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 88652431d1a813753d2a9cacdbf8585f6b8f7dcd
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "citadel.org ". The branch, master has been updated via 88652431d1a813753d2a9cacdbf8585f6b8f7dcd (commit) from 82e0a3b5b555f3a8039a2532a8555a4cda22916d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 88652431d1a813753d2a9cacdbf8585f6b8f7dcd Author: Wilfried Goesgens Date: Wed Oct 27 00:41:41 2010 +0200 blanx? --- Summary of changes: libcitadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. e5fb6126b96a1b966eee4eb957f7229d1b556906
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "citadel.org ". The branch, master has been updated via e5fb6126b96a1b966eee4eb957f7229d1b556906 (commit) from d14c2c6ff9764e1a0bfa6aa231b57f9e14eaaefe (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit e5fb6126b96a1b966eee4eb957f7229d1b556906 Author: Wilfried Goesgens Date: Wed Oct 27 00:31:42 2010 +0200 * bllannnks. --- Summary of changes: libcitadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 83b5cb2d05ca2efee0525315d5d0191b78b00b57
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "citadel.org ". The branch, master has been updated via 83b5cb2d05ca2efee0525315d5d0191b78b00b57 (commit) from 3e1cfd139f6e6fcabc3f8ef4e904d2d98193c76b (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 83b5cb2d05ca2efee0525315d5d0191b78b00b57 Author: Wilfried Goesgens Date: Wed Oct 27 00:51:19 2010 +0200 * blanks. --- Summary of changes: libcitadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. de3c9914925e8b047aa847bfdb2c3ab103aeeca9
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "citadel.org ". The branch, master has been updated via de3c9914925e8b047aa847bfdb2c3ab103aeeca9 (commit) from fc00227695e26cd96cfd047a8b0124fe87da777d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit de3c9914925e8b047aa847bfdb2c3ab103aeeca9 Author: Wilfried Goesgens Date: Wed Oct 27 00:07:08 2010 +0200 * o noes blanks? --- Summary of changes: libcitadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. 82e0a3b5b555f3a8039a2532a8555a4cda22916d
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "citadel.org ". The branch, master has been updated via 82e0a3b5b555f3a8039a2532a8555a4cda22916d (commit) from e5fb6126b96a1b966eee4eb957f7229d1b556906 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit 82e0a3b5b555f3a8039a2532a8555a4cda22916d Author: Wilfried Goesgens Date: Wed Oct 27 00:39:53 2010 +0200 blahangkx --- Summary of changes: libcitadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] [SCM] citadel.org branch, master, updated. fc00227695e26cd96cfd047a8b0124fe87da777d
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "citadel.org ". The branch, master has been updated via fc00227695e26cd96cfd047a8b0124fe87da777d (commit) from b5ba428aeaa552fa2d23f0c76766cb302a28bc74 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log - commit fc00227695e26cd96cfd047a8b0124fe87da777d Author: Wilfried Goesgens Date: Wed Oct 27 00:03:57 2010 +0200 oh, well, maybe a blank anyways here? --- Summary of changes: libcitadel/bootstrap |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) hooks/post-receive -- citadel.org
[Citadel Development] Commit log to refs/heads/master
Files: 957ff497e4bda041170e378e92191898fabb8ac5 webcit/po/webcit/it.po branches config description git-daemon-export-ok HEAD hooks info objects packed-refs refs fix format string as launchpad told us.
[Citadel Development] Commit log to refs/heads/master
Files: ea8649b108d8d60f9d84516e6a017d6710a835e1 libcitadel/lib/hash.c libcitadel/tests/hashlist_test.c branches config description git-daemon-export-ok HEAD hooks info objects packed-refs refs need to revalidate start in any case to be exact.
[Citadel Development] Re: Commit log to refs/heads/master
Mo Okt 25 2010 10:58:01 EDT von "Wilfried Goesgens" Betreff: Commit log to refs/heads/master Files: d9f66010689b4b008677c138f077b00e0f5f0be6 webcit/messages.c webcit/messages.h webcit/msg_renderers.c branches config description git-daemon-export-ok HEAD hooks info objects packed-refs refs Use new MSet-Matcher to retrieve seen state (10% of what we do in big mboxes) whew. cool. from 15.72 % down to 0.55 % in a similar usecase.
[Citadel Development] Commit log to refs/heads/master
Files: 25ff4aa2dc0584f271c073b03eb263cf359d9064 webcit/blogview_renderer.c Blog rendering continued...
[Citadel Development] (no subject)
i've scaled a little to create some logos for launchpad: https://launchpad.net/citadel/+branding the tiny icon (14x14) is just the tower, the other two are the full logo scaled plus put into a matching square (as demanded by launchpad) I hope they're ok that way? maybe we want a similar tower as favicon on citadel.org?
[Citadel Development] Commit log to refs/heads/master
Files: fb0d8eecfa90adf93309b8dde607a36603e7c4e6 webcit/static/t/edit_message.html "Subject:" and "Subject (optional):" were in the wrong places. Swapped them to the correct places.
[Citadel Development] Commit log to refs/heads/master
Files: 64739000c20cd3605c6a68efbea7227796ee6009 webcit/msg_renderers.c branches config description git-daemon-export-ok HEAD hooks info objects packed-refs refs ParseMessageListHeaders_Detail(): don't overuse StrLength, we can know its result from other calls, etc.
[Citadel Development] Commit log to refs/heads/master
Files: 7c9c6d9d8bbb254978f496e232dbef5e60bc321b citadel/po/citadel-setup/ru.po branches config description git-daemon-export-ok HEAD hooks info objects packed-refs refs fix quotation problem reported by launchpad (ups)
[Citadel Development] Commit log to refs/heads/master
Files: 903463a5983de644556f43dc1acc99e387036386 citadel/euidindex.c citadel/modules/expire/serv_expire.c citadel/room_ops.c citadel/user_ops.c Replaced some of the 'autoconverted - document me' strings
[Citadel Development] reviews pls.
as you might have seen, I've worked on moving our translations to launchpad, this has several advantages: * a ready made webinterface aiding translators -> no need to install local tools -> lowering the bar for non-technical persons to participate * the launchpad webinterface sugests similar strings from other translations * I've been told that there are people around 'just stopping by translating something..' * local tools possible via down/up-loads * technicaly launchpad carries a branch of our GIT repository in BZR, which polls upstream every 3 hours (or manually triggered via the launchpad webinterface) * launchpad translations follows that bzr branch, so new strings make it over * launchpad pushes translations to a bzr branch, (I still need to find the smartest way to move that over into upstream git) this is our article guiding our users there: http://www.citadel.org/doku.php/documentation:customize_webcit please everyone have a look at this whether there are logical errors, ill formulation, spelling errors and so on. I'd also like to have this article referenced in a more prominent space (maybe the sidebar?) IG, please make the 'citadel translators' room unpurgeable, and public accessible. We also should add the translators we already have back there.
