[Citadel Development] (null)

[UFarx]

 

Mon Jul 29 2024 22:23:51 EDT from IGnatius T Foobar 

please watch the progress in this room and test the build from git if you are willing. What C compiler are you using?


 sure and none of my patches are compiler specific. but if you're interested in a specific one, i have access to pretty much all compilers except for hp-ux's acc.

[Citadel Development] (null)

[UFarx]

and the last one:webcit's configure script does not use -liconv when checking for libcitadel. so if libcitadel was built with libiconv the check fails.i didn't patch that properly but just hardcoded -liconv. it would probably make sense to have 2 checks of which one tries with -liconv.

[Citadel Development] (null)

[UFarx]

the textclient's build system still has the same problems as i reported last year: http://uncensored.citadel.org/readfwd?go=Citadel%20Development?start_reading_at=2099353108#2099353108here is a patch for that.



textclient.patch.gz
Description: GNU Zip compressed data

[Citadel Development] (null)

[UFarx]

here is the patch to what i reported there: http://uncensored.citadel.org/readfwd?go=Citadel%20Support?start_reading_at=2099481915#2099481915



libcitadel_c99.patch.gz
Description: GNU Zip compressed data

[Citadel Development] (null)

[UFarx]

okay, putting html in the editor directly does not work :-Psecond try:
 

Sat Aug 19 2023 23:18:20 EDT from IGnatius T Foobar 

I ended up having to apply your changes manually.


ah sorry for that. i totally missed the attachment link above the reply frame. i only checked the editor icons. replacing the br tags with a real linebreak however should be good enough.
 

Sat Aug 19 2023 23:18:20 EDT from IGnatius T Foobar 

And thank you for the clarification about CPPFLAGS ... somehow after all these decades I never realized that CPP stood for "C PreProcessor" and not "C Plus Plus".


haha, my pleasure. and please delete my previous html post.

[Citadel Development] (null)

[UFarx]

Sat Aug 19 2023 23:18:20 EDT from IGnatius T Foobar I ended up having to apply your changes manually.ah sorry for that. i totally missed the attachment link above the reply frame. i only checked the editor icons.replacing the br tags with a real linebreak however should be good enough.Sat Aug 19 2023 23:18:20 EDT from IGnatius T Foobar And thank you for the clarification about CPPFLAGS ... somehow after all these decades I never realized that CPP stood for "C PreProcessor" and not "C Plus Plus".haha, my pleasure

[Citadel Development] (null)

[UFarx]

 

Tue Aug 15 2023 23:46:27 EDT from IGnatius T Foobar 

UFarx: the formatter messed up that patch, I think.


just remove the br tags

[Citadel Development] (null)

[UFarx]

here's the configure patch:

--- configure_O 2023-08-01 04:34:30.0 +0200 +++ configure 2023-08-11 23:58:52.0 +0200 @@ -7,7 +7,7 @@ # This program is open source software. Use, duplication, and/or # disclosure are subject to the GNU General Purpose License version 3.  -echo  +echo echo Running the configure script to create config.mk echo  @@ -39,7 +39,6 @@ shift done  -  # Set any missing values  @@ -50,10 +49,9 @@ # Configure the directory into which Citadel Server will be installed. [ "$CTDLDIR" = "" ] && CTDLDIR=/usr/local/citadel  -# Permit override of CFLAGS and LDFLAGS using environment variables -[ "$CFLAGS" = "" ] && CFLAGS='-ggdb' -[ "$LDFLAGS" = "" ] && LDFLAGS='' - +# Permit override of CPPLAGS and LDFLAGS using environment variables +[ "$CPPFLAGS" = "" ] && CPPFLAGS='' +[ "$LDFLAGS" = "" ] && LDFLAGS=''   # Test for OpenSSL @@ -68,7 +66,7 @@ exit(0); } ! -cc $tempcc -lssl -lcrypto -o $tempfile && $tempfile && { +$CC $CFLAGS $CPPFLAGS $tempcc -o $tempfile $LDFLAGS -lssl -lcrypto && $tempfile && { CFLAGS=${CFLAGS}' -DHAVE_OPENSSL' LDFLAGS=${LDFLAGS}' -lssl -lcrypto -lz' } || { @@ -76,7 +74,6 @@ exit 2 }  -  # Test for iconv  @@ -93,13 +90,12 @@ return(0); } ! - -cc $tempcc -o $tempfile && { +$CC $CFLAGS $CPPFLAGS $tempcc -o $tempfile && { ICONV='yes' echo iconv.h is present and requires no additional libraries } || { echo Trying again with -liconv... - cc $tempcc -liconv -o $tempfile && { + $CC $CFLAGS $CPPFLAGS $tempcc -o $tempfile $LDFLAGS -liconv && { ICONV='yes' LDFLAGS=${LDFLAGS}' -liconv' } || { @@ -108,21 +104,20 @@ } }  -  # The build ID can be generated from git or from the date  + CFLAGS=${CFLAGS}' -DBUILD_ID=\"'$(git describe 2>/dev/null || date +%y%03j)'\"' CFLAGS=${CFLAGS}' -DCTDLDIR=\"'${CTDLDIR}'\"'  -  # Output the config.mk  ( echo '# config.mk is generated by configure' echo "CTDLDIR := ${CTDLDIR}" - echo "CFLAGS := ${CFLAGS}" + echo "CFLAGS := ${CFLAGS} ${CPPFLAGS}" echo "LDFLAGS := ${LDFLAGS}" ) >config.mk   

i removed the hardcoded ggdb on purpose. people who want or need that can add it on their own.

[Citadel Development] (null)

[UFarx]

Fri Aug 11 2023 13:41:20 EDT from IGnatius T Foobar 
I'd be pleased to see that. Maybe just do one component first so we can see what it will look like.

sure, one at a time.

Fri Aug 11 2023 13:41:20 EDT from IGnatius T Foobar 
We try to make the build work cleanly on FreeBSD and Linux. There is no interest in testing on obsolete variants

sorted, no problem with cmake then.

Fri Aug 11 2023 14:36:40 EDT from LadySerenaKitty 
I also limit myself to only using CMake 3.3, which is the last version made for IRIX.

oh nice, irix was my main platform for many years :-)

[Citadel Development] (null)

[UFarx]

 

Thu Aug 10 2023 22:04:00 EDT from LadySerenaKitty 
I've never seen CMake be an issue for compatibility across multiple systems, and since it's a ready-made package for basically every OS

both is only true if you're dealing with:

rather recent os versions
mainstream systems

pure c programs like citadel are especially attractive for older and/or more exotic systems. making cmake mandatory would kill that advantage. looking at the citadel package itself, for which i proposed the changes, cmake would be overkill. with a little tuning like the things i suggested, it would be fine and remain highly compatible.
if that's welcome, i'm happy to beef things up a little without sacrificing any compatibility.

[Citadel Development] Re: Build System

[UFarx]

 

Thu Aug 10 2023 15:02:19 EDT from IGnatius T Foobar  Subject: Re: Build System

CPPFLAGS is not used anywhere because there is no C++ anywhere in the system. 


CPPFLAGS are not related to c++ but are preprocessor flags (like: -I/opt/something/include). c++ compiler options would be CXXFLAGS.
 
as for creating a patch, i would but if you wanna switch to cmake anyway it might not be necessary anymore. a word of caution though regarding cmake:
in many cases the problem with cmake is cmake itself because it has quite hefty compiler requirements. ironically often much more hefty than the actual program it's supposed to prepare. in case if citadel that would be such a case. so if compatibility is important to you, cmake is not a good choice.

[Citadel Development] (null)

[UFarx]

never mind. somebody moved it to the right room. these messages could actually be deleted.

[Citadel Development] Re: Build System

[UFarx]

i know, it was an accident. i actually was going to post there but logging in changed the current room.