[Citadel Development] Daily commit digest for Citadel

2023-05-24 Thread noreply


d57d06e80   Art Cancro  2023-05-23  ctdl3264: added diagnostics 
which revealed that CDB_VISIT is a hot mess and omg how did it ever work
c17e270f9   Art Cancro  2023-05-23  ctdl3264: fix zero length key 
in bigmsgs table
532d0f532   Art Cancro  2023-05-23  ctdl3264: skip zero length 
records, add more diagnostics


[Citadel Development] Daily commit digest for Citadel

2023-05-15 Thread noreply


3dec68a02   Art Cancro  2023-05-14  serv_imap.c 
(citserver)/roomops.c (webcit): bugfixes to message flag handling (Phil Slack)


[Citadel Development] Daily commit digest for Citadel

2023-05-05 Thread noreply


e9f3ccdaa   Art Cancro  2023-05-04  tools.c: bugfixes to trim 
functions (Phil Slack)
26d8b550c   Art Cancro  2023-05-04  sysdep.c: cprintf() truncation 
fix (Phil Slack)


[Citadel Development] Daily commit digest for Citadel

2023-05-03 Thread noreply


acabe560a   Art Cancro  2023-05-02  put_visit() no longer needs a 
separate function to generate its index.


[Citadel Development] Daily commit digest for Citadel

2023-05-02 Thread noreply


f341b886b   Art Cancro  2023-05-01  serv_inboxrules.c: applied 
patch by Allen (awrdgrs) to make X-Spam-Status work
0ef7d4c10   Art Cancro  2023-05-01  Apply patches sent by Harlow 
Solutions -- for WebCit
faf97c017   Art Cancro  2023-05-01  ctdl3264: write to target 
database
12360b52b   Art Cancro  2023-05-01  ctdl3264: src_dbenv and 
dst_dbenv are no longer global vars
c24ed8f01   Art Cancro  2023-05-01  ctdl3264: open_dbenv() and 
close_dbenv() move away from global vars


[Citadel Development] Daily commit digest for Citadel

2023-04-28 Thread noreply


389e6540f   Art Cancro  2023-04-27  We are no longer using the 
EXTAUTH table.
63b690ea8   Art Cancro  2023-04-27  do-release.sh: change citadel.h 
to citadel_defs.h
72bb6392b   Art Cancro  2023-04-27  Begin removing the EXTAUTH 
database


[Citadel Development] Daily commit digest for Citadel

2023-04-20 Thread noreply


365cc74af   Art Cancro  2023-04-19  Revert "citserver: remove 
openid support"
5e8be0dcc   Art Cancro  2023-04-19  citserver: remove openid support
2ab0b6bd6   Art Cancro  2023-04-19  zero out extauth in ctdl3264
cc300b8c0   Art Cancro  2023-04-19  convert config records
7b9371674   Art Cancro  2023-04-19  convert usersbynumber


[Citadel Development] Daily commit digest for Citadel

2023-04-19 Thread noreply


8f6e82c14   Art Cancro  2023-04-18  euid index convert


[Citadel Development] Daily commit digest for Citadel

2023-04-18 Thread noreply


86df91e20   Art Cancro  2023-04-17  Please excuse my friend, he 
isn't null terminated
28ab18db3   Art Cancro  2023-04-17  nice pretty banners
2d03ed0b3   Art Cancro  2023-04-17  fulltext uses same key and data 
format as msglists
d035348bf   Art Cancro  2023-04-17  log messages match and don't 
repeat for compressed
0193e1ee4   Art Cancro  2023-04-17  serv_fulltext.c: style update
a64257cc1   Art Cancro  2023-04-17  ctdl3264: straightened out the 
compression stuff


[Citadel Development] Daily commit digest for Citadel

2023-04-15 Thread noreply


898a23153   Art Cancro  2023-04-14  convert bigmsgs
ecfaa2cc6   Art Cancro  2023-04-14  IBM i , aka System/38 , really 
is dead , no matter how much they deny it.


[Citadel Development] Daily commit digest for Citadel

2023-04-14 Thread noreply


3bfcbbe74   Art Cancro  2023-04-13  convert directory entries
d4413bf5b   Art Cancro  2023-04-13  stuff and things
288bade0b   Art Cancro  2023-04-13  visit translation complete but 
we still need to compress it
bf1c50634   Art Cancro  2023-04-13  The data format used by 
GenerateRelationshipIndex() is now codified in the headers


[Citadel Development] Daily commit digest for Citadel

2023-04-13 Thread noreply


d4f6f4fe6   Art Cancro  2023-04-12  uncompress when necessary
9f736e867   Art Cancro  2023-04-12  die in a car fire
830bdfa1a   Art Cancro  2023-04-12  makefile tweaks
4adba5bd6   Art Cancro  2023-04-12  detect compressed records
c9bd94510   Art Cancro  2023-04-12  copying msglists done
0953f21fe   Art Cancro  2023-04-12  Don't log or rewrite records 
with zero length keys.


[Citadel Development] Daily commit digest for Citadel

2023-04-12 Thread noreply


e077e157f   Art Cancro  2023-04-11  convert floor records
84bdfebc5   Art Cancro  2023-04-11  convert next table


[Citadel Development] Daily commit digest for Citadel

2023-04-11 Thread noreply


279adb9fd   Art Cancro  2023-04-10  finished user import
1d111465a   Art Cancro  2023-04-10  I am a C programmer.  I am 
better than you.
147d40e7f   Art Cancro  2023-04-10  DBT in , DBT out
2beb7af57   Art Cancro  2023-04-10  make a note where we need to 
decompress
f8df371d7   Art Cancro  2023-04-10  figuring out db calling 
syntax...
827a52266   Art Cancro  2023-04-10  Added skeleton out_key and 
out_data
57c819a3a   Art Cancro  2023-04-10  Changed convert function 
calling syntax and variable names


[Citadel Development] Daily commit digest for Citadel

2023-04-08 Thread noreply


c293b8f97   Art Cancro  2023-04-07  parse metadata
625706585   Art Cancro  2023-04-07  learn about metadata 32
f362ad9d8   Art Cancro  2023-04-07  Abort if source database is not 
32-bit.


[Citadel Development] Daily commit digest for Citadel

2023-04-06 Thread noreply


1a7703f9b   Art Cancro  2023-04-05  If the msgnum is negative, we 
are looking at METADATA


[Citadel Development] Daily commit digest for Citadel

2023-04-01 Thread noreply


60d65df1d   Art Cancro  2023-03-31  more work on ctdl3264
eaf148c5f   Art Cancro  2023-03-31  ctdl3264: sooper seekrit 
command line flag to make it not fail


[Citadel Development] Daily commit digest for Citadel

2023-03-31 Thread noreply


4e6fdd795   Art Cancro  2023-03-30  ctdl3264: prepare for new things
5b8255a84   Art Cancro  2023-03-30  ctdl3264: tweaked a few things
246e35bdf   Art Cancro  2023-03-30  traverse the tables
951faf5a6   Art Cancro  2023-03-30  ctdl3264: open and close one 
table at a time
72dfaa2a1   Art Cancro  2023-03-30  `ctdl3264` is back and it's DRY


[Citadel Development] Daily commit digest for Citadel

2023-03-30 Thread noreply


041ba2e93   Art Cancro  2023-03-29  Restored `ctdl3264` but 
disabled it.


[Citadel Development] Daily commit digest for Citadel

2023-03-28 Thread noreply


0b618fa91   Art Cancro  2023-03-27  Banished the DarkSlateGrey 
color in dead-space screen regions.
7a567c871   Art Cancro  2023-03-27  Slimmed down some of the border 
elements.
31c0c0f34   Art Cancro  2023-03-27  color change


[Citadel Development] Daily commit digest for Citadel

2023-03-19 Thread noreply


cc7fcdfee   Art Cancro  2023-03-18  Changed the algorithm for quick 
queue runs to prevent weirdness


[Citadel Development] Daily commit digest for Citadel

2023-03-14 Thread noreply


21629e9bd   Art Cancro  2023-03-13  Don't send the rendered list to 
the console anymore.
5c92deb72   Art Cancro  2023-03-13  Activate mouse-up events on 
rooms in the mail folder list.
584c75534   Art Cancro  2023-03-13  Mailbox view: delete operation 
moves message to trash, unless we are already in the trash
26ca93d20   Art Cancro  2023-03-13  Learn from the Citadel Server 
whether a room is the user's trash folder.
744509a50   Art Cancro  2023-03-13  When a message is deleted in a 
mailbox room, move it to Trash instead of deleting


[Citadel Development] Daily commit digest for Citadel

2023-03-13 Thread noreply


cff70a055   Art Cancro  2023-03-12  Implemented an algorithm that 
can correctly divide by zero.


[Citadel Development] Daily commit digest for Citadel

2023-03-12 Thread noreply


30663e1a2   Art Cancro  2023-03-11  dav_move_or_copy_message() 
skeleton


[Citadel Development] Daily commit digest for Citadel

2023-03-10 Thread noreply


078ba6734   Art Cancro  2023-03-09  Inbox rules 'matches' operator 
now uses regular expressions.
aaef27a75   Art Cancro  2023-03-09  serv_inboxrules.c: compound 
fields such as From now work with substring match
0dadedcce   Art Cancro  2023-03-09  serv_inboxrules.c: style update


[Citadel Development] Daily commit digest for Citadel

2023-03-08 Thread noreply


867674135   Art Cancro  2023-03-07  rooms.c: style update
4aef1e005   Art Cancro  2023-03-07  license.txt: updated year
f11401fce   Art Cancro  2023-03-07  serv_instmsg.c: style update
cf08b6ff4   Art Cancro  2023-03-07  serv_image.c: style update


[Citadel Development] Daily commit digest for Citadel

2023-03-06 Thread noreply


4c6394e13   Art Cancro  2023-03-05  Release version 974 generated 
by do-release.sh
6e0b96608   Art Cancro  2023-03-05  Be a little less enthusiastic 
about calling abort()
2ca84ffe1   Art Cancro  2023-03-05  Preparing to implement MOVE and 
COPY methods
a387dce56   Art Cancro  2023-03-05  New class "ctdl-fatal-error" 
for big show-stopping banners.


[Citadel Development] Daily commit digest for Citadel

2023-03-05 Thread noreply


94e35e81a   Art Cancro  2023-03-04  More aggressive zeroing of 
visit records so they compress better


[Citadel Development] Daily commit digest for Citadel

2023-02-27 Thread noreply


5be25c3cf   Art Cancro  2023-02-26  more diagnostics
7899ae4eb   Art Cancro  2023-02-26  Release version 973 generated 
by do-release.sh
6b949aa0b   Art Cancro  2023-02-26  New command RBDI to ReBuild the 
Directory Index.


[Citadel Development] Daily commit digest for Citadel

2023-02-26 Thread noreply


4d5beb6ce   Art Cancro  2023-02-25  Removed ctdl3264 experiment.


[Citadel Development] Daily commit digest for Citadel

2023-02-19 Thread noreply


d144ba5e2   Art Cancro  2023-02-18  wtf


[Citadel Development] Daily commit digest for Citadel

2023-02-15 Thread noreply


296d48fa0   Art Cancro  2023-02-14  add total to purged use table 
records
e73dd3237   Art Cancro  2023-02-14  more convert
6409b7aa3   Art Cancro  2023-02-14  "visit" is now "struct visit" 
again.
a277559f3   Art Cancro  2023-02-14  cleaned up 32
bdd1f5236   Art Cancro  2023-02-14  reorganize the comments meow
aed5b8502   Art Cancro  2023-02-14  updated .gitignore
ead09e9d6   Art Cancro  2023-02-14  Experimental utility ctdl3264 
for database conversion (not finished)


[Citadel Development] Daily commit digest for Citadel

2023-02-13 Thread noreply


61e03c288   Art Cancro  2023-02-12  moved more defs from server.h 
to citadel_defs.h


[Citadel Development] Daily commit digest for Citadel

2023-02-12 Thread noreply


750ef561c   Art Cancro  2023-02-11  move stuff around
5e62c1bbe   Art Cancro  2023-02-11  citadel.h is now citadel_defs.h
549beeb7d   Art Cancro  2023-02-11  Moved  from citadel.h to 
server.h
f4caf74d8   Art Cancro  2023-02-11  Moved  from citadel.h to 
server.h
a96c8e2a9   Art Cancro  2023-02-11  Removed references to  as 
opposed to
36c3a1db8   Art Cancro  2023-02-11  Removed references to  as 
opposed to
bd68fbc42   Art Cancro  2023-02-11  moved  from citadel.h to 
server.h
758bd0537   Art Cancro  2023-02-11  server/control.c : style update


[Citadel Development] Daily commit digest for Citadel

2023-02-08 Thread noreply


aa2951f09   Art Cancro  2023-02-07  keep track of 
last_queue_job_submitted
6e3d819c1   Art Cancro  2023-02-07  give the smtp job queue an 
ability to do a quick or full run
84312c97a   Art Cancro  2023-02-07  Keep track of last queue 
message processed
197390f92   Art Cancro  2023-02-07  only throw a warning if 
housekeeping has not run in 60 minutes, not 5 minutes
e682ebc0f   Art Cancro  2023-02-07  quick spacing fix
61449cbf5   Art Cancro  2023-02-07  EVT_ hook numbers are now an 
enum
60ab62600   Art Cancro  2023-02-07  EVT_ types can certainly be 
enum now because there are no external builds.
fe1e24759   Art Cancro  2023-02-07  server.h began style c leanup
37f0c8964   Art Cancro  2023-02-07  comment change
2bd43f734   Art Cancro  2023-02-07  Wrap SMTP Client concurrency 
check in a mutex
36d7bb97b   Art Cancro  2023-02-07  Removed S_ mutex types no 
longer in use
94b836c09   Art Cancro  2023-02-07  made a couple of things more 
readable


[Citadel Development] Daily commit digest for Citadel

2023-01-31 Thread noreply


e1168df24   Art Cancro  2023-01-30  Some of the included doc files 
were already close to markdown-compliant.  Finished the job.


[Citadel Development] Daily commit digest for Citadel

2023-01-29 Thread noreply


8f26fe5bf   Art Cancro  2023-01-28  stylized ctdl_mail_folders


[Citadel Development] Daily commit digest for Citadel

2023-01-27 Thread noreply


9763bde20   Art Cancro  2023-01-26  Forum message editor classes
2cc50f1b5   Art Cancro  2023-01-26  INBOX _always_ appears at the 
top.
fa1ddf722   Art Cancro  2023-01-26  Use delete_dispatcher() as 
intended


[Citadel Development] Daily commit digest for Citadel

2023-01-25 Thread noreply


5e68c8104   Art Cancro  2023-01-24  don't double-close the client 
socket


[Citadel Development] Daily commit digest for Citadel

2023-01-15 Thread noreply


a3b023d44   Art Cancro  2023-01-14  Show mailboxes in a list, 
ordered by floor+rorder
7bbecca4c   Art Cancro  2023-01-14  Initial hack at mail folder list
2d02ac7dc   Art Cancro  2023-01-14  Label the ctdl_mail_folder_list 
for use


[Citadel Development] Daily commit digest for Citadel

2023-01-07 Thread noreply


073667627   Art Cancro  2023-01-06  Realign items on the banner bar.
33acf198d   Art Cancro  2023-01-06  RSS feed reader now QP-Encodes 
message text.
7d66c47a0   Art Cancro  2023-01-06  Rename 
StrBufRFC2047encodeMessage() to StrBufQuotedPrintableEncode()
2c960cf42   Art Cancro  2023-01-06  citadel.lock added to 
.gitignore and removed from git


[Citadel Development] Daily commit digest for Citadel

2023-01-06 Thread noreply


5f7076d9a   Art Cancro  2023-01-05  Bring back just our changes, 
revert accidental removal of files
8611acef7   Art Cancro  2023-01-05  Revert "serv_rssclient.c: style 
update"
76a0f8571   Art Cancro  2023-01-05  serv_rssclient.c: style update


[Citadel Development] Daily commit digest for Citadel

2023-01-03 Thread noreply


50511759c   Art Cancro  2023-01-02  more font size tweaks.
ce0e26bdc   Art Cancro  2023-01-02  Tweaks to font sizes


[Citadel Development] Daily commit digest for Citadel

2023-01-02 Thread noreply


66b89d024   Art Cancro  2023-01-01  Copyright notices updated to 
2023


[Citadel Development] Daily commit digest for Citadel

2022-12-29 Thread noreply


ecef3a9be   Art Cancro  2022-12-28  biff_interval is snake case not 
camel case


[Citadel Development] Daily commit digest for Citadel

2022-12-28 Thread noreply


b6d0c56ec   Art Cancro  2022-12-27  Remove color from syslog 
messages
3a7b2cbc9   Art Cancro  2022-12-27  Implement all calling 
functionality for Delete
cbca7a3fa   Art Cancro  2022-12-27  Detect "delete" key press
5ae6108d4   Art Cancro  2022-12-27  Collapsed two comments onto one 
line.
c3eca282c   Art Cancro  2022-12-27  optimize previous commit
febf98619   Art Cancro  2022-12-27  Handle null pointer correctly


[Citadel Development] Daily commit digest for Citadel

2022-12-27 Thread noreply


d6abb9afc   Art Cancro  2022-12-26  Multi select is now working 
with mailbox refresh.
a110c2149   Art Cancro  2022-12-26  Merge branch 'master' of 
ssh://git.citadel.org/var/www/gitroot/citadel
b225135b8   Art Cancro  2022-12-26  Implement multiselect in mailbox


[Citadel Development] Daily commit digest for Citadel

2022-12-23 Thread noreply


571e8443d   Art Cancro  2022-12-22  serv_openid_rp.c : style cleanup
f3468ae0b   Art Cancro  2022-12-22  serv_pop3client.c: style cleanup


[Citadel Development] Daily commit digest for Citadel

2022-12-18 Thread noreply


1a3bc9002   Art Cancro  2022-12-17  do-release.sh now obtains 
confirmation to proceed from the operator
8b3fd9acc   Art Cancro  2022-12-17  Merge branch 'master' of 
ssh://git.citadel.org/var/www/gitroot/citadel
6bf784a72   Art Cancro  2022-12-17  .gitignore core files


[Citadel Development] Daily commit digest for Citadel

2022-12-17 Thread noreply


7a1b725c7   Art Cancro  2022-12-16  build mods


[Citadel Development] Daily commit digest for Citadel

2022-12-16 Thread noreply


ba193b9c4   Art Cancro  2022-12-15  modernize serv_spam.c
b100daea9   Art Cancro  2022-12-15  Exit cleanly if citserver is 
running with a version of libdb older than the one with which it was compiled.


[Citadel Development] Daily commit digest for Citadel

2022-12-14 Thread noreply


c13dec1e4   Art Cancro  2022-12-13  do-release.sh is now being 
turned into more of a real pipeline
d69144aec   Art Cancro  2022-12-13  Release version 972 generated 
by do-release.sh
4c698e17e   Art Cancro  2022-12-13  Release version 971 generated 
by do-release.sh
939d60e43   Art Cancro  2022-12-13  Release version 970 generated 
by do-release.sh
581ca20b7   Art Cancro  2022-12-13  Release version 969 generated 
by do-release.sh
6378510b8   Art Cancro  2022-12-13  Release version 968 generated 
by do-release.sh
550ed0608   Art Cancro  2022-12-13  Release version 967 generated 
by do-release.sh
605230ef5   Art Cancro  2022-12-13  Release version 966 generated 
by do-release.sh
82cc13f18   Art Cancro  2022-12-13  Release version 965 generated 
by do-release.sh


[Citadel Development] Daily commit digest for Citadel

2022-12-13 Thread noreply


76873d6c5   Art Cancro  2022-12-12  Release version 964 generated 
by do-release.sh
a7a3f2b12   Art Cancro  2022-12-12  Release version 963 generated 
by do-release.sh


[Citadel Development] Daily commit digest for Citadel

2022-12-11 Thread noreply


e84f46b4f   Art Cancro  2022-12-10  Release version 962 generated 
by do-release.sh
db6ac9b35   Art Cancro  2022-12-10  Release version 961 generated 
by do-release.sh
4fdf1125e   Art Cancro  2022-12-10  Release version 960 generated 
by do-release.sh
ef74e4bed   Art Cancro  2022-12-10  imap_store.c style update


[Citadel Development] Daily commit digest for Citadel

2022-12-08 Thread noreply


16b92cdb3   Art Cancro  2022-12-07  Marc Crispin is dead so he 
can't make IMAP any more complex than it already is.


[Citadel Development] Daily commit digest for Citadel

2022-12-05 Thread noreply


0dffe1e63   Art Cancro  2022-12-04  Modify mailbox view to prepare 
for multi select


[Citadel Development] Daily commit digest for Citadel

2022-11-24 Thread noreply


0134c1a91   Art Cancro  2022-11-23  webcit-ng uses biff 
notifications now
61b00f502   Art Cancro  2022-11-23  MAKE WAY FOR BIFF in webcit-ng
0c8706708   Art Cancro  2022-11-23  GOTO no longer counts newly 
arrived mail in the inbox.  BIFF now does this.
a34ab2fe2   Art Cancro  2022-11-23  Replace striplt() with 
string_trim() in all the places VS Code simply decided not to.
039ccdbb1   Art Cancro  2022-11-23  stuff
20070c580   Art Cancro  2022-11-23  biff was here
3020ee4ef   Art Cancro  2022-11-23  Change CCC to CC in serv_rooms.c


[Citadel Development] Daily commit digest for Citadel

2022-11-20 Thread noreply


d1a25647c   Art Cancro  2022-11-19  Consistent calling syntax for 
view renderers
85f499d36   Art Cancro  2022-11-19  don't make me smack you
cf53e41f5   Art Cancro  2022-11-19  This is one way to notify about 
new mail
6957096b7   Art Cancro  2022-11-19  striplt() is now string_trim()
f45364a96   Art Cancro  2022-11-19  Colored left-borders on 
blockquotes for the win


[Citadel Development] Daily commit digest for Citadel

2022-11-12 Thread noreply


814f87c0f   Art Cancro  2022-11-11  Release version 959 generated 
by do-release.sh
105801284   Art Cancro  2022-11-11  array_delete_element_at() now 
uses memmove() instead of memcpy() because it is supposed to be safer.
8281f73d7   Art Cancro  2022-11-11  MAKE K&R CODING STYLE GREAT 
AGAIN!


[Citadel Development] Daily commit digest for Citadel

2022-11-10 Thread noreply


9eec53c70   Art Cancro  2022-11-09  variables in proper scope
3f39762ae   Art Cancro  2022-11-09  Variables in proper scope
5e6f201c8   Art Cancro  2022-11-09  Sending now works because HTML 
entities are unescaped in the metadata.
28c9012d1   Art Cancro  2022-11-09  war on old style


[Citadel Development] Daily commit digest for Citadel

2022-11-07 Thread noreply


d72c8680f   Art Cancro  2022-11-06  Make the CC: line appear if 
there is already something in it.
b88f8054b   Art Cancro  2022-11-06  More logic for To: and Cc: in 
reply-all


[Citadel Development] Daily commit digest for Citadel

2022-11-06 Thread noreply


0ae67a3c1   Art Cancro  2022-11-05  Rename msgnum to quoted_msgnum 
to make its purpose clear


[Citadel Development] Daily commit digest for Citadel

2022-11-03 Thread noreply


a8c8dd24e   Art Cancro  2022-11-02  Display To: and Cc: properly
e6e552b0c   Art Cancro  2022-11-02  "rcpt" and "" fields are 
now delivered as json arrays
f98c994ef   Art Cancro  2022-11-02  Removed support for 
...bang!paths and user%node1@node2 syntaxes


[Citadel Development] Daily commit digest for Citadel

2022-10-30 Thread noreply


5151485fd   Art Cancro  2022-10-29  Accept environment CFLAGS and 
LDFLAGS


[Citadel Development] Daily commit digest for Citadel

2022-10-27 Thread noreply


9106a3867   Art Cancro  2022-10-26  "Reply" works.  "Reply-All" 
needs more work.


[Citadel Development] Daily commit digest for Citadel

2022-10-26 Thread noreply


commit 8190b693159a09aed2ec91accc653f677e6d0450
Author: Art Cancro 
Date:   Tue Oct 25 23:33:03 2022 -0400

Pass the subject to the reply

commit 2352dc30c074739244acefa61e6fcd7e01b250e0
Author: Art Cancro 
Date:   Tue Oct 25 23:30:42 2022 -0400

to, cc, subject in mail_compose()

commit 4e732609e9cc6e93cb7c36d87775a86e14cd9f8d
Author: Art Cancro 
Date:   Tue Oct 25 23:22:23 2022 -0400

The icon for "Send message" is now a paper airplane instead of a check mark.


[Citadel Development] Daily commit digest for Citadel

2022-10-25 Thread noreply



This is a test.  If it works, daily commit digests will post if the number of 
commits for a
24 hour period is higher than zero.  If there are no commits there will be no 
message.