[Citadel Development] Re: [SCM] citadel.org branch, master, updated. a629da83391d58813cc962f6c52d991868b10e3a

[dothebart]

 

Di Nov 16 2010 10:57:38 EST von   IGnatius T Foobar @ Uncensored  Betreff: Re: [SCM] citadel.org branch, master, updated. a629da83391d58813cc962f6c52d991868b10e3a

Yes, everything is done using safestrncpy()  


ok, error introduced by hacking in screen+vi ;) sorry for the inconvenience.
another problem i'm facing is, that webcit won't abort the accept()s blocking workers, so they, and their respective memory isn't freed which causes lots of false positives making work with valgrind hard :(
i've tried removing the freopen() from the signalhandler, and use close instead of fclose & fflush, no change.

[Citadel Development] Re: [SCM] citadel.org branch, master, updated. a629da83391d58813cc962f6c52d991868b10e3a

[IGnatius T Foobar]

Yes, everything is done using safestrncpy() 
 

[Citadel Development] Re: [SCM] citadel.org branch, master, updated. a629da83391d58813cc962f6c52d991868b10e3a

[dothebart]

 

Di Nov 16 2010 10:51:03 EST von   IGnatius T Foobar @ Uncensored  Betreff: Re: [SCM] citadel.org branch, master, updated. a629da83391d58813cc962f6c52d991868b10e3a


IG, could you have a look at this? why does the mentioned pointer   contain invalid data instead of NULL? could you clean that up?   
*facepalm*  char event_jid[256];  It's an actual buffer, not a pointer.  It didn't need to be freed in the first place.  


aww. *gna*
do the copy operations protect it from overflowing?

[Citadel Development] Re: [SCM] citadel.org branch, master, updated. a629da83391d58813cc962f6c52d991868b10e3a

[IGnatius T Foobar]

 >IG, could you have a look at this? why does the mentioned pointer  
 >contain invalid data instead of NULL? could you clean that up?  
  
 *facepalm* 
  
 char event_jid[256]; 
  
 It's an actual buffer, not a pointer.  It didn't need to be freed in the
first place. 
 

[Citadel Development] Re: [SCM] citadel.org branch, master, updated. a629da83391d58813cc962f6c52d991868b10e3a

[dothebart]

 

So Nov 14 2010 22:26:44 EST von   IGnatius T Foobar @ Uncensored  Betreff: Re: [SCM] citadel.org branch, master, updated. a629da83391d58813cc962f6c52d991868b10e3a


IG, could you have a look at this? why does the mentioned pointer   contain invalid data instead of NULL? could you clean that up?   
Which pointer are we talking about here?  


#if 0// TODO: why do we have an invalid pointer here? if (ptr->event_jid != NULL) free(ptr->event_jid);#endif
that one.

[Citadel Development] Re: [SCM] citadel.org branch, master, updated. a629da83391d58813cc962f6c52d991868b10e3a

[IGnatius T Foobar]

 >IG, could you have a look at this? why does the mentioned pointer  
 >contain invalid data instead of NULL? could you clean that up?  
  
 Which pointer are we talking about here? 
 

[Citadel Development] Re: [SCM] citadel.org branch, master, updated. a629da83391d58813cc962f6c52d991868b10e3a

[dothebart]

 

Sun Nov 14 2010 17:16:49 EST from  "dothebart"   Subject: [SCM] citadel.org branch, master, updated. a629da83391d58813cc962f6c52d991868b10e3a
http://code.citadel.org/cgit.cgi/git.citadel.org/commit/?id=1bca8e52ac5e6713c26867195fffed2e49861f0e commit 1bca8e52ac5e6713c26867195fffed2e49861f0e Author: Wilfried Goesgens  Date:   Sun Nov 14 23:11:40 2010 +0100  Memleak: free the XMPP-Eventqueue on shutdown  TODO: the event_jid member contains an unclean pointer, no clue why.   ---  Summary of changes: citadel/modules/xmpp/serv_xmpp.c   |4 +++- citadel/modules/xmpp/xmpp_queue.c  |   21 + 11 files changed, 97 insertions(+), 3 deletions(-)   --  citadel.org  

IG, could you have a look at this? why does the mentioned pointer contain invalid data instead of NULL? could you clean that up?