Re: [ros-dev] [ros-diffs] [akhaldi] 48236: Create a branch for cmake bringup.

2010-07-25 Thread Olaf Siejka
Anything that will bring more efficiency into trunk as well as remove
unused/dead code is worthy of time. Not to mention that trunk gets bigger
with almost every day whereas both official and my buildbot machines are not
getting faster.

My motion would be cleaning up http://svn.reactos.org/svn/reactos/trunk/ so
it contains only code buildable by ROSBE. Right now it is trunk,tests and
apps but would get bigger if we modularize trunk and move code around.

By accomplishing that we can make buildbot setup more precize, by setting
svn scheduler to this directory, being sure that only buildable code will
trigger the build. At the moment we have a tough choice between limiting
ourselves only to ros main tree in
http://svn.reactos.org/svn/reactos/trunk/reactos or allow changes to
documentation, irc, rosdocs, tools and wallpaper directories trigger the
build as well. It ends up in heavy hacking if you want trunk+rostests
only...

2010/7/25 Ged Murphy gedmur...@gmail.com

 This may be a good time to restructure the tree?
 http://www.reactos.org/wiki/Techwiki:File_Layout

 This will make ros much more modular and allow things like minwin to be
 built.

 Ged.

 On 24 July 2010 19:52, akha...@svn.reactos.org wrote:

 Author: akhaldi
 Date: Sat Jul 24 18:52:44 2010
 New Revision: 48236

 URL: http://svn.reactos.org/svn/reactos?rev=48236view=rev
 Log:
 Create a branch for cmake bringup.

 Added:
branches/cmake-bringup/   (props changed)
  - copied from r48235, trunk/reactos/

 Propchange: branches/cmake-bringup/

 --
 --- bugtraq:logregex (added)
 +++ bugtraq:logregex Sat Jul 24 18:52:44 2010
 @@ -1,0 +1,2 @@
 +([Ii]ssue|[Bb]ug)s? #?(\d+)(,? ?#?(\d+))*(,? ?(and |or )?#?(\d+))?
 +(\d+)

 Propchange: branches/cmake-bringup/

 --
bugtraq:message = See issue #%BUGID% for more details.

 Propchange: branches/cmake-bringup/

 --
bugtraq:url = http://www.reactos.org/bugzilla/show_bug.cgi?id=%BUGID%

 Propchange: branches/cmake-bringup/

 --
 --- svn:ignore (added)
 +++ svn:ignore Sat Jul 24 18:52:44 2010
 @@ -1,0 +1,14 @@
 +*.iso
 +makefile.auto
 +makefile-*.auto
 +config-*.rbuild
 +obj-*
 +output-*
 +reactos
 +reactos.*
 +RosBE-Logs
 +*.sln
 +*.ncb
 +*.suo
 +versionreport.xml
 +config.rbuild

 Propchange: branches/cmake-bringup/

 --
 --- svn:mergeinfo (added)
 +++ svn:mergeinfo Sat Jul 24 18:52:44 2010
 @@ -1,0 +1,4 @@
 +/branches/header-work:45691-47721
 +/branches/reactos-yarotows:46372,46848,46966,47800,48026,48064
 +/branches/ros-amd64-bringup:36852

 +/branches/ros-amd64-bringup/reactos:34711-34712,34741,34743,34770,34780-34782,34803,34812,34839,34842,34864,34870,34874,34877,34908-34909,34917,34965,35323-35324,35347-35348,35361,35436,35509,35515,35588,35655,35683,35739,35746,35762,35771,35777,35781,35789,35805,35823,35827,35902,35904-35906,35942,35947-35949,35952-35953,35966,36011-36013,36172,36360,36380,36388-36389,36393,36397,36445,36475,36502-36503,36505,36570,36614,36852,36898-36899,36930,36936,36949,36951,36958,36961,36964,36969,36972,36987-36988,36990,36992,37019,37322-37323,37333-37334,37434,37472,37475,37536,37820-37821,37868-37869,37873,37990-37991,38013-38014,38092,38100,38148-38151,38264-38265,38268,38355,39151,39333,39335,39345,39639,40120,40122-40123,40125,40127-40128,40155,40247,40324,40608,40753,40926-40928,40986-40987,40989,40991,40993,40995-40996,41000-41001,41027-41030,41044-41045,41047-41050,41052,41070,41082-41086,41097-41098,41101,41449,41479-41480,41484-41485,41499-41500,41502,41531,41536,41540,41546-41547,41549,43080,43426,43451,43454,43506,43566,43574,43598,43600-43602,43604-43605,43677,43682,43757,43775,43836,43838-43840,43852,43857-43858,43860,43905-43907,43952,43954,43965,43969,43979,43981,43992,44002,44036-44037,44039-44040,44044-44045,44053,44065,44095,44123,44143-44144,44205,44238,44257,44259,44294,44338-44339,44385,44389,44391,44426,44460,44467-44468,44470-44471,44499,44501,44503-44504,44506,44510-44512,44521,44523-44526,44530,44540,44601,44634,44639,44772,44818,45124,45126-45127,45430,46394,46404,46478,46511,46523-46524,46526,46534-46535,46537-46539,46589,46805,46868,47472,47846-47847,47878,47882

 Propchange: branches/cmake-bringup/

 --
tsvn:logminsize = 10




 ___
 Ros-dev mailing list
 Ros-dev@reactos.org
 http://www.reactos.org/mailman/listinfo/ros-dev

___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [akhaldi] 48236: Create a branch for cmake bringup.

2010-07-25 Thread Zachary Gorden
I also support a reshuffling of the directories, but not in the cmake
branch.  Let that be used JUST for getting cmake up and running and if/once
that is merged into trunk, then we look into changing the structure.  Best
not to complicate one task by adding more to it.
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [akhaldi] 48236: Create a branch for cmake bringup.

2010-07-25 Thread Jérôme Gardou

wasn't there already a branch for that task?

Zachary Gorden wrote:
I also support a reshuffling of the directories, but not in the cmake 
branch.  Let that be used JUST for getting cmake up and running and 
if/once that is merged into trunk, then we look into changing the 
structure.  Best not to complicate one task by adding more to it.



___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev



___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev


Re: [ros-dev] [ros-diffs] [akhaldi] 48236: Create a branch forcmake bringup.

2010-07-25 Thread Aleksey Bragin
Yes, there is no sense in doing two mainly unrelated very big tasks 
simulteneously. Also my own opinion still hasn't changed - existing layout is 
quite logical (there are exceptions, but they are everywhere), and any 
modularization could be achieved already with existing tools like sysgen.

Let cmake branch be actual cmake experiment, not an awesome attempt to fix 
whole ReactOS at once 

WBR,
Aleksey Bragin.



From: Zachary Gorden 
Sent: Sunday, July 25, 2010 9:45 PM
To: ReactOS Development List 
Subject: Re: [ros-dev] [ros-diffs] [akhaldi] 48236: Create a branch forcmake 
bringup.


I also support a reshuffling of the directories, but not in the cmake branch.  
Let that be used JUST for getting cmake up and running and if/once that is 
merged into trunk, then we look into changing the structure.  Best not to 
complicate one task by adding more to it.






___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-devEmoticon1.gif___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [akhaldi] 48236: Create a branch forcmake bringup.

2010-07-25 Thread Zachary Gorden
Do you have any specific proposals, Ged?
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev