Re: [ros-dev] NTFS in ReactOS: heise online article
Dear Thomas, This source of such article is a post from reboot.pro (http://reboot.pro/topic/20149-ntfs-now-supported-in-reactos-livecd/) where I report this progress and ask for help. On ReactOS website, you don't have such strong report, but the piece of information exists, spread in various places. People started talking about it on boards a few days ago. You have a short report about it in the latest ReactOS developer meeting minutes (https://www.reactos.org/node/909). And finally, the commits made on NTFS where kind of explicit about the progresses (coming along with pictures: https://git.reactos.org/?p=reactos.git&a=search&h=HEAD&st=commit&s=[NTFS]). Note that the 0.3.17 release has initial, but not full (release process was started before everything could be developed) NTFS support. Testing from trunk is then the preferred method. Cheers, On 06/11/2014 05:57, Thomas Mueller wrote: > I saw an article on heise online (German-language website) > http://www.heise.de/newsticker/ > on > ReactOS liest NTFS > http://www.heise.de/newsticker/meldung/ReactOS-liest-NTFS-2442615.html > > Date is 05.11.2014, meaning just yesterday. > > I subsequently looked on reactos.org and couldn't find any reference to this > article. > > So far, this is only for reading NTFS on ReactOS; writing ability stil has to > be worked on. > > This is the first article I've seen on this subject: looks like progress. > > Some ReactOS developers must be familiar with this? > > Tom > > > ___ > Ros-dev mailing list > Ros-dev@reactos.org > http://www.reactos.org/mailman/listinfo/ros-dev > -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. smime.p7s Description: S/MIME Cryptographic Signature ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
[ros-dev] NTFS in ReactOS: heise online article
I saw an article on heise online (German-language website) http://www.heise.de/newsticker/ on ReactOS liest NTFS http://www.heise.de/newsticker/meldung/ReactOS-liest-NTFS-2442615.html Date is 05.11.2014, meaning just yesterday. I subsequently looked on reactos.org and couldn't find any reference to this article. So far, this is only for reading NTFS on ReactOS; writing ability stil has to be worked on. This is the first article I've seen on this subject: looks like progress. Some ReactOS developers must be familiar with this? Tom ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [tfaber] 65269: [FASTFAT] - VfatCleanupFile: do not dereference the FCB when closing the volume file object. ObDereferenceObject already causes an IRP_MJ_CLOSE request to be
I agree there shouldn't have any dereference during cleanup. But, this is actually fixing the leak in renaming process (only happens). That one is pretty hard to track. Jérôme and I had bad moments on that one. This leak doesn't happen in normal working of the FSD, but only in renaming operations. Fixing it would likely fix most (all?) of the renaming issues. On 05/11/2014 20:53, Thomas Faber wrote: > Oh... Jérôme, I only just saw that you added this in r65140... > And my change does break the msi tests again. :\ > > Any idea what's going wrong here? > I'm relatively certain my change is correct because > vfatFCBInitializeCacheFromVolume takes one reference, and VfatCloseFile > invoked via ObDereferenceObject will remove that reference again. > > So apparently we're leaking a directory reference somewhere else? :( > Not sure if your previous investigation into this issue can provide any > pointers. Otherwise I'll have to start digging for the leak all over > again... > > Thanks. > -Thomas > > > On 2014-11-05 19:52, tfa...@svn.reactos.org wrote: >> --- trunk/reactos/drivers/filesystems/fastfat/cleanup.c [iso-8859-1] >> (original) >> +++ trunk/reactos/drivers/filesystems/fastfat/cleanup.c [iso-8859-1] >> Wed Nov 5 18:52:11 2014 >> @@ -92,7 +92,6 @@ >> pFcb->FileObject = NULL; >> CcUninitializeCacheMap(tmpFileObject, NULL, NULL); >> ObDereferenceObject(tmpFileObject); >> -vfatReleaseFCB(IrpContext->DeviceExt, pFcb); >> } >> >> CcPurgeCacheSection(FileObject->SectionObjectPointer, NULL, 0, >> FALSE); >> >> -- Pierre Schweitzer System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. smime.p7s Description: S/MIME Cryptographic Signature ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [ros-diffs] [tfaber] 65269: [FASTFAT] - VfatCleanupFile: do not dereference the FCB when closing the volume file object. ObDereferenceObject already causes an IRP_MJ_CLOSE request to be
Oh... Jérôme, I only just saw that you added this in r65140... And my change does break the msi tests again. :\ Any idea what's going wrong here? I'm relatively certain my change is correct because vfatFCBInitializeCacheFromVolume takes one reference, and VfatCloseFile invoked via ObDereferenceObject will remove that reference again. So apparently we're leaking a directory reference somewhere else? :( Not sure if your previous investigation into this issue can provide any pointers. Otherwise I'll have to start digging for the leak all over again... Thanks. -Thomas On 2014-11-05 19:52, tfa...@svn.reactos.org wrote: > --- trunk/reactos/drivers/filesystems/fastfat/cleanup.c [iso-8859-1] > (original) > +++ trunk/reactos/drivers/filesystems/fastfat/cleanup.c [iso-8859-1] > Wed Nov 5 18:52:11 2014 > @@ -92,7 +92,6 @@ > pFcb->FileObject = NULL; > CcUninitializeCacheMap(tmpFileObject, NULL, NULL); > ObDereferenceObject(tmpFileObject); > -vfatReleaseFCB(IrpContext->DeviceExt, pFcb); > } > > CcPurgeCacheSection(FileObject->SectionObjectPointer, NULL, 0, > FALSE); > > ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
