Re: [ros-dev] [ros-diffs] [spetreolle] 72905: [NtUser] Turn an ERR into a TRACE.

2016-10-06 Thread James Tabor
Thank you!

This is the cheapest way to know if an application is locked up in paint.
Breaking into debug sometimes helps, but it might break into some other
place except the message loop.

On Wed, Oct 5, 2016 at 3:50 AM, Sylvain Petreolle 
wrote:

> Hello Jim.
> I did not read it as a failure path in your code.
> I reverted my change.
>
> Kind regards, Sylvain Petreolle
>
>
> Le Mercredi 5 octobre 2016 0h32, James Tabor 
> a écrit :
>
>
> Now we will never know what happen to the lost application!
>
>
> ___
> Ros-dev mailing list
> Ros-dev@reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>
>
> ___
> Ros-dev mailing list
> Ros-dev@reactos.org
> http://www.reactos.org/mailman/listinfo/ros-dev
>
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] [ros-diffs] [hbelusca] 72922: [KD] - When enabling or disabling the kernel debugger and setting the KdDebuggerEnabled flag, also update the corresponding user-mode flag in SharedUserData

2016-10-06 Thread Pierre Schweitzer
Le 06/10/2016 à 21:01, hbelu...@svn.reactos.org a écrit :
> Author: hbelusca
> Date: Thu Oct  6 19:01:33 2016
> New Revision: 72922
> 
> URL: http://svn.reactos.org/svn/reactos?rev=72922&view=rev
> Log:
> [KD]
> - When enabling or disabling the kernel debugger and setting the 
> KdDebuggerEnabled flag, also update the corresponding user-mode flag in 
> SharedUserData->KdDebuggerEnabled.
> - Turn KdpGetMemorySizeInMBs into a INIT_FUNCTION.
> - Print kernel command line & ARC paths even in debug log file mode.
> 
> [KD64]
> WinKD: Also print our nice ReactOS debug header (version, # of processors & 
> memory MB, kernel command line and ARC paths).
> 
> Modified:
> trunk/reactos/ntoskrnl/kd/kdinit.c
> trunk/reactos/ntoskrnl/kd/kdio.c
> trunk/reactos/ntoskrnl/kd/kdmain.c
> trunk/reactos/ntoskrnl/kd64/kdapi.c
> trunk/reactos/ntoskrnl/kd64/kdinit.c
> 
> Modified: trunk/reactos/ntoskrnl/kd/kdio.c
> URL: 
> http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/kdio.c?rev=72922&r1=72921&r2=72922&view=diff
> ==
> --- trunk/reactos/ntoskrnl/kd/kdio.c  [iso-8859-1] (original)
> +++ trunk/reactos/ntoskrnl/kd/kdio.c  [iso-8859-1] Thu Oct  6 19:01:33 2016
> @@ -240,10 +243,15 @@
>  KeInitializeSpinLock(&KdpDebugLogSpinLock);
>  
>  /* Display separator + ReactOS version at start of the debug log */
> -
> DPRINT1("---\n");
> +DPRINT1("-\n");

This specific change has likely broken any testbot running sysreg2 and
vmware or vbox.
Why was this change even needed?


-- 
Pierre Schweitzer 
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.



smime.p7s
Description: Signature cryptographique S/MIME
___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev

Re: [ros-dev] MSVC and GCC Windows Buildslaves are back - old ISOs are not

2016-10-06 Thread Colin Finck
Am 05.10.2016 um 19:48 schrieb Christoph von Wittich:
> What about deduplication?

We would need to test if this yields any good results on our already
compressed data. Even if we extract the currently 7zip-compressed ISOs,
the "reactos.cab" inside the ISOs would still be a compressed file.

What deduplication solution do you suggest anyway? ZFS?


- Colin

___
Ros-dev mailing list
Ros-dev@reactos.org
http://www.reactos.org/mailman/listinfo/ros-dev