Re: [ros-dev] [project-tools] Revision 1363: [ROSBE-UNIX] Implement support for pre-build post-build hook scripts in RosBE-Unix.
In addition, is the Apache license even GPL compatible? If not ReactOS won't be able to use it. (to be honest, I just hate GPL software which uses GPL when unnecessary, but in cases like duplicating Windows technologies, it may prove to be an advantage, but I would have thought Sleepycat would be better than the horrific sham of a free license that is the GPL - of course that is an opinion of mine) On Sat, 28 Jan 2012 23:30:11 +0100 Colin Finck co...@reactos.org wrote: pschweit...@svn.reactos.org wrote: touch boot/bootdata/packages/reactos.dff.in We can't put this one-liner into the CMakeLists.txt file? execute_process should do the job if there is no touch command in CMake itself. Your change makes RosBE depend on a very specific file in a very specific path of the source tree (= tree change only possible with an updated RosBE). In addition, these hooks separate the build logic between CMake and RosBE and pave the way for even more source tree dependent changes in RosBE. I like to avoid this. - Colin ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [project-tools] Revision 1363: [ROSBE-UNIX] Implement support for pre-build post-build hook scripts in RosBE-Unix.
Oh woops... please ignore that message in the thread... I intended to send it to a different thread. Apologies for inconveniences! On Wed, 1 Feb 2012 14:50:00 + Adam geekdun...@gmail.com wrote: In addition, is the Apache license even GPL compatible? If not ReactOS won't be able to use it. (to be honest, I just hate GPL software which uses GPL when unnecessary, but in cases like duplicating Windows technologies, it may prove to be an advantage, but I would have thought Sleepycat would be better than the horrific sham of a free license that is the GPL - of course that is an opinion of mine) On Sat, 28 Jan 2012 23:30:11 +0100 Colin Finck co...@reactos.org wrote: pschweit...@svn.reactos.org wrote: touch boot/bootdata/packages/reactos.dff.in We can't put this one-liner into the CMakeLists.txt file? execute_process should do the job if there is no touch command in CMake itself. Your change makes RosBE depend on a very specific file in a very specific path of the source tree (= tree change only possible with an updated RosBE). In addition, these hooks separate the build logic between CMake and RosBE and pave the way for even more source tree dependent changes in RosBE. I like to avoid this. - Colin ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [project-tools] Revision 1363: [ROSBE-UNIX] Implement support for pre-build post-build hook scripts in RosBE-Unix.
Le 28/01/2012 23:30, Colin Finck a écrit : pschweit...@svn.reactos.org wrote: touch boot/bootdata/packages/reactos.dff.in We can't put this one-liner into the CMakeLists.txt file? execute_process should do the job if there is no touch command in CMake itself. Your change makes RosBE depend on a very specific file in a very specific path of the source tree (= tree change only possible with an updated RosBE). In addition, these hooks separate the build logic between CMake and RosBE and pave the way for even more source tree dependent changes in RosBE. I like to avoid this. - Colin ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev I don't know why this is needed at all, but in cmake files you can use cmake -E touch for portability (windows have no default touch afaik) ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
Re: [ros-dev] [project-tools] Revision 1363: [ROSBE-UNIX] Implement support for pre-build post-build hook scripts in RosBE-Unix.
pschweit...@svn.reactos.org wrote: touch boot/bootdata/packages/reactos.dff.in We can't put this one-liner into the CMakeLists.txt file? execute_process should do the job if there is no touch command in CMake itself. Your change makes RosBE depend on a very specific file in a very specific path of the source tree (= tree change only possible with an updated RosBE). In addition, these hooks separate the build logic between CMake and RosBE and pave the way for even more source tree dependent changes in RosBE. I like to avoid this. - Colin ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev
