Hi,
On Tue, Feb 05, 2008 at 04:18:28PM -0500, John Siracusa wrote:
On Feb 5, 2008 4:06 PM, Grzegorz Nosek [EMAIL PROTECTED] wrote:
t/db-objectok 1/566# Looks like you planned 566
tests but only ran 562.
Whoops, that should be fixed now.
Yup, it is. You're fast :)
sql_qualify_columns_on_load is on by default. Actually, it looks
hardcoded to one ($self-{...} || 1 will always be true). I assume
that's for testing
Yes, it's just for testing. It will be off by default (as per the docs :)
Hmm, I might be missing something, but inside the
sql_qualify_columns_on_load method you're using $_[1] after shifting
$self off the argument array, so to set the value to true, I must pass
two arguments to the method, i.e.:
__PACKAGE__-meta-sql_qualify_column_names_on_load(1, 1);
However, regardless of the setting, the columns are always qualified as
t1.*, even though calling sql_qualify_column_names_on_load without arguments
returns undef.
It also happens after explicitely calling sql_qualify_column_names(0, 0).
Not that *I* complain, of course :)
Are you releasing a new version soon?
Probably tomorrow, after some more testing.
OK, so I'll wait before upgrading my production version. BTW, I set up
postgres credentials so that 'make test' can use them and got failures
on the new tests (stderr output attached).
Best regards,
Grzegorz Nosek
# Failed test 'sql_qualify_column_names_on_load() 1 - pg'
# in t/db-object.t at line 63.
# got: 'SELECT rose_db_object_test.name, rose_db_object_test.code,
rose_db_object_test.id, rose_db_object_test.k1, rose_db_object_test.k2,
rose_db_object_test.k3, rose_db_object_test.flag, rose_db_object_test.flag2,
rose_db_object_test.status, rose_db_object_test.start,
rose_db_object_test.save, rose_db_object_test.nums, rose_db_object_test.bitz,
rose_db_object_test.decs, rose_db_object_test.dur, rose_db_object_test.epoch,
rose_db_object_test.hiepoch, rose_db_object_test.bint1,
rose_db_object_test.bint2, rose_db_object_test.bint3,
rose_db_object_test.bint4, rose_db_object_test.tee_time,
rose_db_object_test.tee_time0, rose_db_object_test.tee_time5,
rose_db_object_test.tee_time9, rose_db_object_test.date_created,
rose_db_object_test.last_modified FROM rose_db_object_test WHERE
rose_db_object_test.id = ?'
# expected: 'SELECT rose_db_object_test.name, rose_db_object_test.code,
rose_db_object_test.id, rose_db_object_test.k1, rose_db_object_test.k2,
rose_db_object_test.k3, rose_db_object_test.passwd, rose_db_object_test.flag,
rose_db_object_test.flag2, rose_db_object_test.status,
rose_db_object_test.start, rose_db_object_test.save, rose_db_object_test.nums,
rose_db_object_test.bitz, rose_db_object_test.decs, rose_db_object_test.dur,
rose_db_object_test.epoch, rose_db_object_test.hiepoch,
rose_db_object_test.bint1, rose_db_object_test.bint2,
rose_db_object_test.bint3, rose_db_object_test.bint4,
rose_db_object_test.tee_time, rose_db_object_test.tee_time0,
rose_db_object_test.tee_time5, rose_db_object_test.tee_time9,
rose_db_object_test.date_created, rose_db_object_test.last_modified FROM
rose_db_object_test WHERE rose_db_object_test.id = ?'
# Failed test 'sql_qualify_column_names_on_load() 2 - pg'
# in t/db-object.t at line 67.
# got: 'SELECT rose_db_object_test.name, rose_db_object_test.code,
rose_db_object_test.id, rose_db_object_test.k1, rose_db_object_test.k3,
rose_db_object_test.flag, rose_db_object_test.flag2,
rose_db_object_test.status, rose_db_object_test.save, rose_db_object_test.nums,
rose_db_object_test.bitz, rose_db_object_test.decs, rose_db_object_test.dur,
rose_db_object_test.epoch, rose_db_object_test.hiepoch,
rose_db_object_test.bint1, rose_db_object_test.bint2,
rose_db_object_test.bint3, rose_db_object_test.bint4,
rose_db_object_test.tee_time, rose_db_object_test.tee_time0,
rose_db_object_test.tee_time5, rose_db_object_test.tee_time9,
rose_db_object_test.date_created, rose_db_object_test.last_modified FROM
rose_db_object_test WHERE rose_db_object_test.id = ?'
# expected: 'SELECT rose_db_object_test.name, rose_db_object_test.code,
rose_db_object_test.id, rose_db_object_test.k1, rose_db_object_test.k3,
rose_db_object_test.passwd, rose_db_object_test.flag,
rose_db_object_test.flag2, rose_db_object_test.status,
rose_db_object_test.save, rose_db_object_test.nums, rose_db_object_test.bitz,
rose_db_object_test.decs, rose_db_object_test.dur, rose_db_object_test.epoch,
rose_db_object_test.hiepoch, rose_db_object_test.bint1,
rose_db_object_test.bint2, rose_db_object_test.bint3,
rose_db_object_test.bint4, rose_db_object_test.tee_time,
rose_db_object_test.tee_time0, rose_db_object_test.tee_time5,
rose_db_object_test.tee_time9, rose_db_object_test.date_created,
rose_db_object_test.last_modified FROM rose_db_object_test WHERE
rose_db_object_test.id = ?'
# Failed test 'sql_qualify_column_names_on_load() 3 - pg'
# in t/db-object.t at line 71.
# got:
