Re: new DISTEPOCH tag and cleaning of RELEASE tag polution
On Saturday 20 of December 2008, Per Øyvind Karlsen wrote:
> I've modified DISTTAG tag to be specified in macros file just like
> DISTRIBUTION, VENDOR etc.
> and commited it to CVS already.
> Here's my next step, a DISTEPOCH tag where distribution version can be
> added.
>
> This will change EVR to EVRD which will be represented as
> %{EPOCH}:%{VERSION}-%{RELEASE}:%{DISTEPOCH}, ie. 1:2.3.4-5:2009.1.
In PLD this won't fly because
1:2.3.4-5 in "new" devel version of distro can be newer than
1:2.3.4-7 in "old" still maintained one.
(versioning is separate for each line)
For now in such case -5 would be bumped to something bigger than in "old"
version manually.
> Regards,
> Per Øyvind
--
Arkadiusz MiśkiewiczPLD/Linux Team
arekm / maven.plhttp://ftp.pld-linux.org/
__
RPM Package Managerhttp://rpm5.org
Developer Communication Listrpm-devel@rpm5.org
Re: [CVS] RPM: rpm/ configure.ac
2008/12/20 Anders F Björklund > Per Øyvind Karlsen wrote: > > Modified files: >> rpm configure.ac >> >> Log: >> unbreak build, by changing from error to warning >> >> > Fix errors in stead!! >> > > The coding errors are fixable either way (warning/error), > but this gets rid of the build failures with GCC < 4.3 : > > cc1: error: unrecognized command line option "-Werror=format-security" > > It's possible that configure could need another option > like --enable-build-error to add -Werror to the CFLAGS ? I'd rather not, too many warnings about stuff not too important too fix when building with --enable-build-warnings. Passing -Werror is anyways quite a trivial thing to do too.. :)
Re: [CVS] RPM: rpm/ configure.ac
Per Øyvind Karlsen wrote: Modified files: rpm configure.ac Log: unbreak build, by changing from error to warning Fix errors in stead!! The coding errors are fixable either way (warning/error), but this gets rid of the build failures with GCC < 4.3 : cc1: error: unrecognized command line option "-Werror=format-security" It's possible that configure could need another option like --enable-build-error to add -Werror to the CFLAGS ? --anders __ RPM Package Managerhttp://rpm5.org Developer Communication Listrpm-devel@rpm5.org
Re: [CVS] RPM: rpm/ configure.ac
2008/12/20 Anders F. Björklund > RPM Package Manager, CVS Repository > http://rpm5.org/cvs/ > > > > Server: rpm5.org Name: Anders F. Björklund > Root: /v/rpm/cvs Email: a...@rpm5.org > Module: rpm Date: 20-Dec-2008 11:01:52 > Branch: HEAD Handle: 2008122010015100 > > Modified files: >rpm configure.ac > > Log: >unbreak build, by changing from error to warning > > Summary: >RevisionChanges Path >2.331 +1 -1 rpm/configure.ac > > > > patch -p0 <<'@@ .' > Index: rpm/configure.ac > > > $ cvs diff -u -r2.330 -r2.331 configure.ac > --- rpm/configure.ac 20 Dec 2008 02:27:12 - 2.330 > +++ rpm/configure.ac 20 Dec 2008 10:01:51 - 2.331 > @@ -155,7 +155,7 @@ > if test ".$enableval" = .yes; then > if test ".`$CC --version 2>&1 | grep 'GCC'`" != .; then > dnl # GNU GCC (usually "gcc") > -CFLAGS="$CFLAGS -Wall -W -Wpointer-arith -Wstrict-prototypes > -Wmissing-prototypes -Wno-char-subscripts -Wno-missing-field-initializers > -Wno-unused-parameter -Werror=format-security" > +CFLAGS="$CFLAGS -Wall -W -Wpointer-arith -Wstrict-prototypes > -Wmissing-prototypes -Wno-char-subscripts -Wno-missing-field-initializers > -Wno-unused-parameter -Wformat-security" > elif test ".`$CC -V 2>&1 | grep 'Sun C'`" != .; then > dnl # Sun Studio (usually "cc") > CFLAGS="$CFLAGS -v" > @@ . > __ > RPM Package Managerhttp://rpm5.org > CVS Sources Repositoryrpm-...@rpm5.org > Fix errors in stead!!
Re: [CVS] RPM: rpm/lib/ fsm.c
2008/12/20 Ralf S. Engelschall > > On Sat, Dec 20, 2008, Per Øyvind Karlsen wrote: > > > [...] > > fsm.c: In function 'fsmMapFContext': > > fsm.c:772: warning: unused variable > > 'st' > > > > This one? > > Yes, exactly! > > > I get it on linux as well, but I never figured out why it complained > > about st being unused since it seemingly did get used two lines below, > > but my ignorance prolly' can't really debate much with technical > > details.. > > > > Could you clarify on why? :) > > The point is that the variable is used on the matchpathcon() "function > call" only. But matchpathcon() is a _macro_ which is defined only for > Linux's SELINUX situation. On non-Linux (or as in your case, Linux > but not SELINUX-enabled platform) the matchpathcon() macro expands to > nothing which in turn leads to the "unused variable" situation. Ah, no SELINUX here, so I guess that explains things then. :)
Re: [CVS] RPM: rpm/lib/ fsm.c
On Sat, Dec 20, 2008, Per Øyvind Karlsen wrote: > [...] > fsm.c: In function 'fsmMapFContext': > fsm.c:772: warning: unused variable > 'st' > > This one? Yes, exactly! > I get it on linux as well, but I never figured out why it complained > about st being unused since it seemingly did get used two lines below, > but my ignorance prolly' can't really debate much with technical > details.. > > Could you clarify on why? :) The point is that the variable is used on the matchpathcon() "function call" only. But matchpathcon() is a _macro_ which is defined only for Linux's SELINUX situation. On non-Linux (or as in your case, Linux but not SELINUX-enabled platform) the matchpathcon() macro expands to nothing which in turn leads to the "unused variable" situation. Ralf S. Engelschall r...@engelschall.com www.engelschall.com __ RPM Package Managerhttp://rpm5.org Developer Communication Listrpm-devel@rpm5.org
Re: [CVS] RPM: rpm/lib/ fsm.c
2008/12/20 Ralf S. Engelschall
> RPM Package Manager, CVS Repository
> http://rpm5.org/cvs/
>
>
>
> Server: rpm5.org Name: Ralf S. Engelschall
> Root: /v/rpm/cvs Email: r...@rpm5.org
> Module: rpm Date: 20-Dec-2008 09:09:47
> Branch: HEAD Handle: 2008122008094700
>
> Modified files:
>rpm/lib fsm.c
>
> Log:
>get rid of one more compile-time warning under non-Linux systems
>
> Summary:
>RevisionChanges Path
>2.180 +1 -2 rpm/lib/fsm.c
>
>
>
> patch -p0 <<'@@ .'
> Index: rpm/lib/fsm.c
>
>
> $ cvs diff -u -r2.179 -r2.180 fsm.c
> --- rpm/lib/fsm.c 13 Dec 2008 20:37:56 - 2.179
> +++ rpm/lib/fsm.c 20 Dec 2008 08:09:47 - 2.180
> @@ -769,9 +769,8 @@
> {
> fsm->fcontext = NULL;
> if (!fsm->nofcontexts) {
> - struct stat * st = &fsm->sb;
>security_context_t scon = NULL;
> - int xx = matchpathcon(fsm->path, st->st_mode, &scon);
> + int xx = matchpathcon(fsm->path, fsm->sb.st_mode, &scon);
>
> /*...@-moduncon@*/
>if (!xx && scon != NULL)
> @@ .
> __
> RPM Package Managerhttp://rpm5.org
> CVS Sources Repositoryrpm-...@rpm5.org
>
fsm.c: In function 'fsmMapFContext':
fsm.c:772: warning: unused variable
'st'
This one?
I get it on linux as well, but I never figured out why it complained about
st being
unused since it seemingly did get used two lines below, but my ignorance
prolly' can't really debate much with technical details..
Could you clarify on why? :)
