[Rpm-maint] [rpm-software-management/rpm] '#' symbol to ignore a macro statement does not valid. (#121)
We sometime use "#" symbol to append some contents in ./spec file. This issue
describes incorrect operation of "#" symbol in case that we try to ignore a
macro line (e.g. %define . . . ) in ./spec file. For example, the '#' (hash
character) symbol to invalidate a macro statement does not valid as following:
* It's not okay. # symbole is not available even though we try to use "#"
symbol.
```
# %define __debug_install_post%{nil}
# %define debug_package %{nil}
```
* It's okay if I remove specified lines:
```
-%define __debug_install_post%{nil}
-%define debug_package %{nil}
```
* It's okay if I remove "%" symbol behine "#" symbol:
```
-# define __debug_install_post%{nil}
-# define debug_package %{nil}
```
* Reference: http://rpm5.org/docs/api/macros.html
Recenlty, I have found an instruction to solve this issue from the Fedora
documentation webpage as following:
https://docs.fedoraproject.org/en-US/Fedora_Draft_Documentation/0.1/html/Packagers_Guide/chap-Packagers_Guide-Spec_File_Reference-Comments.html
**Instruction**: Because macros are expanded first, do not insert any multiline
macros in a comment. If you want to comment out a line with a macro, double the
percent signs (%%) as in the following example:
`# %%configure`
Does we always have to use double percent sign? My question is why we cannot
use a single percent sign? Anyone that has a similar experiecne like me?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/121___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] '#' symbol to ignore a macro statement does not valid. (#121)
\CC: @pmatilai, @ffesti, @ignatenkobrain, @myungjoo , @hk57kim , @jyoungyun -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/121#issuecomment-271807885___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] '#' symbol to ignore a macro statement does not valid. (#121)
Closed #121. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/121#event-918754747___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] '#' symbol to ignore a macro statement does not valid. (#121)
I dont see what more there is to explain. Macros are expanded everywhere including what appear to be comments in spec. If you need to escape it to avoid expansion then double percent (%%) is the way to do it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/121#issuecomment-271810454___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] regression: specifying "%_gpg_name First Last " does not work (#120)
That's strange. I'm not able to reproduce that, and it doesn't seem to be about actual length either since my name is longer and I always had this in my ~/.rpmmacros: `%_gpg_name Panu Matilainen ` What version of rpm, gpg and what distro are you using? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/120#issuecomment-271825876___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] regression: specifying "%_gpg_name First Last " does not work (#120)
Okay, this is actually a bug in pinentry, see https://bugs.gnupg.org/gnupg/issue2452 With that info I can also reproduce the behavior by forcing an empty environment: ``` error: gpg exec failed (2) [pmatilai@sopuli rpm]$ cp ~/Downloads/xfce4-terminal-0.8.2-2.fc25.x86_64.rpm /tmp/; env -i HOME=/home/pmatilai ./rpmsign --addsign /tmp/xfce4-terminal-0.8.2-2.fc25.x86_64.rpm /tmp/xfce4-terminal-0.8.2-2.fc25.x86_64.rpm: gpg: signing failed: Line passed to IPC too long gpg: signing failed: Line passed to IPC too long error: gpg exec failed (2) [pmatilai@sopuli rpm]$ ``` The error occurs if neither DISPLAY or TERM is set in the environment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/120#issuecomment-271833257___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] regression: specifying "%_gpg_name First Last " does not work (#120)
OTOH the pinentry bug doesn't explain behavior change with different %_gpg_name value. Can you reproduce the problem if you explicity set TERM to something, eg `TERM=xterm rpm --addsign ./grub2-2.02-0.38.fc25.dusty.x86_64.rpm` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/120#issuecomment-271835591___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)
My issue with this is that it adds an option that is by definition only relevant to a single "backend" of %autosetup, and the most uninteresting one at that. I'm all for supporting backups for plain patch, doing them was actually always part of the plan only never implemented. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/110#issuecomment-271865352___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)
So actually I think this is best handled by having two separate backends (similar to git and git_am) where one creates backups and the other one doesn't. That way there's no need to introduce new option that is specific to one backend only. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/110#issuecomment-271870713___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)
@pmatilai so you'd want instead a `-S patchbackup` backend instead of using `-B` at `%autosetup`/`%autopatch`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/110#issuecomment-271871045___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)
Yup. Or actually the other way around: have the default "patch" version create backups because that's more in line with the other backends, and add another backend like patch_nobackup (gosh I hate that name) for the no-backup case. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/110#issuecomment-271871761___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)
@pmatilai I'm tempted to not modify the default backend because of reasons mentioned by @soig and @ignatenkobrain in #109. But let me see what I can do about introducing an alternative backend that creates patch backups. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/110#issuecomment-271872239___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)
I dont see any *real* reasons against backups by default here. The default should be the most useful one, and the way I see it for those living with gendiff for one reason or another backups are a must. In my experience the only reason NOT to create backups is stupid (often perl) projects which don't know what files they own and as a consequence install those backups as well. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/110#issuecomment-271873980___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)
pmatilai requested changes on this pull request. I'm actually in favor of enabling backups by default. However this patch clearly hasn't been tested, nor reviewed, at all. It refers to a non-existent patches_num variable so any attempt to use %autosetup with this patch ends up in: `error: lua script failed: [string ""]:4: attempt to index a nil value (global 'patches_num')` -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/109#pullrequestreview-16144566___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)
pmatilai requested changes on this pull request. I'm actually in favor of enabling backups by default. However this patch clearly hasn't been tested, nor reviewed, at all. It refers to a non-existent patches_num variable so any attempt to use %autosetup with this patch ends up in: `error: lua script failed: [string ""]:4: attempt to index a nil value (global 'patches_num')` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/110#pullrequestreview-16144876___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] regression: specifying "%_gpg_name First Last " does not work (#120)
hey @pmatilai - i'm using fedora 24 with: ``` $ rpm -q rpm rpm-sign gnupg2 gnupg rpm-4.13.0-1.fc24.x86_64 rpm-sign-4.13.0-1.fc24.x86_64 gnupg2-2.1.13-2.fc24.x86_64 gnupg-1.4.21-1.fc24.x86_64 ``` my DISPLAY variable is unset but my `TERM` is `screen-256color`. What is odd that I am trying to reproduce today in the very same terminal that I was having the problem in the other day (I can see the output in the scrollback) and the "in terminal" text based popup is now coming up and asking me for my password. I'm not sure what the problem is/was. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/120#issuecomment-271880706___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Support optionally creating backup files with %autopatch or %autosetup (#110)
I am not user of %auto{patch,setup} but I hate the backup files around. I
really don't see any reason for their existence. And I saw quite some packages
shipping them accidentally ...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/110#issuecomment-271899559___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] When using %autopatch, create backup files with .~ suffix by def… (#109)
I only tested the macros against a patched mageia rpm, where 'patches_num' existed, that's why I missed it.. Fixed now. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/109#issuecomment-271957340___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
I've added most of the helper scripts, there's a few remaining and some I'll have to consider whether to kill off in stead before done. Anyways, I'm making a preliminary pull request as a request for comments. Notice how all these scripts can either be disabled by setting an environment variable or defining a rpm variable in contrast to the existing brp-* scripts. As this has been an absolute necessity to disable some of these for some packages in cooker, I really think these should be kept, also equivalent disablers added for the existing brp- scripts invoked as well.. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/122 -- Commit Summary -- * add helper script for automatically cleaning backup files from buildroot * add brp script for removing any /usr/share/info/dir files created * add helper script for automatically relativizing symlinks in buildroot * add helper script for removing libtool .la files from buildroot * add brp script for automatically converting DOS to UNIX style EOL * add brp script for removing standard search paths from rpaths * add brp script for enforcing correct permissions for certain files * add brp script for automatically fixing non-XDG compliant .desktop files * add brp script for trimming slashes from pkgconfig variables -- File Changes -- M platform.in (9) M scripts/Makefile.am (6) A scripts/brp-clean-files (37) A scripts/brp-fix-eol (16) A scripts/brp-fix-file-permissions (33) A scripts/brp-fix-pkgconfig (27) A scripts/brp-fix-xdg (17) A scripts/brp-relink-symlinks (30) A scripts/brp-remove-info-dir (15) A scripts/brp-remove-libtool-files (14) A scripts/brp-remove-rpath (49) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/122.patch https://github.com/rpm-software-management/rpm/pull/122.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/122 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
ignatenkobrain commented on this pull request.
> @@ -70,6 +70,15 @@
%{_rpmconfigdir}/brp-strip %{__strip} \
%{_rpmconfigdir}/brp-strip-static-archive %{__strip} \
%{_rpmconfigdir}/brp-strip-comment-note %{__strip} %{__objdump} \
+%{?!dont_clean_files: [ -n "$DONT_CLEANUP" ] ||
%{_rpmconfigdir}/brp-clean-files} \
+%{?!dont_remove_info_dir: [ -n "$DONT_REMOVE_INFO_DIR" ] ||
%{_rpmconfigdir}/brp-remove-info-dir} \
+%{?!dont_relink: [ -n "$DONT_RELINK" ] ||
%{_rpmconfigdir}/brp-relink-symlinks} \
+%{?!dont_remove_libtool_files: [ -n "$DONT_REMOVE_LIBTOOL_FILES" ] ||
%{_rpmconfigdir}/brp-remove-libtool-files} \
+%{?!dont_fix_eol: [ -n "$DONT_FIX_EOL" ] ||
%{_rpmconfigdir}/brp-fix-eol} \
love this one ;) was fixingsuch things all the time manually ;)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122#pullrequestreview-16233847___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
ignatenkobrain commented on this pull request.
> @@ -0,0 +1,15 @@
+#!/bin/sh
+
+# If using normal root, avoid changing anything.
+if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then
+ exit 0
+fi
+
+INFODIR=`rpm --eval %{_infodir}/dir`
+
+dir="$RPM_BUILD_ROOT/$INFODIR"
+
+if [ -f $dir -a ! -f "$RPM_BUILD_ROOT/sbin/install-info" -a ! -f
"$RPM_BUILD_ROOT/usr/sbin/install-info" ]; then
not sure what/why this one shoud do...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122#pullrequestreview-16234194___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
ignatenkobrain commented on this pull request. > @@ -0,0 +1,14 @@ +#!/bin/sh + +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +find "$RPM_BUILD_ROOT" \( -type f -o -type l \) -name \*.la -print0 | nice one ;) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/122#pullrequestreview-16234244___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
ignatenkobrain commented on this pull request. > @@ -0,0 +1,49 @@ +#!/bin/sh + +# This script makes sure to remove any standard library search paths from rpath +# or runpath tags as they're not only redundant, but will break overriding +# search paths. Search paths of the tag that's not standard will be kept intact. + +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +# make sure we have chrpath in our search path, otherwise wuzz out +type chrpath || exit 0 wondering how people are using this brp it's nice one, but you don't know in advance if built thing will contain rpaths or not.. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/122#pullrequestreview-16234564___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
proyvind commented on this pull request. > @@ -0,0 +1,49 @@ +#!/bin/sh + +# This script makes sure to remove any standard library search paths from rpath +# or runpath tags as they're not only redundant, but will break overriding +# search paths. Search paths of the tag that's not standard will be kept intact. + +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +# make sure we have chrpath in our search path, otherwise wuzz out +type chrpath || exit 0 It'll only check whether binaries contains a RPATH or RUNPATH tag after finishing %install, so no need to know in advance. As it pulls in a dependency on chrpath which might not be desired/available to have installed by default in build environment, it'll just wuzz out without checking nor fixing anything. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/122___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
proyvind commented on this pull request.
> @@ -0,0 +1,15 @@
+#!/bin/sh
+
+# If using normal root, avoid changing anything.
+if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then
+ exit 0
+fi
+
+INFODIR=`rpm --eval %{_infodir}/dir`
+
+dir="$RPM_BUILD_ROOT/$INFODIR"
+
+if [ -f $dir -a ! -f "$RPM_BUILD_ROOT/sbin/install-info" -a ! -f
"$RPM_BUILD_ROOT/usr/sbin/install-info" ]; then
Some 'make install' rules uses 'install-info' to install info pages into
install destination.
When installing info pages using 'install-info', it'll also register the info
page in /usr/share/info/dir, for which in a clean buildroot doesn't exist and a
new /usr/share/info/dir file with the info page entry gets created.
So this ensures that no /usr/share/info/dir ends up in package, conflicting
with existing system /usr/share/info/dir
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/122___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
@proyvind pushed 1 commit. a469648 add brp script for automatically creating library symlinks using ldconfig -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/122/files/93d90c03d7d02512689376c7a1c025cedf8d8763..a469648632ba9dbc7ae1000c40e9b5ed8f2c423d ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
@proyvind pushed 1 commit. 0d496d8 add brp script to check elf files for unresolved symbols and unused libs -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/122/files/a469648632ba9dbc7ae1000c40e9b5ed8f2c423d..0d496d8a6469a13a96d8143c6096405b18d7a0fd ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
@proyvind pushed 1 commit. 12e9521 add disabler for brp-compress -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/122/files/0d496d8a6469a13a96d8143c6096405b18d7a0fd..12e95217f0f83dbf19c031862946f2ae7216c3d0 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
@proyvind pushed 1 commit. 83620a8 fix incorrect file name for brp-check-elf-files -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/122/files/12e95217f0f83dbf19c031862946f2ae7216c3d0..83620a85e7b4ddd01a737b9e5beafcffd28a53e8 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
ldv-alt commented on this pull request. Well, this is very primitive. To get an idea how a real brp-elf checker can look like see e.g. http://git.altlinux.org/gears/r/..git?p=rpm-build.git;a=blob;f=scripts/verify-elf.in and its control brp script http://git.altlinux.org/gears/r/..git?p=rpm-build.git;a=blob;f=scripts/brp-verify_elf.in -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/122#pullrequestreview-16280596___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
ldv-alt requested changes on this pull request. > @@ -0,0 +1,14 @@ +#!/bin/sh + +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +find "$RPM_BUILD_ROOT" \( -type f -o -type l \) -name \*.la -print0 | +xargs --no-run-if-empty -0 file -N -L | +grep "libtool library file" | +sed -e 's#: libtool library file.*##g' | grep followed by sed? Really? Is it an accepted shell scripting style nowadays? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/122#pullrequestreview-16280889___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
proyvind commented on this pull request. > @@ -0,0 +1,14 @@ +#!/bin/sh + +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +find "$RPM_BUILD_ROOT" \( -type f -o -type l \) -name \*.la -print0 | +xargs --no-run-if-empty -0 file -N -L | +grep "libtool library file" | +sed -e 's#: libtool library file.*##g' | well, to my defense, shell scripting receives little focus and not exactly the language of choice I spend the most time when doing development. Also I've never really grown comfortable with regexp and I truly *hate* perl, which I rewrote several of these scripts in shell from.. :p But at least it does what it's supposed to do and works well at it, so that's good enough for me as a start, but I'd love to see others applying a more sexy final touch to improve the scripts. :o) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/122___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] add brp helper scripts from mandriva's spec-helper (#122)
proyvind commented on this pull request. > @@ -0,0 +1,14 @@ +#!/bin/sh + +# If using normal root, avoid changing anything. +if [ -z "$RPM_BUILD_ROOT" -o "$RPM_BUILD_ROOT" = "/" ]; then + exit 0 +fi + +find "$RPM_BUILD_ROOT" \( -type f -o -type l \) -name \*.la -print0 | +xargs --no-run-if-empty -0 file -N -L | +grep "libtool library file" | +sed -e 's#: libtool library file.*##g' | For the brp-check-elf-files script, it's hard to contest that more work has been put into yours than pixel (I'm guessing) put into writing the original perl script, which I've simply rewritten in bash. Yet for the brp- scripts, I'm a firm believer in KISS, where I really think the brp* scripts should be self-contained and for single purpose only with as little complexity as possible. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/122___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
