Re: [Rpm-maint] [rpm-software-management/rpm] Add macro for tar default flags. (#557)
@ascherer pushed 2 commits. 6036ec0 Source: file extraction may use other filters. 0b4473e Use default option macros for extractors. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/557/files/8df3cd3f9461957abf7e115495d815d3044b5087..0b4473e2d3648fd1c10d5ac4a43c9ea840835bdd ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: don't prevealuate lua macros (#556)
@jasontibbitts: %luamacro would need to be implemented as a co-routine because of rpm's embedded lua interpreter has a persistent global environment. That is very different than shell code, where a sub-shell inherits but cannot change its parent's environment. With rpm+lua, all lua invocations run in the same globally persistent environment. That is/was actually the intended feature so that variables in the lua context could be shared/passed between, say, %pre and %post scriptlets implemented using embedded lua. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/556#issuecomment-426220110___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: useful lua errors (#545)
The top macro name you're seeing is simply the line in the spec. Try --trace (or in older versions that don't support it, --eval '%trace') for more advanced macro debugging. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/545#issuecomment-426230944___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add macro for tar default flags. (#557)
@ascherer pushed 1 commit. 001509e Quit processing if tar fails. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/557/files/0b4473e2d3648fd1c10d5ac4a43c9ea840835bdd..001509eb47bb06f5a800792fe9931aa533453ec8 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: set version to 0 when not present instead of erroring (#559)
It's not that the software doesn't have *some* version in such a situation, it's just that the long-standing practise is to cram that info into the Release tag which is completely wrong. The right way to deal with such situations is to use the tilde operator, eg ``` Version: 0~git1234" ``` Defaulting to Version 0 would only encourage continuing to abuse the Release field for the purpose. Sorry but no. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/559#issuecomment-426234507___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: set version to 0 when not present instead of erroring (#559)
Closed #559. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/559#event-1879008589___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add macro for tar default flags. (#557)
@ascherer pushed 1 commit. 6e2b98a DRY: Uniform error handling. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/557/files/001509eb47bb06f5a800792fe9931aa533453ec8..6e2b98ac00ca1b3ccbe32d237fbd139e2b1c9cc5 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add macro for tar default flags. (#557)
Don't worry. I'll smash my commits after I'm back at my own machine, where I can actually compile and check this stuff. 😄 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/557#issuecomment-426236360___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] fileattrs: Tighten pythondist path regex for metadata (RhBug:1618949) (#562)
@keszybz I've made the changes as requested. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/562#issuecomment-426244924___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] fileattrs: Tighten pythondist path regex for metadata (RhBug:1618949) (#562)
keszybz approved this pull request. LGTM. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/562#pullrequestreview-160714202___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] fileattrs: Tighten pythondist path regex for metadata (RhBug:1618949) (#562)
ignatenkobrain commented on this pull request.
> @@ -1,3 +1,3 @@
%__pythondist_provides %{_rpmconfigdir}/pythondistdeps.py --provides
--majorver-provides
%__pythondist_requires %{_rpmconfigdir}/pythondistdeps.py --requires
-%__pythondist_path
/lib(64)?/python[[:digit:]]\\.[[:digit:]]/.*\\.(dist.*|egg.*)$
+%__pythondist_path
/lib(64)?/python[[:digit:]]\\.[[:digit:]]+/site-packages/[^/]*\\.(dist-info|egg-info|egg-link)$
does it have to be site-packages?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/562#pullrequestreview-160715552___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] fileattrs: Tighten pythondist path regex for metadata (RhBug:1618949) (#562)
Conan-Kudo commented on this pull request.
> @@ -1,3 +1,3 @@
%__pythondist_provides %{_rpmconfigdir}/pythondistdeps.py --provides
--majorver-provides
%__pythondist_requires %{_rpmconfigdir}/pythondistdeps.py --requires
-%__pythondist_path
/lib(64)?/python[[:digit:]]\\.[[:digit:]]/.*\\.(dist.*|egg.*)$
+%__pythondist_path
/lib(64)?/python[[:digit:]]\\.[[:digit:]]+/site-packages/[^/]*\\.(dist-info|egg-info|egg-link)$
Technically, on Debian systems it can be `dist-packages`, but they also change
other aspects of the path so this doesn't match anyway...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/562#discussion_r221947091___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] fileattrs: Tighten pythondist path regex for metadata (RhBug:1618949) (#562)
ignatenkobrain commented on this pull request.
> @@ -1,3 +1,3 @@
%__pythondist_provides %{_rpmconfigdir}/pythondistdeps.py --provides
--majorver-provides
%__pythondist_requires %{_rpmconfigdir}/pythondistdeps.py --requires
-%__pythondist_path
/lib(64)?/python[[:digit:]]\\.[[:digit:]]/.*\\.(dist.*|egg.*)$
+%__pythondist_path
/lib(64)?/python[[:digit:]]\\.[[:digit:]]+/site-packages/[^/]*\\.(dist-info|egg-info|egg-link)$
so to be fully correct, I would change `[^/]*` → `[^/]+` because this would
match `/usr/lib64/python3.7/site-packages/.dist-info`. Not that it's good idea
to have such file, but whatever ;)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/562#discussion_r221996970___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: don't prevealuate lua macros (#556)
I swear I received a notification email about a reply, but I came here to read it and see nothing. How bizarre. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/556#issuecomment-426365785___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] fileattrs: Tighten pythondist path regex for metadata (RhBug:1618949) (#562)
@ignatenkobrain Made the requested change. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/562#issuecomment-426472817___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
