Re: [Rpm-maint] [rpm-software-management/rpm] Treat tilde versions as higher for purpose of dependency comparison (#715)
@pmatilai yeah, this is somewhat similar. Unfortunately I don't know how we could nicely express both. @ffesti yeah, the only problem is that semver.org says you can have versions like `2.0.0beta` which would be translated into `2.0.0beta` in RPM. Not saying it is horrible or people should be doing this, but this case is valid. Also this tilde at the end looks not really nice :/ Especially if people would have to read this in their error messages. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/715#issuecomment-496674958___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Reject %pretrans scripts that are not lua (#714)
Nope, still works as expected... ``` [root@sopuli Packages]# rpm --root /srv/test -Uvh b/bash-4.4.19-2.fc28.x86_64.rpm g/glibc-2.27-8.fc28.x86_64.rpm g/glibc-common-2.27-8.fc28.x86_64.rpm n/ncurses-libs-6.1-4.20180224.fc28.x86_64.rpm n/ncurses-base-6.1-4.20180224.fc28.noarch.rpm f/filesystem-3.8-2.fc28.x86_64.rpm b/basesystem-11-5.fc28.noarch.rpm s/setup-2.11.3-1.fc28.noarch.rpm t/tzdata-2018d-1.fc28.noarch.rpm f/fedora-release-28-1.noarch.rpm g/glibc-langpack-en-2.27-8.fc28.x86_64.rpm f/fedora-repos-28-1.noarch.rpm f/fedora-gpg-keys-28-1.noarch.rpm l/libselinux-2.7-13.fc28.x86_64.rpm l/libsepol-2.7-6.fc28.x86_64.rpm p/pcre2-10.31-4.fc28.x86_64.rpm /home/pmatilai/rpmbuild/RPMS/noarch/pretrans-0.1-1.noarch.rpm warning: b/bash-4.4.19-2.fc28.x86_64.rpm: Header V3 RSA/SHA256 Signature, key ID 9db62fb1: NOKEY error: Failed dependencies: /bin/sh is needed by pretrans-0.1-1.noarch ``` This is what commit c0eb82dd1f2102f2b4899c1e7232086c41d2e805 is all about. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/714#issuecomment-496483393___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Reject %pretrans scripts that are not lua (#714)
Yes it will, that's the whole point. If it doesn't, then we've broken something. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/714#issuecomment-496481770___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Reject %pretrans scripts that are not lua (#714)
Well, but it will not fail if you install the bash package with it. Still the pretrans scriptlet won't work. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/714#issuecomment-496481545___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Reject %pretrans scripts that are not lua (#714)
> This issue is kinda worsened by the fact that this will not create a > dependency issue but rather an ordering problem that is more or less ignored > up to the point where the script fails. Um, what do you mean? It *is* a dependency issue, a package with /bin/sh (or similar) %pretrans scriptlet will fail in empty root like this: ``` [root@sopuli ~]# rpm -Uvh --root /srv/test /home/pmatilai/rpmbuild/RPMS/noarch/pretrans-0.1-1.noarch.rpm error: Failed dependencies: /bin/sh is needed by pretrans-0.1-1.noarch [root@sopuli ~]# ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/714#issuecomment-496480516___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Reject %pretrans scripts that are not lua (#714)
Well, we should at least issue a warning that the package cannot be installed on an empty system. This issue is kinda worsened by the fact that this will not create a dependency issue but rather an ordering problem that is more or less ignored up to the point where the script fails. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/714#issuecomment-496475910___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Treat tilde versions as higher for purpose of dependency comparison (#715)
I guess there is no real way around using `Requires: (foo >= 1.0.0 with foo < 2.0.0~)`. Yes, this is kinda annoying. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/715#issuecomment-496475028___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Enforce utf-8 encoding by default (#716)
Merged #716 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/716#event-2371242235___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: BuildRequires generator (#104)
Implemented as of commit 58dcfddc376a7c97de1432f0082be0d5f01adbcd -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/104#issuecomment-496447889___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: BuildRequires generator (#104)
Closed #104. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/104#event-2371238045___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Enforce utf-8 encoding by default (#716)
At least in Fedora, practically everything is already utf-8. Looking at Fedora-Server-dvd-x86_64-28-1.1.iso contents (because it's what I happen to have at hand), every single package there is already utf-8 clean (ie has "enconding" tag) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/716#issuecomment-496440263___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Enforce utf-8 encoding by default (#716)
This might wind up being somewhat painful, but it's a good idea to get spec files to use a consistent text encoding. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/716#issuecomment-496439058___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add support for `else if` operator (#311)
Implemented as of commit 1c4b238840d0995344d0d0381a0561b213429203 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/311#issuecomment-496438702___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Enforce utf-8 encoding by default (#716)
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/716#pullrequestreview-242549255___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFE: add support for `else if` operator (#311)
Closed #311. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/311#event-2371161673___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)
Fantastic, thank you very much! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/593#issuecomment-496427088___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Enforce utf-8 encoding by default (#716)
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/716 -- Commit Summary -- * Enforce utf-8 encoding by default -- File Changes -- M macros.in (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/716.patch https://github.com/rpm-software-management/rpm/pull/716.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/716 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)
Awesome. Thank you, guys! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/593#issuecomment-496388368___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)
Merged #593 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/593#event-2370694142___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)
pmatilai approved this pull request. Looking fine now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/593#pullrequestreview-242466458___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Build Dependencies (#593)
Okay, I think that was all. BTW @ffesti, please add at least a brief comment when pushing updates, I only noticed this had been updated by accident this morning when it could've been merged yesterday already. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/593#issuecomment-496381039___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
