Re: [Rpm-maint] [rpm-software-management/rpm] Fix rpmVerifySignatures() passing garbage as verify flags in rpm >= 4.14 (#747)
ignatenkobrain approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/747#pullrequestreview-249170949___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix rpmVerifySignatures() passing garbage as verify flags in rpm >= 4.14 (#747)
Merged #747 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/747#event-2409723495___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Take changelog timezone in account (RhBug 1715412) (#739)
Looks good. Only thing left is a missing "g" in the commit message of 3rd patch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/739#issuecomment-501605117___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Take changelog timezone in account (RhBug 1715412) (#739)
Corrected in the latest version. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/739#issuecomment-501619925___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Take changelog timezone in account (RhBug 1715412) (#739)
Warning instead of info is emitted (in the latest version). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/739#issuecomment-501624116___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Drop bogus condition from header index allocation (#748)
We always allocate the index here as should be obvious from the code, the condition is a leftover that might've been relevant in the turn of the millenium but not anymore. This construct confused clang into thinking there's a NULL pointer dereference at the end of a long callchain (maybe because the indexlen argument is signed so if you passed in -1 as indexLen... but fixing those int32_t's is another story) You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/748 -- Commit Summary -- * Drop bogus condition from header index allocation -- File Changes -- M lib/header.c (5) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/748.patch https://github.com/rpm-software-management/rpm/pull/748.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/748 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Don't fail build trying to kill a non-existent process (RhBug:1720143) (#749)
The job killer introduced at 06953879d3e0b1e9a434979056d1225ab4646142 failed to take into account the fact that the processes *can* die between us grabbing the pids and actually killing them, and that trying to kill a non-existent process will cause a script running with -e to actually terminate an error. So we end up failing a successful build by trying to kill process that exited on its own, ugh :) You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/749 -- Commit Summary -- * Don't fail build trying to kill a non-existent process (RhBug:1720143) -- File Changes -- M macros.in (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/749.patch https://github.com/rpm-software-management/rpm/pull/749.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/749 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Take changelog timezone in account (RhBug 1715412) (#739)
pmatilai commented on this pull request.
> @@ -178,13 +179,17 @@ static int dateToTimet(const char * datestr, time_t *
> secs, int * date_words)
if (*secs == -1) goto exit;
+if (tzname[1][0] == 0)
+ rpmlog(RPMLOG_WARNING, _("bogus TZ database name in %%changelog:
%s\n"), datestr);
Why the talk about *database* here? It's the timezone name that is wrong, not a
name of some database as the message indicates.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/739#pullrequestreview-249242632___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't fail build trying to kill a non-existent process (RhBug:1720143) (#749)
ignatenkobrain approved this pull request. Oh yeah :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/749#pullrequestreview-249242595___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't fail build trying to kill a non-existent process (RhBug:1720143) (#749)
Merged #749 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/749#event-2410030073___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Make rpm fail to install unverified packages (#231)
If the code committed? if not, is there a patch available? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/231#issuecomment-501840042___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] How to enforce rpm install and upgrade to fail if rpm is not signed (#750)
Is there a way to force rpm -i or -U to fail if rpm is not signed with gpg key? if not how to enable it. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/750___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] How to enforce rpm install and upgrade to fail if rpm is not signed (#750)
Starting with rpm 4.14.2, yes. See https://rpm.org/wiki/Releases/4.14.2 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/750#issuecomment-501974676___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] How to enforce rpm install and upgrade to fail if rpm is not signed (#750)
Closed #750. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/750#event-2412598169___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] How to enforce rpm install and upgrade to fail if rpm is not signed (#750)
Which option i have to use to enforce install to fail if rpm is not signed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/750#issuecomment-501987730___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
