Re: [Rpm-maint] [rpm-software-management/rpm] Add --zlib-compress-debug-sections to find-debug-info.sh (#795)
> Is there some particular user / use-case for this? No, not for now. The benefit of using the --zlib-compress-debug-sections option is that installed debug info gets smaller. The drawback is that loading debug information get slower. This may be an acceptable trade-off for either an an entire distro, or a subset of packages, experimentation is required to get that information. This option enables this kind of experimentation. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/795#issuecomment-522673282___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Prefer '[] && []' to '[ -a ]' and '[] || []' to '[ -o ]' in tests (#810)
When pushing updates to address comments, make a note of what you changed here. It's not always that obvious, and pushes without comments go easily unnoticed overall. ""Prefer '[] && []' to '[ -a ]' and '[] || []' to '[ -o ]'" describes the literal change done by the patch. This is not useful information because that's what the patch itself is for! The commit summary + message is about rationale of the change. "in tests" is also problematic because it too is unnecessarily ambiguous - does it refer to the tests in testsuite or something else? Something along the lines of "Eliminate use of ambiguous logical operators in script conditionals" would be at least closer to the mark. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/810#issuecomment-522555934___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add a dummy line to CI setup to allow controlling dnf gpgcheck per build (#819)
Merged #819 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/819#event-2565919051___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add a dummy line to CI setup to allow controlling dnf gpgcheck per build (#819)
@pmatilai pushed 1 commit. b2decdfad1ad2d92e4fec1df597421d2313a76f3 Add a dummy line to CI setup to allow controlling dnf gpgcheck per build -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/819/files/7edd455df0e9b87a057428f24f37858665485208..b2decdfad1ad2d92e4fec1df597421d2313a76f3 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add a dummy line to CI setup to allow controlling dnf gpgcheck per build (#819)
@pmatilai pushed 1 commit. 30fede268c054cac9e784524137e97f1e6a5e60b Add a dummy line to CI setup to allow controlling dnf gpgcheck per build -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/819/files/341f740139ceb0f611aa6375119e70ca7a70775a..30fede268c054cac9e784524137e97f1e6a5e60b ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add a dummy line to CI setup to allow controlling dnf gpgcheck per build (#819)
@pmatilai pushed 1 commit. 341f740139ceb0f611aa6375119e70ca7a70775a Add a dummy line to CI setup to allow controlling dnf gpgcheck per build -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/819/files/ea81cfee2d10f3bffa48d65b50d24ca060fe349a..341f740139ceb0f611aa6375119e70ca7a70775a ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Add a dummy line to CI setup to allow controlling dnf gpgcheck per build (#819)
This doesn't do anything at all in itself because all the repositories have gpgcheck=1 by default. However adding this line allows disabling the gpgcheck for individual builds via Semaphore build settings, which allows us to deal with signatures on rawhide breaking twice a year causing our builds to appear failed for no good reason. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/819 -- Commit Summary -- * Add a dummy line to CI setup to allow controlling dnf gpgcheck per build -- File Changes -- M ci/Dockerfile (1) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/819.patch https://github.com/rpm-software-management/rpm/pull/819.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/819 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix segfault regression on empty script or description at end of spec (#816)
If you look at the real commit messages, it's quite different to how GH renders it. The long commit hashes just don't align very nicely at < 78 characters per line. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/816#issuecomment-522499141___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix segfault regression on empty script or description at end of spec (#816)
Merged #816 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/816#event-2565729934___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %{expr:...} macro for parsing expressions (#817)
Oh and BTW, the reason for doing this *just now* is that it might be kinda necessary for resolving #804 in the macro space instead of placing all the calculations on the C side. Of course technically Lua could be used for those same calculations but we I don't want to make Lua a hard dependency. The other reason of course is the macro conditional syntax stuff. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/817#issuecomment-522441966___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %{expr:...} macro for parsing expressions (#817)
The error messages are simply the same as you get from spec %if conditionals, there are no messages added / changed in this PR. That's not to say the messages couldn't maybe be improved, but any change needs to account for the fact that they're shared between two quite different contexts. There was an actual bug wrt errors in that expression errors did not raise a macro-level error. Fixed now. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/817#issuecomment-522440554___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add %{expr:...} macro for parsing expressions (#817)
@pmatilai pushed 1 commit.
22331d303765509f1856352713a8a4de74b1085e Add %{expr:...} macro for parsing
expressions
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/817/files/0efdee6fec3848bfd3a4ccf160df553f3a081c2d..22331d303765509f1856352713a8a4de74b1085e
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
