Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Do not use bashism for gettext (#984)
ignatenkobrain approved this pull request. LGTM -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/984#pullrequestreview-336427122___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream debian patches: Fix compilation on platforms without MAP_POPULATE (#985)
ignatenkobrain commented on this pull request. from what I have read in the documentation, MAP_POPULATE will just speed-up things. So if anybody will use this patch anyway, I think this desserves some better commit message and just be merged. That said, I am not sure if I am right :) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/985#pullrequestreview-336426915___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Trying to upstream Debian patches: Use the Debian standard (and safe) mechanism of generating temporary files. (#987)
why not `mktemp`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/987#issuecomment-568982369___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] fix zstd magic (#991)
ignatenkobrain approved this pull request. you're right! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/991#pullrequestreview-336426506___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] fix zstd magic (#991)
I spot it while adding support for zstd compressed metadata in URPM/urpmi, which was broken by this typo typo introduced in commit 3684424fe297c996bb05bb64631336fa2903df12 This fixes issue #990 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/991 -- Commit Summary -- * fix zstd magic -- File Changes -- M rpmio/rpmfileutil.c (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/991.patch https://github.com/rpm-software-management/rpm/pull/991.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/991 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Zstd magic is wrong which breaks detecting zstd files for reading (#990)
rpmFileIsCompressed() fails to properly detected zstd compressed files because of a typo -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/990___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] The max lengthe of RPM package name is 66? (#974)
I meet some problem when try to setup the dev env for debugging. Could you point out the lead structure definition in source file? I find some code that the name length is "66" in struct "rpmlead_s" which I think it's deprecated. Thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/974#issuecomment-568873334___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
