Re: [Rpm-maint] [rpm-software-management/rpm] Rework and clarify database backend detection logic (#1115)

[Panu Matilainen]

> @pmatilai What does #1028 have to do with this? Michael Schroeder isn't even 
> in there.

It doesn't, that's just a typo of some sort, quite possibly GH autofill 
induced. #1012 is what I meant, updated in the description now too.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1115#issuecomment-598031853___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Rework and clarify database backend detection logic (#1115)

[ニール・ゴンパ]

@pmatilai What does #1028 have to do with this? Michael Schroeder isn't even in 
there.

Anyway, aside from that, it _looks_ sane, I need to test it, though...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1115#issuecomment-597828964___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Skip HEREDOCs when parsing perl virtual Provides (#1111)

[Brett T. Warden]

Oh, @ppisar, I guess you wrote that patch :D

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/#issuecomment-597801394___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Skip HEREDOCs when parsing perl virtual Provides (#1111)

[Brett T. Warden]

[This project](https://metacpan.org/release/rpm-build-perl) aims to provide 
replacements that hook into the compiler backend of Perl and could 
theoretically give better answers. I had to apply a 
[patch](https://rt.cpan.org/Ticket/Attachment/1731178/930892/rpm-build-perl-0.82-Port-to-OpSIBLING-like-macros-required-since-Perl-5..patch)
 from a [bug report](https://rt.cpan.org/Public/Bug/Display.html?id=117350). It 
outputs dependencies differently

> Convert module name to conventional dependency name, e.g. File::Find -> 
> perl(File/Find.pm). Note that this differs from RedHat conventional form 
> perl(File::Find).

but that's a minor thing to change. Running it against 
App::cpanminus::fatscript:
```
$ perl.prov /usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm
# saw $VERSION in package App::cpanminus at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 25 (SKIP)
# saw $VERSION in package App::cpanminus::script at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 423 (SKIP)
# saw $VERSION in package CPAN::DistnameInfo at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 3478 (SKIP)
# saw $VERSION in package CPAN::Meta at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 3688 (SKIP)
# saw $CPAN::Meta::Check::VERSION at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 4843 (SKIP)
# saw $VERSION in package CPAN::Meta::Converter at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 4978 (SKIP)
# saw $VERSION in package CPAN::Meta::Feature at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 6620 (SKIP)
# saw $VERSION in package CPAN::Meta::History at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 6773 (SKIP)
# saw $VERSION in package CPAN::Meta::Merge at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 7091 (SKIP)
# saw $VERSION in package CPAN::Meta::Prereqs at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 7391 (SKIP)
# saw $VERSION in package CPAN::Meta::Requirements at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 7816 (SKIP)
# saw $VERSION in package CPAN::Meta::Spec at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 8927 (SKIP)
# saw $VERSION in package CPAN::Meta::Validator at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 10160 (SKIP)
# saw $CPAN::Meta::YAML::VERSION at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 11375 (SKIP)
# saw $VERSION in package Exporter at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 12333 (SKIP)
# saw $VERSION in package Exporter::Heavy at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 12922 (SKIP)
# saw $VERSION in package File::pushd at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 13177 (SKIP)
# saw $VERSION in package HTTP::Tiny at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 13482 (SKIP)
# saw $JSON::PP::VERSION at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 15704 (SKIP)
# saw $JSON::PP::IncrParser::VERSION at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 17114 (SKIP)
# saw $VERSION in package Module::CPANfile at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 18526 (SKIP)
# saw $VERSION in package Module::Metadata at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 19207 (SKIP)
# saw $VERSION in package Parse::CPAN::Meta at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 20220 (SKIP)
# saw $VERSION in package Parse::PMFile at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 20576 (SKIP)
# saw $VERSION in package String::ShellQuote at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 21497 (SKIP)
# saw $VERSION in package local::lib at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 21773 (SKIP)
# saw $VERSION in package local::lib at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 21774 (SKIP)
# saw $VERSION in package parent at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 23207 (SKIP)
# saw $VERSION in package version at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 23355 (SKIP)
# saw $VERSION in package version::regex at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 23477 (SKIP)
# saw $VERSION in package version::vpp at 
/usr/lib/perl5/vendor_perl/5.30.1/App/cpanminus/fatscript.pm line 23716 (SKIP)
perl(App/cpanminus/fatscript.pm)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/#issuecomment-597796126___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Make "rpmspec -q --srpm foo.spec" say .src, not .%{arch} (#1116)

[Peter Jones]

I noticed that "rpmspec -q --srpm foo.spec" winds up getting evaluated
as the arch that you're running it on, which I expected, but also that
the arch winds up in the output, which I did not.  I asked a pile of
other people and they were all surprised by this as well.

This patch changes "rpmspec -q --srpm foo.spec" to show 
"src", like the
package generated by "rpmbuild -bs" would be named, instead of the 
local
machine's arch.

Signed-off-by: Peter Jones 
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1116

-- Commit Summary --

  * Make "rpmspec -q --srpm foo.spec" say .src, not .%{arch}

-- File Changes --

M lib/query.c (13)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1116.patch
https://github.com/rpm-software-management/rpm/pull/1116.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1116
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)

[Bernhard Rosenkraenzer]

For the package overall, it may be best to just use the Provides/Requires 
mechanism with multiple things being generated, e.g.
Requires: cpu(arm)
Requires: cpu(neon)
Requires: cpu(thumb)

or
Requires: cpu(x86_64)
Requires: cpu(mmx)
Requires: cpu(sse)
Requires: cpu(sse2)

where cpu(*) features would be automatically Provide:d by rpm looking at the 
likes of /proc/cpuinfo, and could be manually provided by stuff like 
qemu-binfmt* packages.

Of course it gets a lot trickier when we're dealing with the per-file 
libc.so.6()(64bit) bits, not sure we want something huge like Provides: 
libc.so.6(x86_64)(mmx)(sse)(sse2)(ssse3)(sse4)(sse4_1)(sse4_2)(avx)(avx2) and 
obviously something requiring that wouldn't necessarily know that 
libc.so.6(x86_64) or libc.so.6(x86_64)(mmx) would be sufficient to fulfill the 
dependency.
But obviously the nice thing about it would be that tools like dnf could 
automatically pick between 
libc.so.6(x86_64)(mmx)(sse)(sse2)(ssse3)(sse4)(sse4_1)(sse4_2)(avx)(avx2), 
libc.so.6(x86_64)(mmx)(sse)(sse2) and libc.so.6(x86_64) if multiple options are 
provided.

Of course going down further that route, it may also be necessary to provide 
information about CPU timings to allow picking between e.g. an Intel optimized 
and an AMD optimized build even if both will work on either type 
(-march=generic -mtune=whatever).
But something like
libc.so.6(x86_64)(mmx)(sse)(sse2)(ssse3)(sse4)(sse4_1)(sse4_2)(avx)(avx2)(tune:amd)
can get pretty long...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597692182___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)

[ニール・ゴンパ]

I think I did okay in this PR avoiding many freak cases, though I definitely 
see your point about the broader architecture handling.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597671507___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)

[ニール・ゴンパ]

> For example, while the arch marker generation seems pretty obvious in 
> general, starting something new with hardcoding ARM stuff gives me the 
> willies. I want ARM to stop being the freak case that always being worked 
> around, and have the design flexible enough to cover it. 

I'm not looking forward to RISC-V potentially adding another set of freak cases 
either... :cry:

Thankfully, we've so far managed to avoid it, but... 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597670693___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)

[Panu Matilainen]

This needs to be looked at together as a whole with any arch handling changes 
we are about to do, so we don't end up doing something now that we'll bitterly 
regret in six months time. So we need to build up the big picture first.

For example, while the arch marker generation seems pretty obvious in general, 
starting something new with hardcoding ARM  stuff gives me the willies. I want 
ARM to stop being the freak case that always being worked around, and have the 
design flexible enough to cover it. We cannot foresee all such cases that might 
come up in the future so maybe the arch marker thing should allow for 
"arbitrary" multiple tokens that can be reliably parsed, in addition to the 
main arch name.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597662261___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Skip HEREDOCs when parsing perl virtual Provides (#1111)

[Panu Matilainen]

@ppisar , that changes like this have potential for regressions is obvious even 
to a perl-illiterate like myself. Let me rephrase that question: would *you* 
merge this? If it's left up to me, I'll hit the merge button in a day or two if 
only because I don't know any better :smile:

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/#issuecomment-597643624___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)

[Florian Festi]

Oh, another use case for some new architecture detection and handling library.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597633944___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)

[Florian Festi]

Meh. I am still not a big fan of this solution, but we can still change the 
defaults later on. It indeed seems unlikely someone won't ship the compat 
Provides anytime soon.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597632478___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Rework and clarify database backend detection logic (#1115)

[Panu Matilainen]

Try the configured backend first, and only if that fails try autodetection.
The former logic did not anticipate multiple backends handling same
files and gets mightily confused when both bdb and bdb-ro are enabled,
causing half the test-suite failing in "make check".

Also emit a different message when database rebuild is in progress,
the old message is quite confusing in that case.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1115

-- Commit Summary --

  * Rework and clarify database backend detection logic

-- File Changes --

M lib/backend/dbi.c (61)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1115.patch
https://github.com/rpm-software-management/rpm/pull/1115.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1115
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add MIME types for all files in packages, drop filtered file classes (#1114)

[ニール・ゴンパ]

That's a fair point, once you have a more fleshed out commit message for this, 
then I'd be happy look over it for final review. At least code-wise, looks 
good. 👍 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1114#issuecomment-597609827___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add MIME types for all files in packages, drop filtered file classes (#1114)

[Panu Matilainen]

Being optional might be a matter of perspective: prior to rpm 4.13, file 
classes and colors were not populated if external dependency generator was 
used, which always was a smallish but non-ignorable set of packages.

We could certainly do this in stages as well, ie first add MIME and then later 
axe file class, it just feels like a mountain of duplicated crud for little 
reason. At any rate this needs a more elaborate commit message, this is RFC 
status for a reason.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1114#issuecomment-597609178___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)

[ニール・ゴンパ]

Incidentally, that's why I'm always populating biarch Provides. We're going to 
be stuck with them for a _long_ time due to RHEL and SLE and proprietary 
software.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597590860___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add MIME types for all files in packages, drop filtered file classes (#1114)

[ニール・ゴンパ]

Conan-Kudo approved this pull request.

In general, I think the approach looks good, and the added test seems to agree 
with me, so if you feel this is the way to go, then I'm okay with it. 👍 



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1114#pullrequestreview-372690953___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add MIME types for all files in packages, drop filtered file classes (#1114)

[ニール・ゴンパ]

> Can you try explaining why this makes you uneasy? (I know well enough it's 
> not always easy to say)

I think the thing that makes me uneasy is that we're simultaneously no longer 
populating `RPM_FILECLASS`. It's pretty rare that we do something like that. 
I'm semi-concerned about the quality of the classifications, but that's 
something that can be improved over time.

> Thing is, aside from the class info being unreliable as hell, the file class 
> data has always been optional and not all packages have it, so nothing at all 
> can _rely_ on it.

So, I didn't know this part. As far as I had known, file class data has always 
been present in RPMs built the normal way (i.e. with rpmbuild on a distro that 
has a functioning rpm).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1114#issuecomment-597589059___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add MIME types for all files in packages, drop filtered file classes (#1114)

[ニール・ゴンパ]

> > I don't seem to see an obvious source for mime data for rpm to populate 
> > MIME types for files?
> 
> Hmm? That source was added in commit 
> [e49111d](https://github.com/rpm-software-management/rpm/commit/e49111d822dc1c0715f5a85ed61523b4d020ae33),
>  this just builds on top of that. That, or I'm misunderstanding the question.

Nope, that answers the question. I forgot that was already merged earlier, 
which is pretty bad since I approved it! 🤦‍♂  

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1114#issuecomment-597588206___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add MIME types for all files in packages, drop filtered file classes (#1114)

[Panu Matilainen]

> I don't seem to see an obvious source for mime data for rpm to populate MIME 
> types for files?

Hmm? That source was added in commit e49111d822dc1c0715f5a85ed61523b4d020ae33, 
this just builds on top of that.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1114#issuecomment-597585841___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add MIME types for all files in packages, drop filtered file classes (#1114)

[Panu Matilainen]

Can you try explaining why this makes you uneasy? (I know well enough it's not 
always easy to say)
Thing is, aside from the class info being unreliable as hell, the file class 
data has always been optional and not all packages have it, so nothing at all 
can *rely* on it. 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1114#issuecomment-597584782___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add MIME types for all files in packages, drop filtered file classes (#1114)

[ニール・ゴンパ]

@pmatilai Maybe I'm blind and I missed something, but I don't seem to see an 
obvious source for mime data for rpm to populate MIME types for files?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1114#issuecomment-597584294___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add MIME types for all files in packages, drop filtered file classes (#1114)

[Panu Matilainen]

pmatilai commented on this pull request.



> @@ -396,13 +397,21 @@ rpm_loff_t rpmfilesFSize(rpmfiles fi, int ix);
 rpm_color_t rpmfilesFColor(rpmfiles fi, int ix);
 
 /** \ingroup rpmfiles
- * Return file class from file info set.
+ * return file class from file info set.

By mistake, rather obviously I hope. Fixed, thanks for spotting.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1114#discussion_r390910589___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] elfdeps: Add full multiarch deps support (#1038)

[ニール・ゴンパ]

@ffesti If someone is trying to build a cross-distro package, accounting for 
legacy from a newer-ish system (think Google Chrome or Bluejeans/Zoom Linux 
RPMs being built on a specific host and shipped for everybody), being able to 
flip behaviors makes sense.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1038#issuecomment-597582303___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add MIME types for all files in packages, drop filtered file classes (#1114)

[ニール・ゴンパ]

I'm still somewhat uneasy about this change, but at least we're not repurposing 
an existing field anymore...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1114#issuecomment-597581570___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add MIME types for all files in packages, drop filtered file classes (#1114)

[ニール・ゴンパ]

Conan-Kudo requested changes on this pull request.



> @@ -396,13 +397,21 @@ rpm_loff_t rpmfilesFSize(rpmfiles fi, int ix);
 rpm_color_t rpmfilesFColor(rpmfiles fi, int ix);
 
 /** \ingroup rpmfiles
- * Return file class from file info set.
+ * return file class from file info set.

Why did you change this?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1114#pullrequestreview-372676540___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Use MIME types instead of magic strings for RPMTAG_FILECLASS (#1099)

[Panu Matilainen]

"Plan 1" now implemented for comparison in #1114.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1099#issuecomment-597580325___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Add MIME types for all files in packages, drop filtered file classes (#1114)

[Panu Matilainen]

This is an alternative to #1099, making a clear distinction between the old 
class info and new MIME stuff.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1114#issuecomment-597574463___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Add MIME types for all files in packages, drop filtered file classes (#1114)

[Panu Matilainen]

Add new tags, rpmfiles APIs and other infra to support storing and
querying file MIME types. Store MIME type for all files, stop adding
rather arbitrarily filtered file "class" data as this is bloated and
relatively useless data, remove related cruft.

Fixes: #1096
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1114

-- Commit Summary --

  * Add MIME types for all files in packages, drop filtered file classes

-- File Changes --

M build/rpmfc.c (136)
M doc/rpm.8 (6)
M lib/rpmfi.c (22)
M lib/rpmfi.h (7)
M lib/rpmfiles.h (21)
M lib/rpmtag.h (3)
M lib/tagexts.c (25)
M rpmpopt.in (3)
M tests/rpmbuild.at (32)
M tests/rpmgeneral.at (3)
M tests/rpmsigdig.at (6)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1114.patch
https://github.com/rpm-software-management/rpm/pull/1114.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1114
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Use MIME types instead of magic strings for RPMTAG_FILECLASS (#1099)

[Panu Matilainen]

While looking at this, I rediscovered (oh the things you write and forget) 
makeClass() in lib/tagexts.c.
Which makes me think the answer is probably 1), ie leave the *CLASS* tags alone 
but stop populating the header with them, and add new MIME tags instead.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1099#issuecomment-597549518___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint