Re: [Rpm-maint] [rpm-software-management/rpm] Always open (and initialize) the entire database at once (#1119)

2020-03-13 Thread ニール・ゴンパ
Conan-Kudo approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1119#pullrequestreview-374514672___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Always open (and initialize) the entire database at once (#1119)

2020-03-13 Thread ニール・ゴンパ
Erk, oops, disregard that... I clicked the wrong thing...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1119#issuecomment-598851749___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add support for fsverity signatures (#1121)

2020-03-13 Thread Panu Matilainen
Care to explain to the uninitiated layman such as myself why would we want/need 
this in rpm, since there already is IMA?

Adding per-file data to headers is costly, and IMA already bloats headers 
significantly. Adding more of the same (as it kinda seems to me on the outset) 
needs to have some pretty convincing benefits.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1121#issuecomment-598598663___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make "rpmspec -q --srpm foo.spec" say .src, not .%{arch} (#1116)

2020-03-13 Thread Panu Matilainen
Having rpmspec default query match with what rpmbuild produces seems like a 
nice idea, the implementation is what I have some issues with, primarily that 
the new default is a magic internal behavior that you can't use it in other 
queries. I think this belongs to a tag extension, RPMTAG_PKGNEVRA or something 
like that.

Including or otherwise using stuff from build/ in lib/ is not okay, but you 
don't need access to spec struct for that, look for RPMTAG_NOSOURCE in the 
header, it should be populated at that point. And if it's not, maybe we can 
change that.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1116#issuecomment-598595985___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint