Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)
> imposes its own signal handling on users when the db is open Can turn that off since 56f49d7f5af7c1c8a3eb478431356195adbfdd25 right? > and our ABI hasn't been particularly stable historically Maintaining C shared libraries is indeed extremely hard. I've messed up in the past and only just barely caught it before releases etc. That said there are nice tools now like [libabigail](https://pagure.io/libabigail) - should be easy to set that up on CI here right? (I still need to do that for ostree) > dbus library itself is much more stable AIUI. Yeah, libdbus as a C shared library has been fine and will continue to be so, but exposing an API over DBus is a separate thing with long term commitments. If we're effectively saying most projects shouldn't be using librpm to read the rpm database effectively (that seems like what you're implying) that's a rather radical thing right? Maybe I am misunderstanding though. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1255#issuecomment-649535595___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)
I guess given that the magic stuff hasn't worked in forever, it's fine to just drop it and not worry about it flaking in the future. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-649485037___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)
> To be clear, `%__foo_path` and `%__foo_magic` filters are a union, not an > intersection? That's actually somewhat surprising behavior... Union by default but can be switched with `magic_and_path` flag in `%__foo_flags` to intersection. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-649484434___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)
@pmatilai To be clear, `%__foo_path` and `%__foo_magic` filters are a union, not an intersection? That's actually somewhat surprising behavior... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-649476810___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)
@Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#pullrequestreview-437395755___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)
The change looks good to me. And we've been using this in RHEL for a while with good results. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-649454084___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Fix bogus test-suite failure when input is not a tty (#1290) (#1291)
When running with a non-tty input (such as inside mock), the --addsign test will fail due to GPG_TTY related warning getting emitted since commit 52c0198e245fcac55440ed1e0211d33f84681a7a. Our test-keys do not have passphrases that need to be asked, so just silence the warning by manually setting GPG_TTY to an empty value. Fixes: #1290 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1291 -- Commit Summary -- * Fix bogus test-suite failure when input is not a tty (#1290) -- File Changes -- M tests/rpmsigdig.at (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/1291.patch https://github.com/rpm-software-management/rpm/pull/1291.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1291 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] GPG_TTY warning causes test-suite failure in mock (#1290)
Here's an simple reproducer that doesn't need messing with mock: > [pmatilai🎩︎lumikko rpm]$ cp tests/data/RPMS/hello-2.0-1.x86_64.rpm /tmp/ [pmatilai🎩︎lumikko rpm]$ ./rpmsign --addsign /tmp/hello-2.0-1.x86_64.rpm < /dev/null /tmp/hello-2.0-1.x86_64.rpm: warning: Could not set GPG_TTY to stdin: Inappropriate ioctl for device [pmatilai🎩︎lumikko rpm]$ Or to reproduce in the test-suite context, `make check < /dev/null`. So actually the warning is quite appropriate in this situation, that this works at all in the test-suite depends on the key not having a passphrase at all so nothing will need to ask for it. The right thing to do is probably to set GPG_TTY explicitly from the test-suite instead - I'll submit a PR in a minute. (so typical, I assign this to you but then end up looking at it myself, trying to kill time before vacation...) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1290#issuecomment-649448251___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix python(abi) requires generator, it picked files from almost good directories (#1272)
Ack. I'll ping people. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1272#issuecomment-649284471___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
