Re: [Rpm-maint] [rpm-software-management/rpm] RFE: %undefine_all (#1314)
_Shudder_. Please use an option flag instead. See for example the discussion in issue #1155 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1314#issuecomment-662072704___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Improved errors handling. (#1305)
@KOLANICH pushed 1 commit. 17019255f7460814ab5b0a410eb4409c3e43459f Improved errors handling. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1305/files/cca2767a41acb918828504ad03c5bdbbe64f639a..17019255f7460814ab5b0a410eb4409c3e43459f ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFE: %undefine_all (#1314)
So the `%define`/`%global` is a stack-based, however sometimes you want to undefine variable no matter how many times it was defined. I think `%undefine_all` would be the best name. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1314___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)
@ignatenkobrain commented on this pull request. > @@ -1072,6 +1072,7 @@ static rpmzstd rpmzstdNew(int fdno, const char *fmode) char *t = stdio; char *te = t + sizeof(stdio) - 2; int c; +int threads = -1; ```suggestion int threads = 0; ``` to satisfy @ffesti -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1303#pullrequestreview-452511259___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)
@KOLANICH pushed 1 commit. ab8a88455919c191ab85bf5a4a3ab8261679185b Improved python support: enums are now enums with all additional goodies. Can usually be available using CamelCased prefix, class members have the prefix stripped. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1309/files/ce5514692e86b1f556e96494882189405f8a5581..ab8a88455919c191ab85bf5a4a3ab8261679185b ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
@KOLANICH pushed 1 commit. 090ad798d700b4f166f19ec55e8120e0716e606d Added a high-level wrapper. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311/files/b8ccc7cbbfce9c0005b8039aee4a7ec7c4d44cc8..090ad798d700b4f166f19ec55e8120e0716e606d ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
OK, but there is an argument to be made that this should also work for just opening an rpm package without looking at the payload and instead just accessing the header. Which makes me wonder if we really need this to be context manager. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311#issuecomment-661799300___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
> We should also consider _what_ the high level interface should offer. Well, that's not what this PR is about. This "only" is about making it easier to open an rpm package from disk and reading the payload. We don't really plan to offer a new API for all other functionality. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311#issuecomment-661795382___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
We should also consider _what_ the high level interface should offer. From my perspective, it should (at the minimum) provide ways to: * Work with macros and spec files * Read RPM files * Orchestrate building RPMs * Do simple package management actions But to do this well, we need a design of how this would look... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311#issuecomment-661793990___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Added a high-level wrapper. (#1311)
I really like the idea of offering some easier to use API and using an context manager for that. But there are several aspects of this implementation that don't quite feel right to me. At first I wonder if we can find a better name for the class. This actually wraps (binary) packages. Not sure if `Package` is too generic but it is much closer to the truth. Abbreviating `archive` with `arch` is super confusing as `arch` is used everywhere else as synonym of `architecture`. The fd used should really be stay hidden inside the class. Using it else where will only lead to tears and broken bones. Not sure if `iterFiles` is really needed or if it is better to point to directly using the .archive attribute in the doc string. Or may be I am missing something here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1311#issuecomment-661792867___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Improved errors handling. (#1305)
Also, if we decide to go with the messages in the end, we should end them with a `\n`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1305#issuecomment-661791406___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Improved python support: enums are now enums with all additional goodies. (#1309)
Looks like the new Python file was not added to `EXTRA_DIST = rpm/__init__.py rpm/transaction.py` in `python/Makefile.am` and though failing the CI. The "Modification of dictionary returned by locals()" warning can be avoided by just using globals() which always returns the module name space. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1309#issuecomment-661750550___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Improved errors handling. (#1305)
I am not 100% sure if the new warnings are really better than the previous situation. There are pretty clear error messages for both cases. The added warnings only create confusion and have details that won't help most users. For the second test case it even obscures the actual error message. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1305#issuecomment-661743893___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Improved errors handling. (#1305)
This change "breaks" two test cases which may need adjusting. ``` 239: rpmkeys -Kv 1FAILED (rpmsigdig.at:310) +++ /srv/rpm/rpm-4.16.90/_build/sub/tests/rpmtests.dir/at-groups/239/stderr 2020-07-21 07:50:18.680411000 + @@ -0,0 +1 @@ +warning: pgpPrtParams: The parsing has not consumed the whole stream: pos = 0, remaining = 287warning: pgpPrtParams: The parsing has not consumed the whole stream: pos = 0, remaining = 287 \ No newline at end of file 293: rpm -U FAILED (rpmi.at:257) +++ /srv/rpm/rpm-4.16.90/_build/sub/tests/rpmtests.dir/at-groups/293/stderr 2020-07-21 07:50:24.356411000 + @@ -1,3 +1,3 @@ -error: /tmp/hello-2.0-1.x86_64-signed.rpm: Header RSA signature: BAD (package tag 268: invalid OpenPGP signature) +warning: pgpPrtParams: The parsing has not consumed the whole stream: pos = 0, remaining = 287error: /tmp/hello-2.0-1.x86_64-signed.rpm: Header RSA signature: BAD (package tag 268: invalid OpenPGP signature) error: /tmp/hello-2.0-1.x86_64-signed.rpm cannot be installed 293: rpm -U FAILED (rpmi.at:257) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1305#issuecomment-661737794___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Always close libelf handle (#1313)
Merged #1313 into master. -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1313#event-3570031458___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Always close libelf handle (#1313)
LGTM, thanks! -- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1313#issuecomment-661722877___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)
We need to make sure that the result with the current settings (non threaded compression) remains unchanged to not break deltarpm that way. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1303#issuecomment-661689585___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove compare of global array tagsByName to NULL (#1312)
Thanks for the patch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1312#issuecomment-661684957___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove compare of global array tagsByName to NULL (#1312)
Merged #1312 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1312#event-3569656455___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
