Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-30 Thread marxin
CI seems happy now, can please anybody merge it? I've got another patch based 
on this one that I would like to propose..

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1303#issuecomment-666188501___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-30 Thread Florian Festi
Merged #1303 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1303#event-3603495856___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Support threading for zstd compression. (#1303)

2020-07-30 Thread Florian Festi
Sorry, this took a bit longer than it should have, Thanks for your work and 
patience!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1303#issuecomment-666324374___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-30 Thread Florian Festi
In general I am not a fan of hiding issues this way and would prefer such 
issues would be found and fixed. Otoh we are so far away from Python upstream 
that this may just be the pragmatic thing to do.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1320#issuecomment-666329348___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-30 Thread Florian Festi
Merged #1320 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1320#event-3603542624___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-30 Thread Florian Festi
Thanks for the patch!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1320#issuecomment-666329463___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)

2020-07-30 Thread Florian Festi
@ffesti approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1318#pullrequestreview-458353180___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)

2020-07-30 Thread Florian Festi
Thanks for all the work and polishing!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1318#issuecomment-666335786___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Please that `rpmbuild -ba` includes `-br + -bb`, not `-bs + -bb` (#1304)

2020-07-30 Thread Florian Festi
Closed #1304 via aa5bcb0a4e05667d8298cc008f6d9ee876681dde.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1304#event-3603597138___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Docs: Revamp BUILD OPTIONS section in rpmbuild(8) (#1318)

2020-07-30 Thread Florian Festi
Merged #1318 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1318#event-3603597053___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Document: "rpmbuild -br" always returns 11 when "--nodeps" is used (#963)

2020-07-30 Thread Florian Festi
Closed #963 via 28b3704034a9c772959485a130b918f414da9796.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/963#event-3603597156___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Enable thread autodetection for a parallel compression. (#1324)

2020-07-30 Thread marxin
When using xz or zstd, it can be handy to automatically detect
number of threads. We can use `%{getncpus}` for that.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/1324

-- Commit Summary --

  * Enable thread autodetection for a parallel compression.

-- File Changes --

M macros.in (1)
M rpmio/rpmio.c (14)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/1324.patch
https://github.com/rpm-software-management/rpm/pull/1324.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1324
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Enable thread autodetection for a parallel compression. (#1324)

2020-07-30 Thread marxin
It's a follow up of #1303, so adding @ignatenkobrain as a reviewer ;)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1324#issuecomment-666359866___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Enable thread autodetection for a parallel compression. (#1324)

2020-07-30 Thread marxin
@marxin pushed 1 commit.

34a78ee61a67a9ffe11142c045fd1fa01e44160e  Enable thread autodetection for a 
parallel compression.


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1324/files/cd31048911a1d3c6094e4530f5e7e4975849be4a..34a78ee61a67a9ffe11142c045fd1fa01e44160e
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Parallelize file processing (#1185)

2020-07-30 Thread Michal Domonkos
Closed #1185.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1185#event-3604860188___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Parallelize file processing (#1185)

2020-07-30 Thread Michal Domonkos
So I did some more testing and it turns out, after all, that rpmbuild only 
spends a tiny fraction of time in the `processPackageFiles()` function; 
dependency generators (kmod.prov in particular) are a much bigger bottleneck 
but also vastly trickier to parallelize.

The speed improvements that I observed a while ago in 
https://github.com/rpm-software-management/rpm/issues/1185#issuecomment-617147116
 were most likely just a false positive due to some internal data inconsistency 
caused by the "naive" patch that I tested with.

With that said, I'm closing this ticket as there's no point in putting much 
effort in this. OTOH, parallel execution of dependency generators 
(`rpmfcGenerateDepends()`) is something where real improvements could be made 
(in the case of kernel, the cumulative runtime of these is in the order of 
hunderds of seconds). But that would be tracked in a separate issue.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1185#issuecomment-666524760___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Disable Python hash seed randomization in brp-python-bytecompile (#1320)

2020-07-30 Thread frenzymadness
This is definitely something we want to fix in Python in the future. The 
biggest problem here is that marshal (the format used internally for 
byte-compiled cache files) has to be very fast and every step towards 
reproducibility has an impact of its speed. Moreover, I don't know if anybody 
except us needs the files to by byte-to-byte identical. That's the reason why 
we started with 
[marsshalparser](https://github.com/fedora-python/marshalparser) which aims to 
fix all problems with byte-compilation reproducibility and we offer it as an 
optional step in RPM builds in Fedora via [a 
macro](https://src.fedoraproject.org/rpms/redhat-rpm-config/pull-request/96).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1320#issuecomment-666918904___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint