Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Convenient %version without tilde macro (#1219)

2021-02-08 Thread Miro Hrončok
What about this:

```
%{strip %{version} ~^}
```

Would that fly? Or should I include it in python-srpm-macros instead?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/1219#issuecomment-775212046___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)

2021-02-08 Thread ニール・ゴンパ
Nah, this makes a ton of sense to do. At some point, I need to figure out how 
to do Lua for debbuild too. I just don't know how I'll square that with how 
Debian package scripts work...

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1527#issuecomment-775190176___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)

2021-02-08 Thread Panu Matilainen
Right, I have to say I seem to have forgotten that particular nuance of the 
English language. Will fix, but I have to say I was expecting somewhat more 
fundamental discussion over this matter :laughing: 

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1527#issuecomment-775187900___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)

2021-02-08 Thread ニール・ゴンパ
@pmatilai small nit of the commit message: "practise" -> "practice" (en-gb has 
the former for verb, but you're not using it that way, and en-us doesn't have 
that spelling at all).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1527#issuecomment-775177695___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)

2021-02-08 Thread ニール・ゴンパ
@Conan-Kudo approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1527#pullrequestreview-585536561___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)

2021-02-08 Thread Panu Matilainen
@pmatilai commented on this pull request.



> @@ -5,8 +5,8 @@ EXTRA_DIST = \
 
 AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include -I.
 
-libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX @LUA_CFLAGS@
-libluaext_la_LIBADD = @LUA_LIBS@
+libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX $(LUA_CFLAGS)
+libluaext_la_LIBADD = $(LUA_LIBS)
 libluaext_la_SOURCES = \

This change dropped in the last push.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1527#discussion_r571829890___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)

2021-02-08 Thread Panu Matilainen
@pmatilai pushed 1 commit.

fda8abbecbaea8b47d015b48d833be45fe0ec9e7  Make Lua a hard requirement for rpm


-- 
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1527/files/f56e52d1b1fea74a147e5032ec7019a9d771c442..fda8abbecbaea8b47d015b48d833be45fe0ec9e7
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make Lua a hard requirement for rpm (#1527)

2021-02-08 Thread Panu Matilainen
@pmatilai commented on this pull request.



> @@ -5,8 +5,8 @@ EXTRA_DIST = \
 
 AM_CPPFLAGS = -I$(top_builddir) -I$(top_srcdir) -I$(top_builddir)/include -I.
 
-libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX @LUA_CFLAGS@
-libluaext_la_LIBADD = @LUA_LIBS@
+libluaext_la_CPPFLAGS = $(AM_CPPFLAGS) -DWITH_POSIX $(LUA_CFLAGS)
+libluaext_la_LIBADD = $(LUA_LIBS)
 libluaext_la_SOURCES = \

Oh, good catch. I initially looked at going the ZSTD-route, but then switched 
back but this one case was left behind.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/1527#discussion_r571808448___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint