Re: [Rpm-maint] [rpm-software-management/rpm] rpm should not use short gpg key ids in messages (Issue #2403)
They have been used in some places we know (eg yum) and then there are all those cases we don't know about. It's not the message that needs changing, but the idiotic API that emits this message. But to be able to deprecate that API we need something better first, which is a long time coming. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2403#issuecomment-1461441911 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Remove the internal OpenPGP parser (Issue #2414)
Actually there is a way to have the cake and eat it too: once upon a time, rpm called an external program (gpg back then) to verify signatures. It could do it again. It would be slower and there would be other compromises to be made no doubt, but between no security and slow security... -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2414#issuecomment-1461387463 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Please remove the "absolute symlink" warnings (Issue #2419)
@dmnks , in reality these warnings are not the same because the filename differs. The %patch case is similar: it *really* should print out the line number + line, it was only made the way it is to allow us to squeeze it into 4.18. We shouldn't get into a habit of producing bad warning messages for the purpose of suppressing them :laughing: -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2419#issuecomment-1461366433 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Please remove the "absolute symlink" warnings (Issue #2419)
Absolute symlinks are downright dangerous in combination to chrooted content. The absolute link okay inside the chroot of course, but have you never, ever looked at eg /var/lib/mock/ stuff without chrooting into it? The reason rpm complains about absolute symlinks is that they are problematic (for the user!) in the rpm context where chrooted installations is bread-and-butter daily business. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2419#issuecomment-1461362914 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Stop populating the lead structure (Issue #2368)
@pmatilai Just noting this - this is an instance where existing versions of `rpm` will yield a hard failure when reading RPMs built in this way https://github.com/rpm-software-management/rpm/blob/4afe2d14d33db82ccb41c0a8d5eb1a4db90762fc/lib/rpmlead.c#L98-L105 ``` [stderr] + rpm -vv --checksig /out/test.rpm ... [stdout] error: /out/test.rpm: illegal signature type ``` https://github.com/rpm-rs/rpm/actions/runs/4371356425/jobs/7647160417#step:5:876 -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2368#issuecomment-1461320583 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Stop populating the lead structure (Issue #2368)
This is true even of the "major" file format version number? Of all the fields, that one seems like it could *eventually* have some potential use? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2368#issuecomment-1461289916 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Please remove the "absolute symlink" warnings (Issue #2419)
Hmm, this looks like a good candidate for a treatment similar to #2383, i.e. suppressing these warnings into a single one with a count. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2419#issuecomment-1460429925 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Please remove the "absolute symlink" warnings (Issue #2419)
Just for the context, I am working on project to remove bundled assets in generated RDoc documentation: https://fedorapeople.org/cgit/vondruch/public_git/darkfish.git/ This is going to replace the assets with symlinks and I think the absolute symlinks is the right choice, because it allows users to copy the documentation around while keep it working. But in turn, that means that every rubygem-*-doc package will spit tens or more symlink warnings: ~~~ ... snip ... Processing files: rubygem-gem2rpm-1.0.2-1.fc39.noarch Provides: rubygem(gem2rpm) = 1.0.2 rubygem-gem2rpm = 1.0.2-1.fc39 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 Requires: /usr/bin/ruby ruby(rubygems) Processing files: rubygem-gem2rpm-doc-1.0.2-1.fc39.noarch warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/css/fonts.css -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/css/fonts.css warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/css/rdoc.css -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/css/rdoc.css warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/add.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/add.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/arrow_up.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/arrow_up.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/brick.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/brick.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/brick_link.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/brick_link.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/bug.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/bug.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/bullet_black.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/bullet_black.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/bullet_toggle_minus.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/bullet_toggle_minus.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/bullet_toggle_plus.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/bullet_toggle_plus.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/date.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/date.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/delete.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/delete.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/find.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/find.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/loadingAnimation.gif -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/loadingAnimation.gif warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/macFFBgHack.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/macFFBgHack.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/package.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/package.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/page_green.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/page_green.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/page_white_text.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/page_white_text.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/page_white_width.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/page_white_width.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/plugin.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/plugin.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/ruby.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/ruby.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/tag_blue.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/tag_blue.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/tag_green.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/tag_green.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/transparent.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/transparent.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/wrench.png -> /usr/share/rdoc-generator-fedora-darkfish/darkfish/images/wrench.png warning: absolute symlink: /usr/share/gems/doc/gem2rpm-1.0.2/rdoc/images/wrench_orange.png -> /usr
[Rpm-maint] [rpm-software-management/rpm] Please remove the (Issue #2419)
-- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2419 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Replace rpmTagType_e with a list of defines and an rpmTagType typedef (PR #2417)
That's reasonable. Let me dig in to the clang error a bit more here and restructure things. I will also track down the RPMTAG_NOT_FOUND issue too. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2417#issuecomment-1460324651 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] GPG key interpreted as PGP key (Issue #2410)
gpg-pubkey can only be imported through 'rpmkeys --import' or the API counterpart, which is what eg dnf does. Package scriptlets can't generally do this, it's blocked by the transaction lock. And yes, there's potential for treating pubkeys as dependency for signed packages (that use-case is one of the reasons they are in the db - AIUI, added long before my time). -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2410#issuecomment-1459907993 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix ignoring exit code of child scripts in case of EINTR (PR #2398)
Merged #2398 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2398#event-8694448485 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix ignoring exit code of child scripts in case of EINTR (PR #2398)
Looks good to me, thanks for the patch! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2398#issuecomment-1459797124 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Consider available memory and address space for parallel execution (PR #2418)
In my original version this also added a %getmem macro with similar arguments. Left it out to keep things simple and minimal, but would be trivial to add back if people think that's useful. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2418#issuecomment-1459791197 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Consider available memory and address space for parallel execution (PR #2418)
@pmatilai pushed 1 commit. e4d0e62d129569a714ae190b2ffd2fcc1296834d Make build parallelism memory and address-space aware (#804) -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2418/files/3353d6a4234dd8e2ead28fc7cffdae9cc68e24b1..e4d0e62d129569a714ae190b2ffd2fcc1296834d You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Replace rpmTagType_e with a list of defines and an rpmTagType typedef (PR #2417)
Where are we getting RPMTAG_NOT_FOUND as the tag type? That seems like bug to me, an unknown tag type should be 0, aka NULL type. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2417#issuecomment-1459758064 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] python: Use Py_hash_t instead of long in hdr_hash (PR #2408)
Please make a note of that in the commit message, just for future reference. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2408#issuecomment-1459754648 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Replace rpmTagType_e with a list of defines and an rpmTagType typedef (PR #2417)
I would leave the enum itself alone, we have a lot of those around so changing it all to defines is inconsistent. I wonder if clang ends up considering the nested #defines to be part of the enum? That nesting is weird and ugly anyhow and needs to be removed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2417#issuecomment-1459748741 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Consider available memory and address space for parallel execution (PR #2418)
@pmatilai pushed 2 commits. c859ebe35c54e58f689bc3d2097ff0acbe8172fa Make rpmio parallelism memory aware 3353d6a4234dd8e2ead28fc7cffdae9cc68e24b1 Make build parallelism memory and address-space aware (#804) -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2418/files/753763a1f971c0e041f934c442337a012eb7df5b..3353d6a4234dd8e2ead28fc7cffdae9cc68e24b1 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Consider available memory and address space for parallel execution (PR #2418)
@pmatilai pushed 3 commits.
28b7237b30ad02ad2babee4d8abb13c96ae360fa Add optional total/proc/thread
arguments to %{getncpus} macro
b09677daadfa7025eb2ff89560c0a886e043302c Make rpmio parallelism memory aware
753763a1f971c0e041f934c442337a012eb7df5b Make build parallelism memory and
address-space aware (#804)
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2418/files/23773283814db9b906611f3f3617a8712f499d74..753763a1f971c0e041f934c442337a012eb7df5b
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Consider available memory and address space for parallel execution (PR #2418)
See commits for details, but short summary: add optional proc/thread argument
to %{getncpus} macro which consider the available memory and address space,
based on newly added tunables for tasksize.
The goal here is to avoid build failures due to gross overallocation on
constrained systems, and to allow packagers to easily adjust for gigantic
builds.
Fixes: #804
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2418
-- Commit Summary --
* Add optional total/proc/thread arguments to %{getncpus} macro
* Make rpmio parallelism memory aware
* Make build parallelism memory and address-space aware (#804)
-- File Changes --
M build/build.c (9)
M docs/manual/macros.md (5)
M macros.in (11)
M rpmio/macro.c (91)
M rpmio/rpmio.c (2)
M tests/rpmmacro.at (24)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/2418.patch
https://github.com/rpm-software-management/rpm/pull/2418.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2418
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
