Re: [Rpm-maint] [rpm-software-management/rpm] Move OpenSSL code to newer API (PR #2723)

2023-10-16 Thread Panu Matilainen
@pmatilai commented on this pull request.



>  if (!constructDSASigningKey(key))
 goto done;
 
 if (!constructDSASignature(sig))
 goto done;
 
-if (DSA_do_verify(hash, hashlen, sig->dsa_sig, key->dsa_key) == 1)
+pkey_ctx = EVP_PKEY_CTX_new(key->evp_pkey, NULL);
+if (!pkey_ctx)
+goto done;
+
+if (EVP_PKEY_verify_init(pkey_ctx) != 1)
+goto done;
+
+//if (EVP_PKEY_CTX_set_rsa_padding(pkey_ctx, RSA_PKCS1_PADDING) <= 0)
+//goto done;

Leftovers?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2723#pullrequestreview-1680183986
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Move OpenSSL code to newer API (PR #2723)

2023-10-16 Thread Panu Matilainen
You'll need to rebase this first.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2723#issuecomment-1764567534
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Requires in package won't upgrade required package (Issue #2721)

2023-10-16 Thread Panu Matilainen
@pmatilai converted this issue into discussion #2724.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2721#event-10665161563
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Move OpenSSL code to newer API (PR #2723)

2023-10-16 Thread Florian Festi
Avoid the now deprecated RSA and DSA data types and use the generic EVP_PKEY

Resolves: #2294
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2723

-- Commit Summary --

  * Move OpenSSL code to newer API

-- File Changes --

M rpmio/digest_openssl.c (105)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2723.patch
https://github.com/rpm-software-management/rpm/pull/2723.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2723
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add support for macro aliases (PR #2722)

2023-10-16 Thread Panu Matilainen
@pmatilai pushed 1 commit.

ae954c8bf83258396a8357e9ad6ff4463e546cfd  Add support for macro aliases

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2722/files/9d08fee4f9425432c2abb2855680a6126d0e7b97..ae954c8bf83258396a8357e9ad6ff4463e546cfd
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add support for macro aliases (PR #2722)

2023-10-16 Thread Panu Matilainen
My immediate use-case for this will be in #2620 but I remember missing such 
functionality for at least one other purpose. And who knows what fun the 
packaging community comes up with...

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2722#issuecomment-1764274551
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Add support for macro aliases (PR #2722)

2023-10-16 Thread Panu Matilainen
Implement support for multi-level macro aliases, useful for the kind of thing 
aliases are: shortcuts, added level of indirection here and there for eg 
choosing between alternatives without copying and so on.

The new %alias macro primitive can be used to define an alias and get the alias 
definition. The dual functionality is necessary because all other references to 
the alias get routed to the aliased macro. With the exception of undefine which 
undefines the alias itself.

You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2722

-- Commit Summary --

  * Make macro name first character check more obvious
  * Validate the entire macro name in validName()
  * Add support for macro aliases

-- File Changes --

M docs/manual/macros.md (1)
M rpmio/macro.c (79)
M tests/rpmmacro.at (82)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2722.patch
https://github.com/rpm-software-management/rpm/pull/2722.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2722
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Queried tag fields not exhibited. Specified package name reported in output (Issue #2411)

2023-10-16 Thread Florian Festi
Closed #2411 as completed.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2411#event-10661746538
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Queried tag fields not exhibited. Specified package name reported in output (Issue #2411)

2023-10-16 Thread Florian Festi
The issue here is that these tags are arrays and need to be surrounded by 
square brackets. The CLI params already do that for you. They also include the 
flags and version while the using the tags directly only gives you the name 
part of the tripplets. You can just use `%{conflictnevrs}` and friends to get 
the same thing. See  
https://rpm-software-management.github.io/rpm/manual/queryformat.html and `rpm 
--querytags`.

Closing as not a bug.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2411#issuecomment-1763947973
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Requires in package won't upgrade required package (Issue #2721)

2023-10-16 Thread Matej Zerovnik
I hope this is the right tracker to post this.

I'm building a package that has a hard requirement on a specific package, but 
when installing the RPM, it doesn't get updated.

SPEC snippet:
```
%define dcgm_version _DCGM_
...
Name:dcgm_exporter
Version: %{version}
Release: %{patch}%{?dist}
...
Requires: datacenter-gpu-manager = 1:%{dcgm_version}-1
```

`dcgm_version` is set before build process starts (in my case, to version 
3.2.5).

When I check the RPM requirements, I can see the correct version:
```
rpm -qp dcgm_exporter-3.1.7-7.el8.x86_64.rpm --requires | grep datacen
datacenter-gpu-manager = 1:3.2.5-1
```

Then I instal the package with dnf install , but it will only install 
`dcgm_exporter` and won't also update `datacenter-gpu-manager` to required 
version.

```
[root@foobar ~]# rpm -qa | grep dcgm
dcgm_exporter-3.1.7-7.el8.x86_64
[root@foobar ~]# rpm -qa | grep datacenter
datacenter-gpu-manager-2.4.7-1.x86_64
```

The required version is available in the repos:
```
# dnf info datacenter-gpu-manager-1:3.2.5
Available Packages
Name : datacenter-gpu-manager
Epoch: 1
Version  : 3.2.5
Release  : 1
Architecture : x86_64
Size : 835 M
Source   : datacenter-gpu-manager-3.2.5-1.src.rpm
Repository   : nvidia
```

According to http://ftp.rpm.org/api/4.4.2.2/dependencies.html and 
http://ftp.rpm.org/max-rpm/s1-rpm-depend-manual-dependencies.html, 
configuration is correct. I also looked at some SRPMS from distro and the 
configuration is the same.

What am I doing wrong? I can't see the issue, thanks.





-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/2721
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint