Re: [Rpm-maint] [rpm-software-management/rpm] Add comments for SHA-2 file digest variants (#223)

2017-05-30 Thread Till Maas
I am fine with changing this to just mention the RFC 4880 instead. Btw. 
initially I got to this code because I wanted to figure out the meaning of the 
`filedigestalgo` RPM header field in the python code, i.e.:
`import rpm; rpm.TransactionSet().dbMatch().next()["filedigestalgo"]`

Is there a place where the python module is documented where I could add an 
reference to this as well (if it is missing).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/223#issuecomment-304998352___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add comments for SHA-2 file digest variants (#223)

2017-05-28 Thread Till Maas
According to the code `11` is SHA-224: 
https://github.com/tyll/rpm/blob/744fe3b1043ecd5e0854a535489435a2fe8ad027/rpmio/rpmpgp.h#L268

It seems to be there for cosmetic reasons according to:
https://bugzilla.redhat.com/show_bug.cgi?id=608599
https://github.com/tyll/rpm/commit/20cfa7d2b4c927798ad38126821d194fafd93ffe

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/223#issuecomment-304537476___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Add comments for SHA-2 file digest variants (#223)

2017-05-26 Thread Till Maas

You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/223

-- Commit Summary --

  * Add comments for SHA-2 file digest variants

-- File Changes --

M rpmio/rpmpgp.h (7)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/223.patch
https://github.com/rpm-software-management/rpm/pull/223.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/223
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint