Re: [Rpm-maint] [rpm-software-management/rpm] Don't use _nl_msg_cat_cntr if __GLIC__ is not defined (PR #2856)
@pastalian commented on this pull request. > @@ -532,7 +532,7 @@ static int filerequireTag(Header h, rpmtd td, > headerGetFlags hgflags) /* I18N look aside diversions */ -#if defined(ENABLE_NLS) +#if defined(ENABLE_NLS) && (defined(__GLIBC__) || !defined(__linux__)) like this? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2856#discussion_r1462984881 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Don't use _nl_msg_cat_cntr if __GLIC__ is not defined (PR #2856)
@pastalian pushed 1 commit. 68eefae75e63fb2a8f3b4a9253e73b6423ccd904 Don't use _nl_msg_cat_cntr if it's not available -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2856/files/da222f0d82721d17e57d491d2749a4bc44754b9d..68eefae75e63fb2a8f3b4a9253e73b6423ccd904 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Don't use _nl_msg_cat_cntr if __GLIC__ is not defined (PR #2856)
musl doesnt need to use libintl from GNU gettext because it has its own NLS implementation. Assuming _nl_msg_cat_cntr exists breaks the build against the musl system. ``` /usr/lib/gcc/x86_64-gentoo-linux-musl/13/../../../../x86_64-gentoo-linux-musl/bin/ld: ../lib/librpm.so.10.0.1: undefined reference to `_nl_msg_cat_cntr collect2: error: ld returned 1 exit status ``` You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2856 -- Commit Summary -- * Dont use _nl_msg_cat_cntr if __GLIC__ is not defined -- File Changes -- M lib/tagexts.c (6) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/2856.patch https://github.com/rpm-software-management/rpm/pull/2856.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2856 You are receiving this because you are subscribed to this thread. Message ID: rpm-software-management/rpm/pull/2...@github.com ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Implement declarative buildsystem support (f02ddfd)
@pmatilai broken table, need two `|` here. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/commit/f02ddfd121d91ea00a534a0e04374c478f56d437#r137085850 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Fix a macro in the comment (PR #2749)
Nothing defines RPMHOME, replace it with RPM_CONFIGDIR. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2749 -- Commit Summary -- * Fix a macro in the comment -- File Changes -- M macros.in (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/2749.patch https://github.com/rpm-software-management/rpm/pull/2749.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2749 You are receiving this because you are subscribed to this thread. Message ID: rpm-software-management/rpm/pull/2...@github.com ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
