Re: [Rpm-maint] [rpm-software-management/rpm] Add Fedora integration CI job (Issue #3118)

2024-05-23 Thread Michal Domonkos
Here's another, even more embarrassing case that would've been discovered if 
Mock had been actually tested with the new stack: #3120, #3121

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3118#issuecomment-2126490849
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Fedora integration CI job (Issue #3118)

2024-05-21 Thread Michal Domonkos
At that point, though, we might as well have a proper spec file and build an 
actual rpm package out of the sources, much like what Packit does... I need to 
think about this more.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3118#issuecomment-2122273240
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add Fedora integration CI job (Issue #3118)

2024-05-21 Thread Michal Domonkos
Note that it might also turn out that many of our existing tests aren't 
compatible with e.g. redhat-rpm-config's macros, in which case we might need to 
either adjust those or disable them.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3118#issuecomment-2122233469
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Add Fedora integration CI job (Issue #3118)

2024-05-21 Thread Michal Domonkos
While testing rpm in a "sterile" environment where no distribution specific rpm 
configuration is present has its value, there are cases where integration with 
an actual distribution such as Fedora may reveal bugs in otherwise innocent 
looking patches, such as the just-discovered #3115.

The test-suite (mktree script) should gain an option that installs rpm into the 
`/usr` prefix (instead of the default `/usr/local`) so that it reflects rpm's 
actual deployment better, specifically so that any distribution-provided macros 
(like redhat-rpm-config on Fedora) are effective during the test-suite. Then, 
we can add another CI job that runs the test-suite against such an image (or 
something of that sorts). Details to be figured out.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/3118
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint