Re: [Rpm-maint] [rpm-software-management/rpm] Add documentation for %getncpus macro (#707)

2019-05-16 Thread Panu Matilainen
pmatilai commented on this pull request.



> @@ -66,6 +66,7 @@ to perform useful operations. The current list is
%trace  toggle print of debugging information before/after
expansion
%dump   print the active (i.e. non-covered) macro table
+   %getncpus   return the number of CPUs

It's not a function, it doesn't really "return" anything, it expands to the 
number of CPUs, and more precisely CPUs *available to the current process*, 
which is not necessarily the same thing as total number of processors on the 
system. Fix those and its an obvious keeper.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/707#pullrequestreview-238251416___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Add documentation for %getncpus macro (#707)

2019-05-16 Thread Florian Festi
Merged #707 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/707#event-2345667434___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Add documentation for %getncpus macro (#707)

2019-05-16 Thread pavlinamv

You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/707

-- Commit Summary --

  * Add documentation for %getncpus macro

-- File Changes --

M doc/manual/macros (1)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/707.patch
https://github.com/rpm-software-management/rpm/pull/707.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/707
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint