[Rpm-maint] [rpm-software-management/rpm] Add the marker to the appropriate expression error messages (#869)
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/869 -- Commit Summary -- * Add the marker to the appropriate expression error messages -- File Changes -- M rpmio/expression.c (15) M tests/rpmmacro.at (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/869.patch https://github.com/rpm-software-management/rpm/pull/869.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/869 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add the marker to the appropriate expression error messages (#869)
"p" is used for this purpose throughout the code otherwise, please stick with that. Calling it "position" all of a sudden makes it look like something entirely different and somehow more important due to the longer name. https://www.kernel.org/doc/html/v4.10/process/coding-style.html#naming is good guidance even if rpm style differs differs on the details. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/869#issuecomment-536473295___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add the marker to the appropriate expression error messages (#869)
Replaced by #877 with slightly adjusted commit message and the variable name. Thanks for the patch though. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/869#issuecomment-536987521___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Add the marker to the appropriate expression error messages (#869)
Closed #869. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/869#event-2676603901___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint