Re: [Rpm-maint] [rpm-software-management/rpm] Bring RPM_MASK_RETURN_TYPE in to the signed int range (PR #2459)
Merged #2459 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2459#event-8912848488 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Bring RPM_MASK_RETURN_TYPE in to the signed int range (PR #2459)
Updated. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2459#issuecomment-1494250574 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Bring RPM_MASK_RETURN_TYPE in to the signed int range (PR #2459)
@dcantrell pushed 1 commit. c9bb079d2b24a980228d7c2acfb4be040d231b5f Remove RPM_MASK_RETURN_TYPE from rpmTagReturnType_e; make it a macro -- View it on GitHub: https://github.com/rpm-software-management/rpm/pull/2459/files/dfe986b9ec9c73d18c2fc9c0139887bc3a35ae4d..c9bb079d2b24a980228d7c2acfb4be040d231b5f You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Bring RPM_MASK_RETURN_TYPE in to the signed int range (PR #2459)
Oh, I would just move the mask out of the enum into a define. The actual return types are enumerations but the mask is not one to begin with. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2459#issuecomment-1491384128 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Bring RPM_MASK_RETURN_TYPE in to the signed int range (PR #2459)
Set to 0x (or 4294901760), I was getting: error: ISO C restricts enumerator values to range of 'int' (4294901760 is too large) [-Werror,-Wpedantic] This happened not when building rpm itself, but when building rpminspect which links with librpm and uses rpm's headers. The system in question was FreeBSD 13.1 which has clang 13.0.0. It is a corner case, but I like testing things on non-Linux platforms as often as I can to find errors like this. With this change, the rpm test suite passes for me. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2459 -- Commit Summary -- * Bring RPM_MASK_RETURN_TYPE in to the signed int range -- File Changes -- M include/rpm/rpmtag.h (2) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/2459.patch https://github.com/rpm-software-management/rpm/pull/2459.diff -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2459 You are receiving this because you are subscribed to this thread. Message ID:___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
