Re: [Rpm-maint] [rpm-software-management/rpm] Correct description of %verbose and %getconfdir in the macro manual (#856)
Merged #856 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/856#event-2657674654___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Correct description of %verbose and %getconfdir in the macro manual (#856)
pmatilai approved this pull request. Fine now, thanks. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/856#pullrequestreview-292348903___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Correct description of %verbose and %getconfdir in the macro manual (#856)
Pushed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/856#issuecomment-534511549___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Correct description of %verbose and %getconfdir in the macro manual (#856)
@pavlinamv pushed 1 commit. 9ae7eb4858f381cad3925c96a0ec1b4d7d9f36cc Correct description of %verbose and %getconfdir in the macro manual -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/856/files/857558f100343a971af19c720dea71749f53456b..9ae7eb4858f381cad3925c96a0ec1b4d7d9f36cc ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Correct description of %verbose and %getconfdir in the macro manual (#856)
Forgot to push? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/856#issuecomment-534509060___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Correct description of %verbose and %getconfdir in the macro manual (#856)
Changed according to the comment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/856#issuecomment-534508114___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Correct description of %verbose and %getconfdir in the macro manual (#856)
Good spotting, but please move them to the appropriate groups as well: the first group of macros takes no argument, so %getconfdir belongs there, and %{verbose:...} belongs to the group that does. The grouping is pretty arbitrary of course, %define/%undefine/%global are in the middle of different types of macros for no good reason. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/856#issuecomment-534500534___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Correct description of %verbose and %getconfdir in the macro manual (#856)
I looked into rpm/doc/manual/macros to check 0 and 1 added into the builtinmacros[] in PR #853. Values added in PR #853 are correct, but description of macros %verbose and %getconfdir in manual is confusing. So that is why I created this PR. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/856 -- Commit Summary -- * Correct description of %verbose and %getconfdir in the macro manual -- File Changes -- M doc/manual/macros (5) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/856.patch https://github.com/rpm-software-management/rpm/pull/856.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/856 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint