Re: [Rpm-maint] [rpm-software-management/rpm] Fix file handle leaks (PR #3068)

2024-04-29 Thread Shreenidhi Shedi 
@sshedi pushed 1 commit.

ffc49917d14bde347d2281e0784547cffda7f199  rpmpgppubkeyfingerprint.c: code 
cleanups

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3068/files/4befafdf0bd6c625d7817c8a020dde4affa71d90..ffc49917d14bde347d2281e0784547cffda7f199
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Fix file handle leaks (PR #3068)

2024-04-29 Thread Florian Festi 
@ffesti commented on this pull request.



>   return 1;
 }
 
 if (!fpr || strcmp(got, fpr) != 0) {
fprintf(stderr, "%s:\n got '%s'\nexpected '%s'\n",
 filename, got, fpr ? fpr : "");
free(got);
+   fclose(f);

This should probably also free(fp);

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3068#pullrequestreview-2028919643
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

Re: [Rpm-maint] [rpm-software-management/rpm] Fix file handle leaks (PR #3068)

2024-04-29 Thread Florian Festi 
@ffesti commented on this pull request.



>   return 1;
 }
 
 // We expect success now.
 char *got = rpmhex(fp, fplen);
 if (! got) {
fprintf(stderr, "%s: rpmhex failed\n", filename);
+   fclose(f);

This should probably also free(fp);

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3068#pullrequestreview-2028918055
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint

[Rpm-maint] [rpm-software-management/rpm] Fix file handle leaks (PR #3068)

2024-04-29 Thread Shreenidhi Shedi 

You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/3068

-- Commit Summary --

  * Fix file handle leaks

-- File Changes --

M tests/rpmpgppubkeyfingerprint.c (9)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/3068.patch
https://github.com/rpm-software-management/rpm/pull/3068.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/3068
You are receiving this because you are subscribed to this thread.

Message ID: rpm-software-management/rpm/pull/3...@github.com
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint