[Rpm-maint] [rpm-software-management/rpm] Fix off-by-one error (#68)
There's an off-by-one error in base64_decode_value which results in undefined
behaviour:
void* out;
size_t len;
rpmBase64Decode("\x7b", &out, &len);
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/68
-- Commit Summary --
* Fix off-by-one error
-- File Changes --
M rpmio/base64.c (2)
-- Patch Links --
https://github.com/rpm-software-management/rpm/pull/68.patch
https://github.com/rpm-software-management/rpm/pull/68.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/68
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix off-by-one error (#68)
Merged #68. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/68#event-671730499___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix off-by-one error (#68)
Can one of the admins verify this patch? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/68#issuecomment-221546656___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix off-by-one error (#68)
Can one of the admins verify this patch? --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/68#issuecomment-221547569___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Fix off-by-one error (#68)
> @@ -104,7 +104,7 @@ static int base64_decode_value(unsigned char value_in)
> {
> static const int decoding[] =
> {62,-1,-1,-1,63,52,53,54,55,56,57,58,59,60,61,-1,-1,-1,-2,-1,-1,-1,0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,-1,-1,-1,-1,-1,-1,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51};
> value_in -= 43;
> - if (value_in > sizeof(decoding)/sizeof(int))
> + if (value_in >= sizeof(decoding)/sizeof(int))
my 2 cents: also change to sizeof(decoding)/sizeof(decoding[0])
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/68/files/0964912b94f9f48a0a812fbfbb2f996dbd93eff0#r64628600___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint
