Re: [Rpm-maint] [rpm-software-management/rpm] Initialize verifyFlags for specialdir (#656)
Oh and thanks for the patch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/656#issuecomment-480783158___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Initialize verifyFlags for specialdir (#656)
pmatilai approved this pull request. What I said above... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/656#pullrequestreview-223768749___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Initialize verifyFlags for specialdir (#656)
Merged #656 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/656#event-2259269042___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] Initialize verifyFlags for specialdir (#656)
The pre-existing line seemed looked a little odd there so I dug up history a bit. The line added here was intentionally removed (instead of fixing the typo) in commit bde88ada3a0fbd17f9b5db9fb5426eb0f1ff5efd, but I'm not so sure about the rationale now: current flags are copied everywhere else so why not here? Anyway, this clearly fixes the verify flags thing, doesn't affect anything else that I can see, and makes things more consistent so it's probably the right thing to do. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/656#issuecomment-480781621___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] Initialize verifyFlags for specialdir (#656)
Initialize verifyFlags for specialdir, because FileEntryFree(>cur) zeroed all fields, including verifyFlags, so we have to fill them again. Closes issue #655 Note: only slightly tested You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/656 -- Commit Summary -- * Initialize verifyFlags for specialdir -- File Changes -- M build/files.c (1) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/656.patch https://github.com/rpm-software-management/rpm/pull/656.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/656 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
