[Rpm-maint] [rpm-software-management/rpm] Make the default DB backend macro configurable (#157)

2017-02-17 Thread Panu Matilainen
Currently if rpm is built with --enable-ndb, all newly created databases are in 
that format. We'll need more control over the format to enable safe testing 
which is a prerequisite for wider testing.

We need a macro configurable (%_rpmdb_backend or such) to set the default 
backend for newly created databases and default to BDB regardless of build-time 
options to be on the safe side. To convert to another format, changing the 
macro value to another backend and doing `rpmdb --rebuilddb` should be enough 
as rebuilddb starts by creating a new db.

It should be possible to arbitrarily switch back and forth between backends by 
--rebuilddb. I suspect currently it only works going from BDB to NDB because 
the files from the old database are not cleaned out on rebuild, IIRC. So that 
might need fixing too.


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/157___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the default DB backend macro configurable (#157)

2017-05-31 Thread Florian Festi
Closed #157.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/157#event-1104183049___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the default DB backend macro configurable (#157)

2017-05-31 Thread Florian Festi
Pushed as e96fde89c6e0ac59da5cb22fa310235a9918aa7a

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/157#issuecomment-305188662___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the default DB backend macro configurable (#157)

2017-06-12 Thread Panu Matilainen
Reopened #157.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/157#event-1119411723___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the default DB backend macro configurable (#157)

2017-06-12 Thread Panu Matilainen
Commit e96fde8 doesn't quite cut it:

```
backend/dbi.c: In function ‘dbDetectBackend’:
backend/dbi.c:39:5: warning: not enough variable arguments to fit a sentinel 
[-Wformat=]
 char *db_backend = rpmExpand("%{?_db_backend}");
 ^~~~
```

Also I think software should honor configuration: if it's configured to use db 
X then it shouldn't override that through auto-detection. Maybe more like, 
autodetect if %_db_backend set to "auto" or undefined, otherwise do what the 
configuration says even if it means erroring out of the situation?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/157#issuecomment-307781882___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the default DB backend macro configurable (#157)

2017-07-11 Thread Florian Festi
Fixed the warning above.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/157#issuecomment-314380356___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the default DB backend macro configurable (#157)

2017-07-30 Thread Igor Gnatenko
@ffesti should we close this issue?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/157#issuecomment-318926262___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the default DB backend macro configurable (#157)

2017-08-09 Thread Panu Matilainen
Closed #157.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/157#event-1199237544___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Make the default DB backend macro configurable (#157)

2017-08-09 Thread Panu Matilainen
Yeah I suppose we can close this now, the format detection is less of an issue 
now that rebuillddb wipes out the old cruft.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/issues/157#issuecomment-321278375___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint