Re: [Rpm-maint] [rpm-software-management/rpm] Minor test-suite tweaks/fixes, volume V (PR #2696)

2023-10-05 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -52,6 +52,23 @@ RUN dnf -y install \
   && dnf clean all
 RUN echo "%_dbpath $(rpm --eval '%_dbpath')" > /root/.rpmmacros
 
+# Workaround for pkgconf(1)'s unlisted dependency on rpm.
+# This is needed for cmake to work without an rpm installation.
+RUN ln -sf $(rpm --eval '%{_target_platform}%{?_gnu}')-pkg-config \

Yup, the funny thing is, I've also made myself a note back then to file a bug 
for this and of course never got around to it :smile:

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2696#discussion_r1346940752
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Minor test-suite tweaks/fixes, volume V (PR #2696)

2023-10-05 Thread Michal Domonkos
@dmnks commented on this pull request.



> @@ -52,6 +52,23 @@ RUN dnf -y install \
   && dnf clean all
 RUN echo "%_dbpath $(rpm --eval '%_dbpath')" > /root/.rpmmacros
 
+# Workaround for pkgconf(1)'s unlisted dependency on rpm.
+# This is needed for cmake to work without an rpm installation.
+RUN ln -sf $(rpm --eval '%{_target_platform}%{?_gnu}')-pkg-config \
+   /usr/bin/pkg-config
+
+RUN rpm -e --nodeps --nodb \

Oh! Turns out this is a pretty new feature: 
6de0d31ed3b4907dbd7e1683a18ea3a28790614d
So yup, good timing :laughing: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2696#discussion_r1346937787
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Minor test-suite tweaks/fixes, volume V (PR #2696)

2023-10-05 Thread Panu Matilainen
Merged #2696 into master.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2696#event-10558544793
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Minor test-suite tweaks/fixes, volume V (PR #2696)

2023-10-05 Thread Panu Matilainen
@pmatilai commented on this pull request.



> @@ -52,6 +52,23 @@ RUN dnf -y install \
   && dnf clean all
 RUN echo "%_dbpath $(rpm --eval '%_dbpath')" > /root/.rpmmacros
 
+# Workaround for pkgconf(1)'s unlisted dependency on rpm.
+# This is needed for cmake to work without an rpm installation.
+RUN ln -sf $(rpm --eval '%{_target_platform}%{?_gnu}')-pkg-config \

This is pretty sick really... (not objecting to what doing it, just grumbling 
as a reminder to myself to file a bug on Fedora's pkgconf)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2696#pullrequestreview-1658928754
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Minor test-suite tweaks/fixes, volume V (PR #2696)

2023-10-04 Thread Panu Matilainen
@pmatilai commented on this pull request.



> @@ -52,6 +52,23 @@ RUN dnf -y install \
   && dnf clean all
 RUN echo "%_dbpath $(rpm --eval '%_dbpath')" > /root/.rpmmacros
 
+# Workaround for pkgconf(1)'s unlisted dependency on rpm.
+# This is needed for cmake to work without an rpm installation.
+RUN ln -sf $(rpm --eval '%{_target_platform}%{?_gnu}')-pkg-config \
+   /usr/bin/pkg-config
+
+RUN rpm -e --nodeps --nodb \

Hey, somebody found a use-case for --nodb :partying_face: 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2696#pullrequestreview-1658924593
You are receiving this because you are subscribed to this thread.

Message ID: ___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Minor test-suite tweaks/fixes, volume V (PR #2696)

2023-10-04 Thread Michal Domonkos
@dmnks pushed 4 commits.

8194e8fdf95dc456397b2ea173bb9b0918246a3c  Move snapshot() to mktree.common
9037d8290b254fa6f243dd97f314cafb8cb4b7b2  Rename make target env to atshell
e67e5e7d2f7953183002d64c2812f65d05fdf92b  Keep record of stock RPM in RPMDB in 
Dockerfile
6db07918dfc25dbe7b3bd5016b689d06df9716c6  Add build stages to Dockerfile

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2696/files/df79a0c58fff90a5e9e65121d6ca3125595faf54..6db07918dfc25dbe7b3bd5016b689d06df9716c6
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Minor test-suite tweaks/fixes, volume V (PR #2696)

2023-10-04 Thread Michal Domonkos
@dmnks pushed 5 commits.

14aa701f38bcd1c32b31d5d9db47e78a68c10535  Make snapshot() work without CMake 
configuration
55c24dc6e444ebd3ce54af1d2ecafe6fbc808b4d  Move snapshot() to mktree.common
f9113d73e2f9de831874b1299967b9fa563d186d  Rename make target env to atshell
0d9df924a81f90c27bdbed3b51edb3cef8b31b41  Keep record of stock RPM in RPMDB in 
Dockerfile
df79a0c58fff90a5e9e65121d6ca3125595faf54  Add build stages to Dockerfile

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2696/files/3f4e7c960abdcf71f7ac31192f1d6cc9ba4c..df79a0c58fff90a5e9e65121d6ca3125595faf54
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Minor test-suite tweaks/fixes, volume V (PR #2696)

2023-10-04 Thread Michal Domonkos
@dmnks pushed 2 commits.

e281e9559faafa0f23d666cc59aa4a73080ea95b  Keep record of stock RPM in RPMDB in 
Dockerfile
1d7f308059202bfd44c0cdbfcfaf7f699949aef7  Add build stages to Dockerfile

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2696/files/4871b237fe9b98b001880b7d2dc70a72b6526ff8..1d7f308059202bfd44c0cdbfcfaf7f699949aef7
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


Re: [Rpm-maint] [rpm-software-management/rpm] Minor test-suite tweaks/fixes, volume V (PR #2696)

2023-10-04 Thread Michal Domonkos
@dmnks pushed 3 commits.

e3d8b2a627ffb79e6a098788f39fd8a2b40288cf  Make snapshot() work without CMake 
configuration
dd08d096253a1f1137ad4cde32fbbf977a2281f4  Move snapshot() to mktree.common
4871b237fe9b98b001880b7d2dc70a72b6526ff8  Rename make target env to atshell

-- 
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2696/files/945dc36f0e7b9c7d4edcfb0710d9299eaa1badd6..4871b237fe9b98b001880b7d2dc70a72b6526ff8
You are receiving this because you are subscribed to this thread.

Message ID: 
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint


[Rpm-maint] [rpm-software-management/rpm] Minor test-suite tweaks/fixes, volume V (PR #2696)

2023-10-04 Thread Michal Domonkos
These are mostly preparatory work for #2643.
You can view, comment on, or merge this pull request online at:

  https://github.com/rpm-software-management/rpm/pull/2696

-- Commit Summary --

  * Dont assume PWD of / in tests
  * Make snapshot() work without CMake configuration
  * Move snapshot() to mktree.common
  * Rename make target env to atshell

-- File Changes --

M tests/CMakeLists.txt (4)
M tests/README.md (4)
M tests/atlocal.in (51)
M tests/mktree.common (49)
M tests/mktree.fedora (9)
M tests/mktree.rootfs (2)
M tests/rpmbuild.at (2)
M tests/rpmgeneral.at (4)
M tests/rpmi.at (2)
M tests/rpmmacro.at (2)
M tests/rpmquery.at (2)

-- Patch Links --

https://github.com/rpm-software-management/rpm/pull/2696.patch
https://github.com/rpm-software-management/rpm/pull/2696.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2696
You are receiving this because you are subscribed to this thread.

Message ID: rpm-software-management/rpm/pull/2...@github.com
___
Rpm-maint mailing list
Rpm-maint@lists.rpm.org
http://lists.rpm.org/mailman/listinfo/rpm-maint