Re: [Rpm-maint] [rpm-software-management/rpm] RFC Building with PIC enabled is not supported in OS/2. (#350)
The right thing to do is actually not have rpm mess with -fPIC and friends at all, these are up to distro/platform policies etc. Done in commit d7dfd0dc0c6ad7fc067a1d0e292a74e134b0720c so this PR is not needed at all. And by doing the right thing we actually end up reducing the need for those OS2-specific patches, and those kind of changes are always welcome. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/350#issuecomment-366693047___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC Building with PIC enabled is not supported in OS/2. (#350)
Closed #350. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/350#event-1480549359___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC Building with PIC enabled is not supported in OS/2. (#350)
The CI failures in this PR are unrelated to this change. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/350#issuecomment-343175160___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC Building with PIC enabled is not supported in OS/2. (#350)
The error in the CI is due to its dependency on #349. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/350#issuecomment-343174936___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC Building with PIC enabled is not supported in OS/2. (#350)
Erk, wrong PR for this. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/350#issuecomment-343175043___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
Re: [Rpm-maint] [rpm-software-management/rpm] RFC Building with PIC enabled is not supported in OS/2. (#350)
Conan-Kudo approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/350#pullrequestreview-74173395___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
[Rpm-maint] [rpm-software-management/rpm] RFC Building with PIC enabled is not supported in OS/2. (#350)
Disable PIC flags in OS/2 build. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/350 -- Commit Summary -- * Building with PIC enabled is not supported in OS/2. -- File Changes -- M configure.ac (8) -- Patch Links -- https://github.com/rpm-software-management/rpm/pull/350.patch https://github.com/rpm-software-management/rpm/pull/350.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/350 ___ Rpm-maint mailing list Rpm-maint@lists.rpm.org http://lists.rpm.org/mailman/listinfo/rpm-maint
